Re: liburing 2.3 API/ABI breakage

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Thu, Nov 10, 2022 at 09:43:48AM +0000, Dylan Yudaken wrote:
> On Wed, 2022-11-09 at 20:58 -0500, Stefan Hajnoczi wrote:
> > > 2. Going from size_t to unsigned int is ABI breakage. This is
> > > mitigated
> > >    on CPU architectures that share 32-bit/64-bit registers (i.e.
> > > rax/eax
> > >    on x86-64 and r0/x0/w0 on aarch64). There's no guarantee this
> > > works
> > >    on all architectures, especially when the calling convention
> > > passes
> > >    arguments on the stack.
> > 
> > Good news, I realized that io_uring_prep_getxattr() and friends are
> > static inline functions. ABI breakage doesn't come into play because
> > they are compiled into the application.
> 
> Additionally the inline code was doing the narrowing cast anyway, so
> there was no narrowing issues.
> 
> I really should have put this explanation in the commit message though
> - will remember for next time.

Thanks, that will help!

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]