diff for duplicates of <Y20t0AMNqvtyOwp2@google.com> diff --git a/a/1.txt b/N1/1.txt index da6b3b6..34ee85c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,9 +2,9 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > @@ -9283,7 +9283,13 @@ static int > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > ? int cpu = smp_processor_id(); -> > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > ? +> > > int cpu = smp_processor_id(); +> > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > - WARN_ON(!irqs_disabled()); > > > + /* > > > + * Compatibility checks are done when loading KVM and when enabling @@ -14,7 +14,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > > + * an offline CPU. > > > + */ > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > ? +> > > > > > > Also, the logic of: > > @@ -27,7 +27,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > the IRQ is indeed disabled. > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > check. > > @@ -55,3 +55,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: No worries, more than once while working through this code, I've considered setting up one of those evidence boards from the movies with string and push pins to help connect all the dots. +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N1/content_digest index b66cb45..abaf698 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,18 +3,53 @@ "ref\088e920944de70e7d69a98f74005b49c59b5aaa3b.camel@intel.com\0" "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Thu, 10 Nov 2022 16:58:56 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0mjrosato@linux.ibm.com <mjrosato@linux.ibm.com>" + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + mpe@ellerman.id.au <mpe@ellerman.id.au> + linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + frankja@linux.ibm.com <frankja@linux.ibm.com> + maz@kernel.org <maz@kernel.org> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + Gao + Chao <chao.gao@intel.com> + farman@linux.ibm.com <farman@linux.ibm.com> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + tglx@linutronix.de <tglx@linutronix.de> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + Yamahata + Isaku <isaku.yamahata@intel.com> + farosas@linux.ibm.com <farosas@linux.ibm.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + palmer@dabbelt.com <palmer@dabbelt.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + pbonzini@redhat.com <pbonzini@redhat.com> + vkuznets@redhat.com <vkuznets@redhat.com> + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On Thu, Nov 10, 2022, Huang, Kai wrote:\n" "> On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > @@ -9283,7 +9283,13 @@ static int\n" "> > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > ?\tint cpu = smp_processor_id();\n" - "> > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > ?\n" + "> > > \302\240\tint cpu = smp_processor_id();\n" + "> > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > \302\240\n" "> > > -\tWARN_ON(!irqs_disabled());\n" "> > > +\t/*\n" "> > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -24,7 +59,7 @@ "> > > +\t * an offline CPU.\n" "> > > +\t */\n" "> > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > ?\n" + "> > > \302\240\n" "> > \n" "> > Also, the logic of:\n" "> > \n" @@ -37,7 +72,7 @@ "> > the IRQ is indeed disabled.\n" "> > \n" "> > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > check.\n" "> > \n" @@ -64,6 +99,10 @@ "\n" "No worries, more than once while working through this code, I've considered setting\n" "up one of those evidence boards from the movies with string and push pins to help\n" - connect all the dots. + "connect all the dots.\n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -a76a9753f0f3699ebf54c88f2cd6f1d779ff916883e6387da2220bb5f606f449 +8b6a433b4bf30a2b9df0f2e3872bcdbc6b36e33321d5dde538be36f186d570bf
diff --git a/a/1.txt b/N2/1.txt index da6b3b6..8d9281a 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,9 +2,9 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > @@ -9283,7 +9283,13 @@ static int > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > ? int cpu = smp_processor_id(); -> > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > ? +> > > int cpu = smp_processor_id(); +> > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > - WARN_ON(!irqs_disabled()); > > > + /* > > > + * Compatibility checks are done when loading KVM and when enabling @@ -14,7 +14,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > > + * an offline CPU. > > > + */ > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > ? +> > > > > > > Also, the logic of: > > @@ -27,7 +27,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > the IRQ is indeed disabled. > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > check. > > diff --git a/a/content_digest b/N2/content_digest index b66cb45..8e993be 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,18 +3,58 @@ "ref\088e920944de70e7d69a98f74005b49c59b5aaa3b.camel@intel.com\0" "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Thu, 10 Nov 2022 16:58:56 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0farman@linux.ibm.com <farman@linux.ibm.com>" + frankja@linux.ibm.com <frankja@linux.ibm.com> + mjrosato@linux.ibm.com <mjrosato@linux.ibm.com> + vkuznets@redhat.com <vkuznets@redhat.com> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + palmer@dabbelt.com <palmer@dabbelt.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + maz@kernel.org <maz@kernel.org> + anup@brainfault.org <anup@brainfault.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + pbonzini@redhat.com <pbonzini@redhat.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + farosas@linux.ibm.com <farosas@linux.ibm.com> + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + mpe@ellerman.id.au <mpe@ellerman.id.au> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + Yamahata + Isaku <isaku.yamahata@intel.com> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + james.morse@arm.com <james.morse@arm.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + Gao + Chao <chao.gao@intel.com> + oliver.upton@linux.dev <oliver.upton@linux.dev> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + " linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org>\0" "\00:1\0" "b\0" "On Thu, Nov 10, 2022, Huang, Kai wrote:\n" "> On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > @@ -9283,7 +9283,13 @@ static int\n" "> > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > ?\tint cpu = smp_processor_id();\n" - "> > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > ?\n" + "> > > \302\240\tint cpu = smp_processor_id();\n" + "> > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > \302\240\n" "> > > -\tWARN_ON(!irqs_disabled());\n" "> > > +\t/*\n" "> > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -24,7 +64,7 @@ "> > > +\t * an offline CPU.\n" "> > > +\t */\n" "> > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > ?\n" + "> > > \302\240\n" "> > \n" "> > Also, the logic of:\n" "> > \n" @@ -37,7 +77,7 @@ "> > the IRQ is indeed disabled.\n" "> > \n" "> > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > check.\n" "> > \n" @@ -66,4 +106,4 @@ "up one of those evidence boards from the movies with string and push pins to help\n" connect all the dots. -a76a9753f0f3699ebf54c88f2cd6f1d779ff916883e6387da2220bb5f606f449 +4668cbe6c76b70fb857633f12ca2b02e502ca37a9211540db49fa98b64256c4b
diff --git a/a/1.txt b/N3/1.txt index da6b3b6..2698232 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -2,9 +2,9 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > @@ -9283,7 +9283,13 @@ static int > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > ? int cpu = smp_processor_id(); -> > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > ? +> > > int cpu = smp_processor_id(); +> > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > - WARN_ON(!irqs_disabled()); > > > + /* > > > + * Compatibility checks are done when loading KVM and when enabling @@ -14,7 +14,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > > + * an offline CPU. > > > + */ > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > ? +> > > > > > > Also, the logic of: > > @@ -27,7 +27,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > the IRQ is indeed disabled. > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > check. > > @@ -55,3 +55,8 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: No worries, more than once while working through this code, I've considered setting up one of those evidence boards from the movies with string and push pins to help connect all the dots. + +_______________________________________________ +linux-riscv mailing list +linux-riscv@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-riscv diff --git a/a/content_digest b/N3/content_digest index b66cb45..6972a2b 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,18 +3,58 @@ "ref\088e920944de70e7d69a98f74005b49c59b5aaa3b.camel@intel.com\0" "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Thu, 10 Nov 2022 16:58:56 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0farman@linux.ibm.com <farman@linux.ibm.com>" + frankja@linux.ibm.com <frankja@linux.ibm.com> + mjrosato@linux.ibm.com <mjrosato@linux.ibm.com> + vkuznets@redhat.com <vkuznets@redhat.com> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + palmer@dabbelt.com <palmer@dabbelt.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + maz@kernel.org <maz@kernel.org> + anup@brainfault.org <anup@brainfault.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + pbonzini@redhat.com <pbonzini@redhat.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + farosas@linux.ibm.com <farosas@linux.ibm.com> + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + mpe@ellerman.id.au <mpe@ellerman.id.au> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + Yamahata + Isaku <isaku.yamahata@intel.com> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + james.morse@arm.com <james.morse@arm.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + Gao + Chao <chao.gao@intel.com> + oliver.upton@linux.dev <oliver.upton@linux.dev> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + " linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org>\0" "\00:1\0" "b\0" "On Thu, Nov 10, 2022, Huang, Kai wrote:\n" "> On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > @@ -9283,7 +9283,13 @@ static int\n" "> > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > ?\tint cpu = smp_processor_id();\n" - "> > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > ?\n" + "> > > \302\240\tint cpu = smp_processor_id();\n" + "> > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > \302\240\n" "> > > -\tWARN_ON(!irqs_disabled());\n" "> > > +\t/*\n" "> > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -24,7 +64,7 @@ "> > > +\t * an offline CPU.\n" "> > > +\t */\n" "> > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > ?\n" + "> > > \302\240\n" "> > \n" "> > Also, the logic of:\n" "> > \n" @@ -37,7 +77,7 @@ "> > the IRQ is indeed disabled.\n" "> > \n" "> > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > check.\n" "> > \n" @@ -64,6 +104,11 @@ "\n" "No worries, more than once while working through this code, I've considered setting\n" "up one of those evidence boards from the movies with string and push pins to help\n" - connect all the dots. + "connect all the dots.\n" + "\n" + "_______________________________________________\n" + "linux-riscv mailing list\n" + "linux-riscv@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-riscv -a76a9753f0f3699ebf54c88f2cd6f1d779ff916883e6387da2220bb5f606f449 +51098152b3e906ece6761cedb8d240d62e568f165bb05df6e8df69cc7951ef48
diff --git a/a/1.txt b/N4/1.txt index da6b3b6..8d9281a 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -2,9 +2,9 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > @@ -9283,7 +9283,13 @@ static int > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > ? int cpu = smp_processor_id(); -> > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > ? +> > > int cpu = smp_processor_id(); +> > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > - WARN_ON(!irqs_disabled()); > > > + /* > > > + * Compatibility checks are done when loading KVM and when enabling @@ -14,7 +14,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > > + * an offline CPU. > > > + */ > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > ? +> > > > > > > Also, the logic of: > > @@ -27,7 +27,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > the IRQ is indeed disabled. > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > check. > > diff --git a/a/content_digest b/N4/content_digest index b66cb45..dce03ba 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -3,18 +3,57 @@ "ref\088e920944de70e7d69a98f74005b49c59b5aaa3b.camel@intel.com\0" "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Thu, 10 Nov 2022 16:58:56 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0mjrosato@linux.ibm.com <mjrosato@linux.ibm.com>" + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + frankja@linux.ibm.com <frankja@linux.ibm.com> + maz@kernel.org <maz@kernel.org> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + james.morse@arm.com <james.morse@arm.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + Gao + Chao <chao.gao@intel.com> + farman@linux.ibm.com <farman@linux.ibm.com> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + kvm@vger.kernel.org <kvm@vg er.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + tglx@linutronix.de <tglx@linutronix.de> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + Yamahata + Isaku <isaku.yamahata@intel.com> + farosas@linux.ibm.com <farosas@linux.ibm.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + oliver.upton@linux.dev <oliver.upton@linux.dev> + palmer@dabbelt.com <palmer@dabbelt.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + anup@brainfault.org <anup@brainfault.org> + pbonzini@redhat.com <pbonzini@redhat.com> + vkuznets@redhat.com <vkuznets@redhat.com> + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On Thu, Nov 10, 2022, Huang, Kai wrote:\n" "> On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > @@ -9283,7 +9283,13 @@ static int\n" "> > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > ?\tint cpu = smp_processor_id();\n" - "> > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > ?\n" + "> > > \302\240\tint cpu = smp_processor_id();\n" + "> > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > \302\240\n" "> > > -\tWARN_ON(!irqs_disabled());\n" "> > > +\t/*\n" "> > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -24,7 +63,7 @@ "> > > +\t * an offline CPU.\n" "> > > +\t */\n" "> > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > ?\n" + "> > > \302\240\n" "> > \n" "> > Also, the logic of:\n" "> > \n" @@ -37,7 +76,7 @@ "> > the IRQ is indeed disabled.\n" "> > \n" "> > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > check.\n" "> > \n" @@ -66,4 +105,4 @@ "up one of those evidence boards from the movies with string and push pins to help\n" connect all the dots. -a76a9753f0f3699ebf54c88f2cd6f1d779ff916883e6387da2220bb5f606f449 +56f012092d4dbead65bc8af376e39de5d1a0066c6891b316e570c97d82f3032a
diff --git a/a/1.txt b/N5/1.txt index da6b3b6..79e3288 100644 --- a/a/1.txt +++ b/N5/1.txt @@ -2,9 +2,9 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > @@ -9283,7 +9283,13 @@ static int > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > ? int cpu = smp_processor_id(); -> > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > ? +> > > int cpu = smp_processor_id(); +> > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > - WARN_ON(!irqs_disabled()); > > > + /* > > > + * Compatibility checks are done when loading KVM and when enabling @@ -14,7 +14,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > > + * an offline CPU. > > > + */ > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > ? +> > > > > > > Also, the logic of: > > @@ -27,7 +27,7 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: > > the IRQ is indeed disabled. > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > check. > > @@ -55,3 +55,8 @@ On Thu, Nov 10, 2022, Huang, Kai wrote: No worries, more than once while working through this code, I've considered setting up one of those evidence boards from the movies with string and push pins to help connect all the dots. + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N5/content_digest index b66cb45..b3f4a98 100644 --- a/a/content_digest +++ b/N5/content_digest @@ -3,18 +3,58 @@ "ref\088e920944de70e7d69a98f74005b49c59b5aaa3b.camel@intel.com\0" "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Thu, 10 Nov 2022 16:58:56 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0farman@linux.ibm.com <farman@linux.ibm.com>" + frankja@linux.ibm.com <frankja@linux.ibm.com> + mjrosato@linux.ibm.com <mjrosato@linux.ibm.com> + vkuznets@redhat.com <vkuznets@redhat.com> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + palmer@dabbelt.com <palmer@dabbelt.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + maz@kernel.org <maz@kernel.org> + anup@brainfault.org <anup@brainfault.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + pbonzini@redhat.com <pbonzini@redhat.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + farosas@linux.ibm.com <farosas@linux.ibm.com> + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + mpe@ellerman.id.au <mpe@ellerman.id.au> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + Yamahata + Isaku <isaku.yamahata@intel.com> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + james.morse@arm.com <james.morse@arm.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + Gao + Chao <chao.gao@intel.com> + oliver.upton@linux.dev <oliver.upton@linux.dev> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + " linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org>\0" "\00:1\0" "b\0" "On Thu, Nov 10, 2022, Huang, Kai wrote:\n" "> On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > @@ -9283,7 +9283,13 @@ static int\n" "> > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > ?\tint cpu = smp_processor_id();\n" - "> > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > ?\n" + "> > > \302\240\tint cpu = smp_processor_id();\n" + "> > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > \302\240\n" "> > > -\tWARN_ON(!irqs_disabled());\n" "> > > +\t/*\n" "> > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -24,7 +64,7 @@ "> > > +\t * an offline CPU.\n" "> > > +\t */\n" "> > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > ?\n" + "> > > \302\240\n" "> > \n" "> > Also, the logic of:\n" "> > \n" @@ -37,7 +77,7 @@ "> > the IRQ is indeed disabled.\n" "> > \n" "> > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > check.\n" "> > \n" @@ -64,6 +104,11 @@ "\n" "No worries, more than once while working through this code, I've considered setting\n" "up one of those evidence boards from the movies with string and push pins to help\n" - connect all the dots. + "connect all the dots.\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -a76a9753f0f3699ebf54c88f2cd6f1d779ff916883e6387da2220bb5f606f449 +62957d9b27c1efe2db4a1682478019563ec3914c6594c936a34f7ef486457298
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.