From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Wolfram Sang <wsa@kernel.org>, Tomasz Figa <tfiga@chromium.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Hidenori Kobayashi <hidenorik@google.com>,
stable@vger.kernel.org, linux-i2c@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/1] i2c: Restore initial power state when we are done.
Date: Fri, 11 Nov 2022 09:31:14 +0900 [thread overview]
Message-ID: <Y22X0iDsF2Y5cy95@google.com> (raw)
In-Reply-To: <20221109-i2c-waive-v5-1-2839667f8f6a@chromium.org>
On (22/11/10 17:20), Ricardo Ribalda wrote:
> A driver that supports I2C_DRV_ACPI_WAIVE_D0_PROBE is not expected to
> power off a device that it has not powered on previously.
>
> For devices operating in "full_power" mode, the first call to
> `i2c_acpi_waive_d0_probe` will return 0, which means that the device
> will be turned on with `dev_pm_domain_attach`.
>
> If probe fails or the device is removed the second call to
> `i2c_acpi_waive_d0_probe` will return 1, which means that the device
> will not be turned off. This is, it will be left in a different power
> state. Lets fix it.
>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: stable@vger.kernel.org
> Fixes: b18c1ad685d9 ("i2c: Allow an ACPI driver to manage the device's power state during probe")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
next prev parent reply other threads:[~2022-11-11 0:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 16:20 [PATCH v5 0/1] i2c: Restore power status of device if probe fail or device is removed Ricardo Ribalda
2022-11-10 16:20 ` [PATCH v5 1/1] i2c: Restore initial power state when we are done Ricardo Ribalda
2022-11-11 0:20 ` Hidenori Kobayashi
2022-11-11 0:31 ` Sergey Senozhatsky [this message]
2022-11-12 20:24 ` Wolfram Sang
2022-11-14 10:33 ` Mika Westerberg
2022-11-14 10:51 ` Ricardo Ribalda
2022-11-14 11:10 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y22X0iDsF2Y5cy95@google.com \
--to=senozhatsky@chromium.org \
--cc=hidenorik@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tfiga@chromium.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.