All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ferry Toth <ftoth@exalondelft.nl>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Sean Anderson <sean.anderson@seco.com>,
	Liu Shixin <liushixin2@huawei.com>, Ferry Toth <fntoth@gmail.com>,
	Andrey Smirnov <andrew.smirnov@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 1/2] usb: ulpi: defer ulpi_register on ulpi_read_id timeout
Date: Fri, 11 Nov 2022 07:08:36 +0100	[thread overview]
Message-ID: <Y23m5H5zRbv5fwcF@kroah.com> (raw)
In-Reply-To: <20221110211132.297512-2-ftoth@exalondelft.nl>

On Thu, Nov 10, 2022 at 10:11:31PM +0100, Ferry Toth wrote:
> Since commit 0f010171
> Dual Role support on Intel Merrifield platform broke due to rearranging
> the call to dwc3_get_extcon().

Please see the kernel documentation for how to refer to commits.  This
should be written as:

	Since commit 0f0101719138 ("usb: dwc3: Don't switch OTG -> peripheral if
	extcon is present"), Dual role....

> It appears to be caused by ulpi_read_id() on the first test write failing
> with -ETIMEDOUT. Currently ulpi_read_id() expects to discover the phy via
> DT when the test write fails and returns 0 in that case even if DT does not
> provide the phy. As a result usb probe completes without phy.
> 
> Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>

What commit does this fix?

Should this also get a cc: stable?

thanks,

greg k-h

  reply	other threads:[~2022-11-11  6:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 21:11 [PATCH v2 0/2] usb: dwc3: core: defer probe on ulpi_read_id timeout Ferry Toth
2022-11-10 21:11 ` [PATCH v2 1/2] usb: ulpi: defer ulpi_register " Ferry Toth
2022-11-11  6:08   ` Greg Kroah-Hartman [this message]
2022-11-14 21:55     ` Ferry Toth
2022-11-11 14:04   ` Ferry Toth
2022-12-12 21:51     ` Stephen Boyd
2022-11-10 21:11 ` [PATCH v2 2/2] usb: dwc3: core: defer probe " Ferry Toth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y23m5H5zRbv5fwcF@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=fntoth@gmail.com \
    --cc=ftoth@exalondelft.nl \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=liushixin2@huawei.com \
    --cc=sean.anderson@seco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.