From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Arseniy Krasnov <AVKrasnov@sberdevices.ru>,
Krasnov Arseniy <oxffffaa@gmail.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Bobby Eshleman <bobby.eshleman@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"edumazet@google.com" <edumazet@google.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
kernel <kernel@sberdevices.ru>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v3 00/11] virtio/vsock: experimental zerocopy receive
Date: Fri, 11 Nov 2022 20:45:13 +0000 [thread overview]
Message-ID: <Y260WSJKJXtaJQZi@bullseye> (raw)
In-Reply-To: <20221111134715.qxgu7t4c7jse24hp@sgarzare-redhat>
On Fri, Nov 11, 2022 at 02:47:15PM +0100, Stefano Garzarella wrote:
> Hi Arseniy,
> maybe we should start rebasing this series on the new support for skbuff: https://lore.kernel.org/lkml/20221110171723.24263-1-bobby.eshleman@bytedance.com/
>
> CCing Bobby to see if it's easy to integrate since you're both changing the
> packet allocation.
>
This looks like the packet allocation can be married somewhat nicely in
since SKBs may be built from pages using build_skb(). There may be some
tweaking necessary though, since it also uses the tail chunk of the page
to hold struct skb_shared_info IIRC.
I left some comments on the patch with the allocator in it.
>
> Maybe to avoid having to rebase everything later, it's already worthwhile to
> start using Bobby's patch with skbuff.
>
I'll be waiting until Monday to see if some more feedback comes in
before sending out v4, so I expect v4 early next week, FWIW.
Best,
Bobby
next prev parent reply other threads:[~2022-11-11 20:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 19:33 [RFC PATCH v3 00/11] virtio/vsock: experimental zerocopy receive Arseniy Krasnov
2022-11-06 19:36 ` [RFC PATCH v3 01/11] virtio/vsock: rework packet allocation logic Arseniy Krasnov
2022-11-06 19:50 ` Christophe JAILLET
2022-11-07 5:23 ` Arseniy Krasnov
2022-11-07 21:24 ` Christophe JAILLET
2022-11-07 21:31 ` Arseniy Krasnov
2022-11-11 20:35 ` Bobby Eshleman
2022-11-06 19:38 ` [RFC PATCH v3 02/11] virtio/vsock: update, 'virtio_transport_recv_pkt()' Arseniy Krasnov
2022-11-06 19:40 ` [RFC PATCH v3 03/11] af_vsock: add zerocopy receive logic Arseniy Krasnov
2022-11-11 13:55 ` Stefano Garzarella
2022-11-11 13:55 ` Stefano Garzarella
2022-11-06 19:41 ` [RFC PATCH v3 04/11] virtio/vsock: add transport zerocopy callback Arseniy Krasnov
2022-11-10 11:15 ` Arseniy Krasnov
2022-11-06 19:43 ` [RFC PATCH v3 05/11] vhost/vsock: switch packet's buffer allocation Arseniy Krasnov
2022-11-06 19:45 ` [RFC PATCH v3 06/11] vhost/vsock: enable zerocopy callback Arseniy Krasnov
2022-11-06 19:47 ` [RFC PATCH v3 07/11] virtio/vsock: " Arseniy Krasnov
2022-11-06 19:48 ` [RFC PATCH v3 08/11] test/vsock: rework message bound test Arseniy Krasnov
2022-11-11 14:00 ` Stefano Garzarella
2022-11-11 14:00 ` Stefano Garzarella
2022-11-06 19:50 ` [RFC PATCH v3 09/11] test/vsock: add big message test Arseniy Krasnov
2022-11-06 19:51 ` [RFC PATCH v3 10/11] test/vsock: add receive zerocopy tests Arseniy Krasnov
2022-11-06 19:54 ` [RFC PATCH v3 11/11] test/vsock: vsock_rx_perf utility Arseniy Krasnov
2022-11-11 13:47 ` [RFC PATCH v3 00/11] virtio/vsock: experimental zerocopy receive Stefano Garzarella
2022-11-11 13:47 ` Stefano Garzarella
2022-11-11 14:06 ` Stefano Garzarella
2022-11-11 14:06 ` Stefano Garzarella
2022-11-11 18:35 ` Arseniy Krasnov
2022-11-11 20:45 ` Bobby Eshleman [this message]
2022-11-12 11:40 ` Arseniy Krasnov
2022-11-13 10:04 ` Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y260WSJKJXtaJQZi@bullseye \
--to=bobbyeshleman@gmail.com \
--cc=AVKrasnov@sberdevices.ru \
--cc=bobby.eshleman@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.