All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Vlastimil Babka <vbabka@suse.cz>, oe-kbuild-all@lists.linux.dev
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [lkp] [+5395 bytes kernel size regression] [i386-tinyconfig] [b7c8731082] Deprecating and removing SLOB
Date: Fri, 11 Nov 2022 09:24:07 -0800	[thread overview]
Message-ID: <Y26FN02o7jhV87wl@localhost> (raw)
In-Reply-To: <Y25E9cJbhDAKi1vd@99bb1221be19>

On Fri, Nov 11, 2022 at 08:49:57PM +0800, kernel test robot wrote:
> FYI, we noticed a +5395 bytes kernel size regression due to commit:
> 
> commit: b7c873108294f0fd19c7e4d6b038a05375b3cd33 (Deprecating and removing SLOB)
> url: https://github.com/intel-lab-lkp/linux/commits/Vlastimil-Babka/mm-slob-rename-CONFIG_SLOB-to-CONFIG_SLOB_DEPRECATED/20221111-183529
> base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-everything
> patch subject: [PATCH] mm, slob: rename CONFIG_SLOB to CONFIG_SLOB_DEPRECATED
> 
> 
> Details as below (size data is obtained by `nm --size-sort vmlinux`):
> 
> e1e3de44: Merge branch 'mm-nonmm-unstable' into mm-everything
> b7c87310: Deprecating and removing SLOB

This patch has the net effect of switching tiny over from SLOB to SLUB,
which causes a 5k+ size regression.

I *absolutely* appreciate the value of removing this much code, and I'm
not going to propose keeping SLOB for the sole reason of being 5k
smaller; it's not worth keeping a whole allocator for that. I also
wouldn't be surprised if we get *some* of that back by simplifications
this change enables in the rest of the kernel.

But I'm wondering if there might be any low-hanging fruit that could
slim down SLUB to the tune of 5k or so, that has been previously ignored
because SLOB served that use case? For instance, largely self-contained
bits of SLUB functionality that could be omitted on the tiniest of
systems?

- Josh Triplett

  reply	other threads:[~2022-11-11 17:24 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 15:55 Deprecating and removing SLOB Vlastimil Babka
2022-11-08 18:18 ` Christophe Leroy
2022-11-08 19:17   ` Andrew Morton
2022-11-08 18:46 ` Roman Gushchin
2022-11-08 20:13   ` Yosry Ahmed
2022-11-09  9:09     ` Vlastimil Babka
2022-11-08 21:44 ` Pasha Tatashin
2022-11-09  9:00   ` Vlastimil Babka
2022-11-09  9:00     ` Vlastimil Babka
2022-11-09  9:00     ` Vlastimil Babka
2022-11-09  9:00     ` Vlastimil Babka
2022-11-09 15:50     ` Aaro Koskinen
2022-11-09 15:50       ` Aaro Koskinen
2022-11-09 15:50       ` Aaro Koskinen
2022-11-09 15:50       ` Aaro Koskinen
2022-11-09 16:45       ` Geert Uytterhoeven
2022-11-09 16:45         ` Geert Uytterhoeven
2022-11-09 16:45         ` Geert Uytterhoeven
2022-11-09 16:45         ` Geert Uytterhoeven
2022-11-09 17:45       ` Mike Rapoport
2022-11-09 17:45         ` Mike Rapoport
2022-11-09 17:45         ` Mike Rapoport
2022-11-09 17:45         ` Mike Rapoport
2022-11-09 21:16       ` Janusz Krzysztofik
2022-11-09 21:16         ` Janusz Krzysztofik
2022-11-09 21:16         ` Janusz Krzysztofik
2022-11-09 21:16         ` Janusz Krzysztofik
2022-11-09 17:57   ` Conor.Dooley
2022-11-09 23:00     ` Damien Le Moal
2022-11-11 10:25       ` Vlastimil Babka
2022-11-12  1:40         ` Damien Le Moal
2022-11-11 10:33   ` Vlastimil Babka
2022-11-11 10:33     ` Vlastimil Babka
2022-11-11 10:33     ` Vlastimil Babka
2022-11-11 10:33     ` Vlastimil Babka
2022-11-11 12:49     ` [lkp] [+5395 bytes kernel size regression] [i386-tinyconfig] [b7c8731082] " kernel test robot
2022-11-11 17:24       ` Josh Triplett [this message]
2022-11-11 21:11         ` Vlastimil Babka
2022-11-17  8:57         ` Vlastimil Babka
2022-11-11 20:46     ` Conor Dooley
2022-11-11 20:46       ` Conor Dooley
2022-11-11 20:46       ` Conor Dooley
2022-11-11 20:46       ` Conor Dooley
2022-11-12  1:40       ` Damien Le Moal
2022-11-12  1:40         ` Damien Le Moal
2022-11-12  1:40         ` Damien Le Moal
2022-11-12  1:40         ` Damien Le Moal
2022-11-14  1:55       ` Damien Le Moal
2022-11-14  1:55         ` Damien Le Moal
2022-11-14  1:55         ` Damien Le Moal
2022-11-14  1:55         ` Damien Le Moal
2022-11-14  5:48         ` Damien Le Moal
2022-11-14  5:48           ` Damien Le Moal
2022-11-14  5:48           ` Damien Le Moal
2022-11-14  5:48           ` Damien Le Moal
2022-11-14  9:36           ` Vlastimil Babka
2022-11-14  9:36             ` Vlastimil Babka
2022-11-14  9:36             ` Vlastimil Babka
2022-11-14  9:36             ` Vlastimil Babka
2022-11-14 11:35             ` Damien Le Moal
2022-11-14 11:35               ` Damien Le Moal
2022-11-14 11:35               ` Damien Le Moal
2022-11-14 11:35               ` Damien Le Moal
2022-11-14 14:47               ` Hyeonggon Yoo
2022-11-14 14:47                 ` Hyeonggon Yoo
2022-11-14 14:47                 ` Hyeonggon Yoo
2022-11-14 14:47                 ` Hyeonggon Yoo
2022-11-15  4:24                 ` Damien Le Moal
2022-11-15  4:24                   ` Damien Le Moal
2022-11-15  4:24                   ` Damien Le Moal
2022-11-15  4:24                   ` Damien Le Moal
2022-11-15  4:28                   ` Damien Le Moal
2022-11-15  4:28                     ` Damien Le Moal
2022-11-15  4:28                     ` Damien Le Moal
2022-11-15  4:28                     ` Damien Le Moal
2022-11-16  7:57                     ` Matthew Wilcox
2022-11-16  7:57                       ` Matthew Wilcox
2022-11-16  7:57                       ` Matthew Wilcox
2022-11-16  7:57                       ` Matthew Wilcox
2022-11-16  8:02                       ` Damien Le Moal
2022-11-16  8:02                         ` Damien Le Moal
2022-11-16  8:02                         ` Damien Le Moal
2022-11-16  8:02                         ` Damien Le Moal
2022-11-16 17:51                   ` Vlastimil Babka
2022-11-16 17:51                     ` Vlastimil Babka
2022-11-16 17:51                     ` Vlastimil Babka
2022-11-16 17:51                     ` Vlastimil Babka
2022-11-17  0:22                     ` Damien Le Moal
2022-11-17  0:22                       ` Damien Le Moal
2022-11-17  0:22                       ` Damien Le Moal
2022-11-17  0:22                       ` Damien Le Moal
2022-11-21  4:30                     ` Damien Le Moal
2022-11-21  4:30                       ` Damien Le Moal
2022-11-21  4:30                       ` Damien Le Moal
2022-11-21  4:30                       ` Damien Le Moal
2022-11-21 17:02                       ` Vlastimil Babka
2022-11-21 17:02                         ` Vlastimil Babka
2022-11-21 17:02                         ` Vlastimil Babka
2022-11-21 17:02                         ` Vlastimil Babka
2022-11-14 11:50             ` Hyeonggon Yoo
2022-11-14 11:50               ` Hyeonggon Yoo
2022-11-14 11:50               ` Hyeonggon Yoo
2022-11-14 11:50               ` Hyeonggon Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y26FN02o7jhV87wl@localhost \
    --to=josh@joshtriplett.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.