All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Ronan Pigott <ronan@rjp.ie>
Cc: Derrick Stolee <derrickstolee@github.com>,
	git@vger.kernel.org, me@ttaylor.com
Subject: Re: [PATCH] maintenance: improve error reporting for unregister
Date: Fri, 11 Nov 2022 17:43:48 -0500	[thread overview]
Message-ID: <Y27QJNZWF41Kp04W@nand.local> (raw)
In-Reply-To: <Y224GSbupvWD8mu/@nand.local>

On Thu, Nov 10, 2022 at 09:48:57PM -0500, Taylor Blau wrote:
> On Thu, Nov 10, 2022 at 03:53:10PM -0700, Ronan Pigott wrote:
> >  Documentation/git-maintenance.txt |  2 +-
> >  builtin/gc.c                      | 22 ++++++++++++++--------
> >  t/t7900-maintenance.sh            |  6 +++++-
> >  3 files changed, 20 insertions(+), 10 deletions(-)
>
> Thanks, this looks pretty reasonable to me. Let's make sure Stolee has a
> look, too.

Actually, scratch that -- I missed a couple of important things that
I'll point out inline in the patch above. Sorry about that.


Thanks,
Taylor

  reply	other threads:[~2022-11-11 22:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 22:53 [PATCH] maintenance: improve error reporting for unregister Ronan Pigott
2022-11-11  2:48 ` Taylor Blau
2022-11-11 22:43   ` Taylor Blau [this message]
2022-11-11 22:45 ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y27QJNZWF41Kp04W@nand.local \
    --to=me@ttaylorr.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylor.com \
    --cc=ronan@rjp.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.