From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 1/6] cfg80211: Avoid clashing function prototypes
Date: Mon, 31 Oct 2022 16:03:25 -0500 [thread overview]
Message-ID: <Y2A4HS36KtXYKvE7@work> (raw)
In-Reply-To: <a92ffa8db8228b5cb41939dc37d6ee677aef0619.camel@sipsolutions.net>
On Fri, Oct 28, 2022 at 10:22:47AM +0200, Johannes Berg wrote:
> Hm.
>
> If you're splitting out per driver,
>
> > +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
> > @@ -9870,7 +9870,7 @@ static int ipw_wx_sw_reset(struct net_device *dev,
> >
> > /* Rebase the WE IOCTLs to zero for the handler array */
> > static iw_handler ipw_wx_handlers[] = {
> > - IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname),
> > + IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname),
>
> I can see how this (and similar) still belongs into this patch since
> it's related to the cfg80211 change, but
>
> > +++ b/drivers/net/wireless/intersil/orinoco/wext.c
> > @@ -154,9 +154,10 @@ static struct iw_statistics *orinoco_get_wireless_stats(struct net_device *dev)
> >
> > static int orinoco_ioctl_setwap(struct net_device *dev,
> > struct iw_request_info *info,
> > - struct sockaddr *ap_addr,
> > + union iwreq_data *wrqu,
> > char *extra)
> > {
> > + struct sockaddr *ap_addr = &wrqu->ap_addr;
>
> why this (and similar) too?
mmh... yeah; orinoco should be a separate patch. :)
Thanks
--
Gustavo
next prev parent reply other threads:[~2022-10-31 22:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 20:16 [PATCH v2 0/6] Avoid clashing function prototypes Gustavo A. R. Silva
2022-10-27 20:17 ` [PATCH v2 1/6] cfg80211: " Gustavo A. R. Silva
2022-10-28 8:22 ` Johannes Berg
2022-10-31 17:01 ` Gustavo A. R. Silva
2022-10-31 21:03 ` Gustavo A. R. Silva [this message]
2022-10-27 20:18 ` [PATCH v2 2/6] hostap: " Gustavo A. R. Silva
2022-10-29 7:26 ` Kees Cook
2022-11-01 9:36 ` Kalle Valo
2022-10-27 20:19 ` [PATCH v2 3/6] zd1201: " Gustavo A. R. Silva
2022-10-29 7:08 ` Kees Cook
2022-10-27 20:20 ` [PATCH v2 4/6] airo: " Gustavo A. R. Silva
2022-10-27 20:20 ` [PATCH v2 5/6] bna: " Gustavo A. R. Silva
2022-10-29 7:12 ` Kees Cook
2022-10-31 17:13 ` Gustavo A. R. Silva
2022-10-31 21:04 ` Gustavo A. R. Silva
2022-10-27 20:22 ` [PATCH v2 6/6] staging: ks7010: " Gustavo A. R. Silva
2022-10-29 7:20 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2A4HS36KtXYKvE7@work \
--to=gustavoars@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.