From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 6C93F98642C for ; Mon, 31 Oct 2022 18:52:46 +0000 (UTC) Date: Mon, 31 Oct 2022 13:26:21 -0400 From: Stefan Hajnoczi Message-ID: References: <20221007165643.3920613-1-usama.arif@bytedance.com> <20221007165643.3920613-4-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Z02RkBrIY9zPCs6H" Content-Disposition: inline In-Reply-To: Subject: Re: [virtio-dev] Re: [External] Re: [PATCH v3 3/4] content: Introduce driver/device auxiliary notifications for MMIO To: Usama Arif Cc: virtio-dev@lists.oasis-open.org, mst@redhat.com, ndragazis@arrikto.com, fam.zheng@bytedance.com, liangma@liangbit.com List-ID: --Z02RkBrIY9zPCs6H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 31, 2022 at 02:22:22PM +0000, Usama Arif wrote: > On 27/10/2022 22:27, Stefan Hajnoczi wrote: > > On Fri, Oct 07, 2022 at 05:56:42PM +0100, Usama Arif wrote: > > > This includes the additions to the corresponding device and driver > > > conformances. > > >=20 > > > Signed-off-by: Usama Arif > > > Signed-off-by: Stefan Hajnoczi > >=20 > > You can keep this. One thought: > >=20 > > I realized that virtio-mmio support won't be very useful until > > virtio-mmio gets MSI-X support because drivers currently cannot > > differentiate between device auxiliary notifications. > >=20 > > Stefan >=20 > Did you mean drivers currently cannot differentiate between "driver" > auxiliary notifications? The driver will be able to be able to choose the > index it wants to notifiy using DeviceAuxNotificationIndex. Yes, sorry! >=20 > I can add the following line in the Interrupt Status change of the patch = if > it makes sense? > "As MSI-X is not available, it is not possible to determine which driver > auxiliary notification occured, hence only a single notification is > supported." Yes, that is how I understood the mechanism to work. Depending on the nature of the device-specific event, it may be unworkable for the driver to have no way of identifying the exact event. Stefan --Z02RkBrIY9zPCs6H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmNgBT0ACgkQnKSrs4Gr c8jvpQf/WL5FURQxS94zpcGacgT0v8wfcDzOrCSbBJg3mC358dTzNBVqnaz9ix7P hSBjF9qmRK18CxjAnOSAW6eeHZ2PpmE1qJiBf08XRu3MogNQYtsj56WmVoPQ/rob 4JVxotOI+WLDL8zYU07t/PnJFtaBCfuHsJjW5ed00Y4+HyAvhGgypD9cJslbivQ6 rkg7KG96kBUv71/hsNgM8shJBWr1CKRODbMsJhnHpTDO86tdVJHCHWtYZmDSTg43 RCpnHrRI5e2LI7Fzt/bgzryv2XPW9AGmkna1JqDFc0Iy/qx1rAqDbEtVsHbHwlsY JQMX4tiWulccM0+DMTa0IymdL210zg== =WSQw -----END PGP SIGNATURE----- --Z02RkBrIY9zPCs6H--