From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] tpm: st33zp24: remove pointless checks on probe
Date: Tue, 1 Nov 2022 03:10:52 +0200 [thread overview]
Message-ID: <Y2ByHKkX8mHJK7EL@kernel.org> (raw)
In-Reply-To: <20221027071349.991730-3-dmitry.torokhov@gmail.com>
On Thu, Oct 27, 2022 at 12:13:49AM -0700, Dmitry Torokhov wrote:
> Remove tests for SPI device or I2C client to be non-NULL because
> driver core will never call driver's probe method without having
> a valid device structure.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v3: no changes
> v2: reworked commit message
>
> drivers/char/tpm/st33zp24/i2c.c | 6 ------
> drivers/char/tpm/st33zp24/spi.c | 7 -------
> 2 files changed, 13 deletions(-)
>
> diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c
> index 614c7d8ed84f..8156bb2af78c 100644
> --- a/drivers/char/tpm/st33zp24/i2c.c
> +++ b/drivers/char/tpm/st33zp24/i2c.c
> @@ -106,12 +106,6 @@ static int st33zp24_i2c_probe(struct i2c_client *client,
> {
> struct st33zp24_i2c_phy *phy;
>
> - if (!client) {
> - pr_info("%s: i2c client is NULL. Device not accessible.\n",
> - __func__);
> - return -ENODEV;
> - }
> -
> if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
> dev_info(&client->dev, "client not i2c capable\n");
> return -ENODEV;
> diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c
> index 25b0e7994d27..c249d3f964fd 100644
> --- a/drivers/char/tpm/st33zp24/spi.c
> +++ b/drivers/char/tpm/st33zp24/spi.c
> @@ -223,13 +223,6 @@ static int st33zp24_spi_probe(struct spi_device *dev)
> {
> struct st33zp24_spi_phy *phy;
>
> - /* Check SPI platform functionnalities */
> - if (!dev) {
> - pr_info("%s: dev is NULL. Device is not accessible.\n",
> - __func__);
> - return -ENODEV;
> - }
> -
> phy = devm_kzalloc(&dev->dev, sizeof(struct st33zp24_spi_phy),
> GFP_KERNEL);
> if (!phy)
> --
> 2.38.0.135.g90850a2211-goog
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2022-11-01 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 7:13 [PATCH v3 1/3] tpm: st33zp24: drop support for platform data Dmitry Torokhov
2022-10-27 7:13 ` [PATCH v3 2/3] tpm: st33zp24: switch to using gpiod API Dmitry Torokhov
2022-11-01 1:10 ` Jarkko Sakkinen
2022-10-27 7:13 ` [PATCH v3 3/3] tpm: st33zp24: remove pointless checks on probe Dmitry Torokhov
2022-11-01 1:10 ` Jarkko Sakkinen [this message]
2022-11-01 1:10 ` [PATCH v3 1/3] tpm: st33zp24: drop support for platform data Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2ByHKkX8mHJK7EL@kernel.org \
--to=jarkko@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.