All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jing Leng <3090101217@zju.edu.cn>
Cc: jleng@ambarella.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, pawell@cadence.com
Subject: Re: [PATCH v2] usb: cdnsp: Fix wrong transmission direction of EP0
Date: Tue, 1 Nov 2022 06:09:29 +0100	[thread overview]
Message-ID: <Y2CqCXAQcWxKTmBa@kroah.com> (raw)
In-Reply-To: <20221101044433.5627-1-3090101217@zju.edu.cn>

On Tue, Nov 01, 2022 at 12:44:33PM +0800, Jing Leng wrote:
> EP0 transfer is bi-directional, but in the cdnsp gadget, the
> transmission direction of EP0 is not changed after it is
> initialized to IN, so the OUT data from EP0 received by the host
> is invalid.
> 
> The value of ep0_expect_in will change according to the value of
> bRequestType in the SETUP transaction of control transfer, so we
> can use it as the transmission direction of EP0.
> 
> Signed-off-by: Jing Leng <3090101217@zju.edu.cn>
> Signed-off-by: Jing Leng <jleng@ambarella.com>
> ---
> ChangeLog v1->v2:
> - Rebase the patch.
> - Make email addresses ('From' and 'Signed-off-by') consistent.

That didn't happen.  You list yourself twice, and the last one does not
match the From: line on the patch.

Also the verification did not even work showing that this is an invalid
email from 3090101217@zju.edu.cn, so I can't trust it at all.

Please fix up your email system to properly send email from
ambarella.com with the correct verification.

thanks,

greg k-h

  reply	other threads:[~2022-11-01  5:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26  7:59 [PATCH] usb: cdnsp: Fix wrong transmission direction of EP0 3090101217
2022-10-08 15:40 ` Greg KH
2022-11-01  4:44 ` [PATCH v2] " Jing Leng
2022-11-01  5:09   ` Greg KH [this message]
2022-11-01  6:17   ` [PATCH v3] " Jing Leng
2022-11-01  9:43     ` Greg KH
2022-11-02  7:35       ` Pawel Laszczak
2022-11-03 14:45       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2CqCXAQcWxKTmBa@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=3090101217@zju.edu.cn \
    --cc=jleng@ambarella.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.