From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF31641 for ; Tue, 1 Nov 2022 09:59:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE328C433D6; Tue, 1 Nov 2022 09:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667296746; bh=uJPqy7FdyJCQ3j/6bfkJujcNB6cscQ3q4+L1Rs0Y5Jk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=arwNIvA1wsqucYpLvARlwfatzTaLVsPmmj8WXh2ihymvc4jyg736y53jBzaB3hi1o q+5fMgrqZ1NPiiagpJltvuRHZ3Rt1ujoC7sCBms/TJ/ejyi1VrdpjglUAeFIyv/228 nnlxDzo90LWgL/nl7w+hJkoLOajoY9sG6JvttOszwaBTRNSGWXpdcKAFrqK+aC5Z15 4l/v3Te8c+Mgs0YhLRgfFh6kEkHc5UXH7qZYwLvg8dsRuo2bLI2406Hr6ttAxSSJBz 1gDSbBQhs4cpEszkGPSUvWoEPLqB88QHtnKuCMe6uEcWAVVsCMA2oKMXwar5yFPMbv KhhrCH4eaCGMg== Date: Tue, 1 Nov 2022 09:59:00 +0000 From: Lee Jones To: "Russell King (Oracle)" Cc: Hector Martin , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter Subject: Re: [PATCH 4/6] platform/apple: Add new Apple Mac SMC driver Message-ID: References: <82088b05-2a0d-69cc-ba2c-d61c74c9d855@marcan.st> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, 31 Oct 2022, Russell King (Oracle) wrote: > On Mon, Oct 31, 2022 at 05:24:53PM +0000, Lee Jones wrote: > > On Mon, 31 Oct 2022, Russell King (Oracle) wrote: > > > > > On Mon, Oct 31, 2022 at 08:46:25AM +0000, Lee Jones wrote: > > > > On Fri, 28 Oct 2022, Russell King (Oracle) wrote: > > > > > > > > > On Mon, Sep 12, 2022 at 11:55:14AM +0100, Lee Jones wrote: > > > > > > > I'm guessing this series is now dead, and Hector needs to re-spin the > > > > > > > patch set according to your views. I'm guessing this is going to take > > > > > > > a major re-work of the patch series. > > > > > > > > > > > > > > I suspect my attempt and trying to get this upstream has made things > > > > > > > more complicated, because I doubt Hector has updated his patch set > > > > > > > with the review comments that have been made so far... so this is > > > > > > > now quite a mess. I think, once this is sorted, the entire series > > > > > > > will need to be re-reviewed entirely afresh. > > > > > > > > > > > > I have no insight into what Hector is doing, or plans to do. > > > > > > > > > > It seems there's no plans by Hector to address this, so it comes down > > > > > to me. > > > > > > > > > > So, guessing what you're after, would something like the following > > > > > work for you? I don't see *any* point in creating more yet more > > > > > platform devices unless we're on a mission to maximise wasted memory > > > > > resources (which this split will already be doing by creating two > > > > > small modules instead of one.) > > > > > > > > > > Obviously, this is not an official patch yet, it's just to find out > > > > > what code structure you are looking for. > > > > > > > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > > > index 78c6d9d99c3f..8d4c0508a2c8 100644 > > > > > --- a/drivers/mfd/Makefile > > > > > +++ b/drivers/mfd/Makefile > > > > > @@ -18,6 +18,8 @@ obj-$(CONFIG_MFD_ENE_KB3930) += ene-kb3930.o > > > > > obj-$(CONFIG_MFD_EXYNOS_LPASS) += exynos-lpass.o > > > > > obj-$(CONFIG_MFD_GATEWORKS_GSC) += gateworks-gsc.o > > > > > > > > > > +obj-$(CONFIG_APPLE_SMC) += apple-smc.o > > > > > + > > > > > obj-$(CONFIG_HTC_PASIC3) += htc-pasic3.o > > > > > obj-$(CONFIG_HTC_I2CPLD) += htc-i2cpld.o > > > > > > > > > > diff --git a/drivers/mfd/apple-smc.c b/drivers/mfd/apple-smc.c > > > > > new file mode 100644 > > > > > index 000000000000..bc59d1c5e13d > > > > > --- /dev/null > > > > > +++ b/drivers/mfd/apple-smc.c > > > > > @@ -0,0 +1,38 @@ > > > > > +#include > > > > > +#include > > > > > + > > > > > +static const struct mfd_cell apple_smc_devs[] = { > > > > > + { > > > > > + .name = "macsmc-gpio", > > > > > + .of_compatible = "apple,smc-gpio", > > > > > + }, > > > > > + { > > > > > + .name = "macsmc-hid", > > > > > + }, > > > > > + { > > > > > + .name = "macsmc-power", > > > > > + }, > > > > > + { > > > > > + .name = "macsmc-reboot", > > > > > + }, > > > > > + { > > > > > + .name = "macsmc-rtc", > > > > > + }, > > > > > +}; > > > > > + > > > > > +int apple_smc_mfd_probe(struct device *dev) > > > > > +{ > > > > > + return mfd_add_devices(dev, -1, apple_smc_devs, > > > > > + ARRAY_SIZE(apple_smc_devs), NULL, 0, NULL); > > > > > +} > > > > > +EXPORT_SYMBOL(apple_smc_mfd_probe); > > > > > + > > > > > +void apple_smc_mfd_remove(struct device *dev) > > > > > +{ > > > > > + mfd_remove_devices(dev); > > > > > +} > > > > > +EXPORT_SYMBOL(apple_smc_mfd_remove); > > > > > + > > > > > +MODULE_AUTHOR("Hector Martin "); > > > > > +MODULE_LICENSE("Dual MIT/GPL"); > > > > > +MODULE_DESCRIPTION("Apple SMC MFD core"); > > > > > > > > Conceptually interesting, not seen this one before, but clearly a > > > > hack, no? Pretty sure all of the other cores in MFD are represented > > > > by a Platform Device. > > > > > > No one seems to understand what you actually want to see with the > > > smc-core.c part, so I'm trying to find out what code structure > > > would suit you. > > > > > > It seemed from the thread that moving smc-core.c to drivers/mfd > > > wasn't desirable, but there was the desire to move the mfd bits > > > into there - so that's what I've done with this patch. It doesn't > > > make any sense what so ever to add yet another platform device > > > into this structure with all of the complication around what happens > > > if the user forces it to unbind, so I didn't. > > > > > > > Why not implement the inverse? > > > > > > What do you mean "the inverse" ? The inverse of this patch is moving > > > everything of smc-core.c except the MFD bits into drivers/mfd leaving > > > the MFD bits in drivers/platform/apple, which makes no sense. > > > > > > > The Apple SMC is clearly an MFD, in > > > > Linux terms, so why not move the Platform Device into here, fetch all > > > > of the global resources, register the sub-devices, then call into the > > > > rtkit implementation in drivers/platform? > > > > > > I thought you had previously ruled out the idea of moving the contents > > > of drivers/platform/apple into drivers/mfd, but maybe your position on > > > that had changed through the course of the discussion. It's really not > > > obvious to me what you want from what's been said in this thread. > > > > > > So, I ask the direct question - would moving the code that is in this > > > patch set from drivers/platform/apple to drivers/mfd then make it > > > acceptable to you? In other words: > > > > > > drivers/platform/apple/smc_core.c > > > drivers/platform/apple/smc.h > > > drivers/platform/apple/smc_rtkit.c > > > > > > If not, then please clearly and fully state what you want to see. > > > > Sorry Russell, I'm out of time today. Please see my recent reply to > > Hector for now and I'll get back to you first thing. > > Hi Lee, > > Thanks - I look forward to it. Having read your response to Hector, I > am wondering whether there's a misunderstanding of the code, so I'm > hoping that my attempt in my reply helps to clear up any code > misunderstandings. > > If you want to ask questions about the code, you know where to find > me on irc, and I'll more than happily answer anything you want to > know about the code structure. That might be helpful, thanks. Let's keep in on-list for now, in case others are following along. For now, I'll go take a look at your other response. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB8DAFA373D for ; Tue, 1 Nov 2022 10:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dPR63PJgqjapY2E+7ThG81cjxPXGUOqga5snSTNQT5w=; b=OcoSLeTIpLNS65 0yYjgoJKx+1hHKj2Uy0wjz1D1635j6xmUWJTPX7s8PFSUoyhzXjnarX3PGrjKb2Wo7ngIaDnJljss nml6aPDnW6Bl2fO+snpAin/vANlYtCbOP9DZ6IPRHa5Bg4e9ByS5U8K1xUQWPfvla7gAP6jhVBXBQ vpo2j8/t/6ZyIgMhtqMao4vZJqmWuyRdhVbhtkyHLkixjXkYdsKoLzFDCquTD340KSOEOc3fDqfVs tKBvo9TEBeDf+Kp3PrcvwW0ojn/KPpVcPyfu3CcKNGIk0enuKbIBPRdcBklSoT4FYLJSr+Lu7PAQI KK3cj4zUi/sEUPu7OC1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opo36-003rDa-61; Tue, 01 Nov 2022 09:59:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opo32-003rAK-2c for linux-arm-kernel@lists.infradead.org; Tue, 01 Nov 2022 09:59:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 012EF61578; Tue, 1 Nov 2022 09:59:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE328C433D6; Tue, 1 Nov 2022 09:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667296746; bh=uJPqy7FdyJCQ3j/6bfkJujcNB6cscQ3q4+L1Rs0Y5Jk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=arwNIvA1wsqucYpLvARlwfatzTaLVsPmmj8WXh2ihymvc4jyg736y53jBzaB3hi1o q+5fMgrqZ1NPiiagpJltvuRHZ3Rt1ujoC7sCBms/TJ/ejyi1VrdpjglUAeFIyv/228 nnlxDzo90LWgL/nl7w+hJkoLOajoY9sG6JvttOszwaBTRNSGWXpdcKAFrqK+aC5Z15 4l/v3Te8c+Mgs0YhLRgfFh6kEkHc5UXH7qZYwLvg8dsRuo2bLI2406Hr6ttAxSSJBz 1gDSbBQhs4cpEszkGPSUvWoEPLqB88QHtnKuCMe6uEcWAVVsCMA2oKMXwar5yFPMbv KhhrCH4eaCGMg== Date: Tue, 1 Nov 2022 09:59:00 +0000 From: Lee Jones To: "Russell King (Oracle)" Cc: Hector Martin , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter Subject: Re: [PATCH 4/6] platform/apple: Add new Apple Mac SMC driver Message-ID: References: <82088b05-2a0d-69cc-ba2c-d61c74c9d855@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221101_025908_220689_B250F27F X-CRM114-Status: GOOD ( 61.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAzMSBPY3QgMjAyMiwgUnVzc2VsbCBLaW5nIChPcmFjbGUpIHdyb3RlOgoKPiBPbiBN b24sIE9jdCAzMSwgMjAyMiBhdCAwNToyNDo1M1BNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4g PiBPbiBNb24sIDMxIE9jdCAyMDIyLCBSdXNzZWxsIEtpbmcgKE9yYWNsZSkgd3JvdGU6Cj4gPiAK PiA+ID4gT24gTW9uLCBPY3QgMzEsIDIwMjIgYXQgMDg6NDY6MjVBTSArMDAwMCwgTGVlIEpvbmVz IHdyb3RlOgo+ID4gPiA+IE9uIEZyaSwgMjggT2N0IDIwMjIsIFJ1c3NlbGwgS2luZyAoT3JhY2xl KSB3cm90ZToKPiA+ID4gPiAKPiA+ID4gPiA+IE9uIE1vbiwgU2VwIDEyLCAyMDIyIGF0IDExOjU1 OjE0QU0gKzAxMDAsIExlZSBKb25lcyB3cm90ZToKPiA+ID4gPiA+ID4gPiBJJ20gZ3Vlc3Npbmcg dGhpcyBzZXJpZXMgaXMgbm93IGRlYWQsIGFuZCBIZWN0b3IgbmVlZHMgdG8gcmUtc3BpbiB0aGUK PiA+ID4gPiA+ID4gPiBwYXRjaCBzZXQgYWNjb3JkaW5nIHRvIHlvdXIgdmlld3MuIEknbSBndWVz c2luZyB0aGlzIGlzIGdvaW5nIHRvIHRha2UKPiA+ID4gPiA+ID4gPiBhIG1ham9yIHJlLXdvcmsg b2YgdGhlIHBhdGNoIHNlcmllcy4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBJIHN1c3Bl Y3QgbXkgYXR0ZW1wdCBhbmQgdHJ5aW5nIHRvIGdldCB0aGlzIHVwc3RyZWFtIGhhcyBtYWRlIHRo aW5ncwo+ID4gPiA+ID4gPiA+IG1vcmUgY29tcGxpY2F0ZWQsIGJlY2F1c2UgSSBkb3VidCBIZWN0 b3IgaGFzIHVwZGF0ZWQgaGlzIHBhdGNoIHNldAo+ID4gPiA+ID4gPiA+IHdpdGggdGhlIHJldmll dyBjb21tZW50cyB0aGF0IGhhdmUgYmVlbiBtYWRlIHNvIGZhci4uLiBzbyB0aGlzIGlzCj4gPiA+ ID4gPiA+ID4gbm93IHF1aXRlIGEgbWVzcy4gSSB0aGluaywgb25jZSB0aGlzIGlzIHNvcnRlZCwg dGhlIGVudGlyZSBzZXJpZXMKPiA+ID4gPiA+ID4gPiB3aWxsIG5lZWQgdG8gYmUgcmUtcmV2aWV3 ZWQgZW50aXJlbHkgYWZyZXNoLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gSSBoYXZlIG5vIGlu c2lnaHQgaW50byB3aGF0IEhlY3RvciBpcyBkb2luZywgb3IgcGxhbnMgdG8gZG8uCj4gPiA+ID4g PiAKPiA+ID4gPiA+IEl0IHNlZW1zIHRoZXJlJ3Mgbm8gcGxhbnMgYnkgSGVjdG9yIHRvIGFkZHJl c3MgdGhpcywgc28gaXQgY29tZXMgZG93bgo+ID4gPiA+ID4gdG8gbWUuCj4gPiA+ID4gPiAKPiA+ ID4gPiA+IFNvLCBndWVzc2luZyB3aGF0IHlvdSdyZSBhZnRlciwgd291bGQgc29tZXRoaW5nIGxp a2UgdGhlIGZvbGxvd2luZwo+ID4gPiA+ID4gd29yayBmb3IgeW91PyBJIGRvbid0IHNlZSAqYW55 KiBwb2ludCBpbiBjcmVhdGluZyBtb3JlIHlldCBtb3JlCj4gPiA+ID4gPiBwbGF0Zm9ybSBkZXZp Y2VzIHVubGVzcyB3ZSdyZSBvbiBhIG1pc3Npb24gdG8gbWF4aW1pc2Ugd2FzdGVkIG1lbW9yeQo+ ID4gPiA+ID4gcmVzb3VyY2VzICh3aGljaCB0aGlzIHNwbGl0IHdpbGwgYWxyZWFkeSBiZSBkb2lu ZyBieSBjcmVhdGluZyB0d28KPiA+ID4gPiA+IHNtYWxsIG1vZHVsZXMgaW5zdGVhZCBvZiBvbmUu KQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBPYnZpb3VzbHksIHRoaXMgaXMgbm90IGFuIG9mZmljaWFs IHBhdGNoIHlldCwgaXQncyBqdXN0IHRvIGZpbmQgb3V0Cj4gPiA+ID4gPiB3aGF0IGNvZGUgc3Ry dWN0dXJlIHlvdSBhcmUgbG9va2luZyBmb3IuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL21mZC9NYWtlZmlsZSBiL2RyaXZlcnMvbWZkL01ha2VmaWxlCj4gPiA+ID4g PiBpbmRleCA3OGM2ZDlkOTljM2YuLjhkNGMwNTA4YTJjOCAxMDA2NDQKPiA+ID4gPiA+IC0tLSBh L2RyaXZlcnMvbWZkL01ha2VmaWxlCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL21mZC9NYWtlZmls ZQo+ID4gPiA+ID4gQEAgLTE4LDYgKzE4LDggQEAgb2JqLSQoQ09ORklHX01GRF9FTkVfS0IzOTMw KQkrPSBlbmUta2IzOTMwLm8KPiA+ID4gPiA+ICBvYmotJChDT05GSUdfTUZEX0VYWU5PU19MUEFT UykJKz0gZXh5bm9zLWxwYXNzLm8KPiA+ID4gPiA+ICBvYmotJChDT05GSUdfTUZEX0dBVEVXT1JL U19HU0MpCSs9IGdhdGV3b3Jrcy1nc2Mubwo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gK29iai0kKENP TkZJR19BUFBMRV9TTUMpCQkrPSBhcHBsZS1zbWMubwo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gIG9i ai0kKENPTkZJR19IVENfUEFTSUMzKQkrPSBodGMtcGFzaWMzLm8KPiA+ID4gPiA+ICBvYmotJChD T05GSUdfSFRDX0kyQ1BMRCkJKz0gaHRjLWkyY3BsZC5vCj4gPiA+ID4gPiAgCj4gPiA+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvYXBwbGUtc21jLmMgYi9kcml2ZXJzL21mZC9hcHBsZS1z bWMuYwo+ID4gPiA+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ID4gPiA+IGluZGV4IDAwMDAw MDAwMDAwMC4uYmM1OWQxYzVlMTNkCj4gPiA+ID4gPiAtLS0gL2Rldi9udWxsCj4gPiA+ID4gPiAr KysgYi9kcml2ZXJzL21mZC9hcHBsZS1zbWMuYwo+ID4gPiA+ID4gQEAgLTAsMCArMSwzOCBAQAo+ ID4gPiA+ID4gKyNpbmNsdWRlIDxsaW51eC9tZmQvY29yZS5oPgo+ID4gPiA+ID4gKyNpbmNsdWRl IDxsaW51eC9tZmQvYXBwbGUtc21jLmg+Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArc3RhdGljIGNv bnN0IHN0cnVjdCBtZmRfY2VsbCBhcHBsZV9zbWNfZGV2c1tdID0gewo+ID4gPiA+ID4gKwl7Cj4g PiA+ID4gPiArCQkubmFtZSA9ICJtYWNzbWMtZ3BpbyIsCj4gPiA+ID4gPiArCQkub2ZfY29tcGF0 aWJsZSA9ICJhcHBsZSxzbWMtZ3BpbyIsCj4gPiA+ID4gPiArCX0sCj4gPiA+ID4gPiArCXsKPiA+ ID4gPiA+ICsJCS5uYW1lID0gIm1hY3NtYy1oaWQiLAo+ID4gPiA+ID4gKwl9LAo+ID4gPiA+ID4g Kwl7Cj4gPiA+ID4gPiArCQkubmFtZSA9ICJtYWNzbWMtcG93ZXIiLAo+ID4gPiA+ID4gKwl9LAo+ ID4gPiA+ID4gKwl7Cj4gPiA+ID4gPiArCQkubmFtZSA9ICJtYWNzbWMtcmVib290IiwKPiA+ID4g PiA+ICsJfSwKPiA+ID4gPiA+ICsJewo+ID4gPiA+ID4gKwkJLm5hbWUgPSAibWFjc21jLXJ0YyIs Cj4gPiA+ID4gPiArCX0sCj4gPiA+ID4gPiArfTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICtpbnQg YXBwbGVfc21jX21mZF9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiA+ID4gPiArewo+ID4g PiA+ID4gKwlyZXR1cm4gbWZkX2FkZF9kZXZpY2VzKGRldiwgLTEsIGFwcGxlX3NtY19kZXZzLAo+ ID4gPiA+ID4gKwkJCSAgICAgICBBUlJBWV9TSVpFKGFwcGxlX3NtY19kZXZzKSwgTlVMTCwgMCwg TlVMTCk7Cj4gPiA+ID4gPiArfQo+ID4gPiA+ID4gK0VYUE9SVF9TWU1CT0woYXBwbGVfc21jX21m ZF9wcm9iZSk7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArdm9pZCBhcHBsZV9zbWNfbWZkX3JlbW92 ZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiA+ID4gPiArewo+ID4gPiA+ID4gKwltZmRfcmVtb3Zl X2RldmljZXMoZGV2KTsKPiA+ID4gPiA+ICt9Cj4gPiA+ID4gPiArRVhQT1JUX1NZTUJPTChhcHBs ZV9zbWNfbWZkX3JlbW92ZSk7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArTU9EVUxFX0FVVEhPUigi SGVjdG9yIE1hcnRpbiA8bWFyY2FuQG1hcmNhbi5zdD4iKTsKPiA+ID4gPiA+ICtNT0RVTEVfTElD RU5TRSgiRHVhbCBNSVQvR1BMIik7Cj4gPiA+ID4gPiArTU9EVUxFX0RFU0NSSVBUSU9OKCJBcHBs ZSBTTUMgTUZEIGNvcmUiKTsKPiA+ID4gPiAKPiA+ID4gPiBDb25jZXB0dWFsbHkgaW50ZXJlc3Rp bmcsIG5vdCBzZWVuIHRoaXMgb25lIGJlZm9yZSwgYnV0IGNsZWFybHkgYQo+ID4gPiA+IGhhY2ss IG5vPyAgUHJldHR5IHN1cmUgYWxsIG9mIHRoZSBvdGhlciBjb3JlcyBpbiBNRkQgYXJlIHJlcHJl c2VudGVkCj4gPiA+ID4gYnkgYSBQbGF0Zm9ybSBEZXZpY2UuCj4gPiA+IAo+ID4gPiBObyBvbmUg c2VlbXMgdG8gdW5kZXJzdGFuZCB3aGF0IHlvdSBhY3R1YWxseSB3YW50IHRvIHNlZSB3aXRoIHRo ZQo+ID4gPiBzbWMtY29yZS5jIHBhcnQsIHNvIEknbSB0cnlpbmcgdG8gZmluZCBvdXQgd2hhdCBj b2RlIHN0cnVjdHVyZQo+ID4gPiB3b3VsZCBzdWl0IHlvdS4KPiA+ID4gCj4gPiA+IEl0IHNlZW1l ZCBmcm9tIHRoZSB0aHJlYWQgdGhhdCBtb3Zpbmcgc21jLWNvcmUuYyB0byBkcml2ZXJzL21mZAo+ ID4gPiB3YXNuJ3QgZGVzaXJhYmxlLCBidXQgdGhlcmUgd2FzIHRoZSBkZXNpcmUgdG8gbW92ZSB0 aGUgbWZkIGJpdHMKPiA+ID4gaW50byB0aGVyZSAtIHNvIHRoYXQncyB3aGF0IEkndmUgZG9uZSB3 aXRoIHRoaXMgcGF0Y2guIEl0IGRvZXNuJ3QKPiA+ID4gbWFrZSBhbnkgc2Vuc2Ugd2hhdCBzbyBl dmVyIHRvIGFkZCB5ZXQgYW5vdGhlciBwbGF0Zm9ybSBkZXZpY2UKPiA+ID4gaW50byB0aGlzIHN0 cnVjdHVyZSB3aXRoIGFsbCBvZiB0aGUgY29tcGxpY2F0aW9uIGFyb3VuZCB3aGF0IGhhcHBlbnMK PiA+ID4gaWYgdGhlIHVzZXIgZm9yY2VzIGl0IHRvIHVuYmluZCwgc28gSSBkaWRuJ3QuCj4gPiA+ IAo+ID4gPiA+IFdoeSBub3QgaW1wbGVtZW50IHRoZSBpbnZlcnNlPwo+ID4gPiAKPiA+ID4gV2hh dCBkbyB5b3UgbWVhbiAidGhlIGludmVyc2UiID8gVGhlIGludmVyc2Ugb2YgdGhpcyBwYXRjaCBp cyBtb3ZpbmcKPiA+ID4gZXZlcnl0aGluZyBvZiBzbWMtY29yZS5jIGV4Y2VwdCB0aGUgTUZEIGJp dHMgaW50byBkcml2ZXJzL21mZCBsZWF2aW5nCj4gPiA+IHRoZSBNRkQgYml0cyBpbiBkcml2ZXJz L3BsYXRmb3JtL2FwcGxlLCB3aGljaCBtYWtlcyBubyBzZW5zZS4KPiA+ID4gCj4gPiA+ID4gVGhl IEFwcGxlIFNNQyBpcyBjbGVhcmx5IGFuIE1GRCwgaW4KPiA+ID4gPiBMaW51eCB0ZXJtcywgc28g d2h5IG5vdCBtb3ZlIHRoZSBQbGF0Zm9ybSBEZXZpY2UgaW50byBoZXJlLCBmZXRjaCBhbGwKPiA+ ID4gPiBvZiB0aGUgZ2xvYmFsIHJlc291cmNlcywgcmVnaXN0ZXIgdGhlIHN1Yi1kZXZpY2VzLCB0 aGVuIGNhbGwgaW50byB0aGUKPiA+ID4gPiBydGtpdCBpbXBsZW1lbnRhdGlvbiBpbiBkcml2ZXJz L3BsYXRmb3JtPyAKPiA+ID4gCj4gPiA+IEkgdGhvdWdodCB5b3UgaGFkIHByZXZpb3VzbHkgcnVs ZWQgb3V0IHRoZSBpZGVhIG9mIG1vdmluZyB0aGUgY29udGVudHMKPiA+ID4gb2YgZHJpdmVycy9w bGF0Zm9ybS9hcHBsZSBpbnRvIGRyaXZlcnMvbWZkLCBidXQgbWF5YmUgeW91ciBwb3NpdGlvbiBv bgo+ID4gPiB0aGF0IGhhZCBjaGFuZ2VkIHRocm91Z2ggdGhlIGNvdXJzZSBvZiB0aGUgZGlzY3Vz c2lvbi4gSXQncyByZWFsbHkgbm90Cj4gPiA+IG9idmlvdXMgdG8gbWUgd2hhdCB5b3Ugd2FudCBm cm9tIHdoYXQncyBiZWVuIHNhaWQgaW4gdGhpcyB0aHJlYWQuCj4gPiA+IAo+ID4gPiBTbywgSSBh c2sgdGhlIGRpcmVjdCBxdWVzdGlvbiAtIHdvdWxkIG1vdmluZyB0aGUgY29kZSB0aGF0IGlzIGlu IHRoaXMKPiA+ID4gcGF0Y2ggc2V0IGZyb20gZHJpdmVycy9wbGF0Zm9ybS9hcHBsZSB0byBkcml2 ZXJzL21mZCB0aGVuIG1ha2UgaXQKPiA+ID4gYWNjZXB0YWJsZSB0byB5b3U/IEluIG90aGVyIHdv cmRzOgo+ID4gPiAKPiA+ID4gIGRyaXZlcnMvcGxhdGZvcm0vYXBwbGUvc21jX2NvcmUuYwo+ID4g PiAgZHJpdmVycy9wbGF0Zm9ybS9hcHBsZS9zbWMuaAo+ID4gPiAgZHJpdmVycy9wbGF0Zm9ybS9h cHBsZS9zbWNfcnRraXQuYwo+ID4gPiAKPiA+ID4gSWYgbm90LCB0aGVuIHBsZWFzZSBjbGVhcmx5 IGFuZCBmdWxseSBzdGF0ZSB3aGF0IHlvdSB3YW50IHRvIHNlZS4KPiA+IAo+ID4gU29ycnkgUnVz c2VsbCwgSSdtIG91dCBvZiB0aW1lIHRvZGF5LiAgUGxlYXNlIHNlZSBteSByZWNlbnQgcmVwbHkg dG8KPiA+IEhlY3RvciBmb3Igbm93IGFuZCBJJ2xsIGdldCBiYWNrIHRvIHlvdSBmaXJzdCB0aGlu Zy4KPiAKPiBIaSBMZWUsCj4gCj4gVGhhbmtzIC0gSSBsb29rIGZvcndhcmQgdG8gaXQuIEhhdmlu ZyByZWFkIHlvdXIgcmVzcG9uc2UgdG8gSGVjdG9yLCBJCj4gYW0gd29uZGVyaW5nIHdoZXRoZXIg dGhlcmUncyBhIG1pc3VuZGVyc3RhbmRpbmcgb2YgdGhlIGNvZGUsIHNvIEknbQo+IGhvcGluZyB0 aGF0IG15IGF0dGVtcHQgaW4gbXkgcmVwbHkgaGVscHMgdG8gY2xlYXIgdXAgYW55IGNvZGUKPiBt aXN1bmRlcnN0YW5kaW5ncy4KPiAKPiBJZiB5b3Ugd2FudCB0byBhc2sgcXVlc3Rpb25zIGFib3V0 IHRoZSBjb2RlLCB5b3Uga25vdyB3aGVyZSB0byBmaW5kCj4gbWUgb24gaXJjLCBhbmQgSSdsbCBt b3JlIHRoYW4gaGFwcGlseSBhbnN3ZXIgYW55dGhpbmcgeW91IHdhbnQgdG8KPiBrbm93IGFib3V0 IHRoZSBjb2RlIHN0cnVjdHVyZS4KClRoYXQgbWlnaHQgYmUgaGVscGZ1bCwgdGhhbmtzLgoKTGV0 J3Mga2VlcCBpbiBvbi1saXN0IGZvciBub3csIGluIGNhc2Ugb3RoZXJzIGFyZSBmb2xsb3dpbmcg YWxvbmcuCgpGb3Igbm93LCBJJ2xsIGdvIHRha2UgYSBsb29rIGF0IHlvdXIgb3RoZXIgcmVzcG9u c2UuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==