All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Accardi,
	Kristen C"
	<kristen.c.accardi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org"
	<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	"lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org"
	<lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: clarification about misc controller and capacity vs. max
Date: Tue, 1 Nov 2022 06:54:34 -1000	[thread overview]
Message-ID: <Y2FPSqOaQGnISvXu@slm.duckdns.org> (raw)
In-Reply-To: <2f7b7d6b10bdcbc9a73ea449d3636575124afa25.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Hello,

On Tue, Nov 01, 2022 at 04:40:22PM +0000, Accardi, Kristen C wrote:
> I notice in the comments for the misc controller it is stated that the
> max limit can be more than actual total capacity, meaning that we can
> overcommit with the resource controlled by the misc controller.
> However, in the misc_cg_try_charge() code, the function will return -
> EBUSY if max limit will be crossed or total usage will be more than the
> capacity, which would seem to enforce total capacity as an upper limit
> in addition to max and not allow for overcommit. Can you provide some
> clarity on whether the resource consumption model for the misc
> controller should allow for overcommit?

I think what it's trying to say is that the sum of first level .max's can be
higher than the total capacity. e.g. Let's say you have 5 of this resource
and a hierarchy like the following.

        R - A - A'
          + B - B'
          \ C

It's valid to have A, B, C's max set to 4, 3, 2 respectively even if they
sum up to 9 which is larger than what's available in the system, 5 - ie. the
max limits are overcommitted for the resource.

Thanks.

-- 
tejun

  parent reply	other threads:[~2022-11-01 16:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01 16:40 clarification about misc controller and capacity vs. max Accardi, Kristen C
     [not found] ` <2f7b7d6b10bdcbc9a73ea449d3636575124afa25.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-11-01 16:54   ` tj-DgEjT+Ai2ygdnm+yROfE0A [this message]
     [not found]     ` <Y2FPSqOaQGnISvXu-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-11-01 17:03       ` Accardi, Kristen C
     [not found]         ` <14c21f13ebbcdbd0ea4f75b7fff790b31a05a5aa.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-11-01 17:05           ` tj-DgEjT+Ai2ygdnm+yROfE0A
     [not found]             ` <Y2FR6SYazbxyK5nj-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-11-01 17:11               ` Accardi, Kristen C
     [not found]                 ` <f678f325b47ac64e101c0ccea54c1cd1c4ea4206.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-11-01 17:35                   ` tj-DgEjT+Ai2ygdnm+yROfE0A
2022-11-02 18:19           ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2FPSqOaQGnISvXu@slm.duckdns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kristen.c.accardi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.