From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE351C433FE for ; Tue, 1 Nov 2022 17:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4xEmuPc9a+N5qUkePKCCJI4e9oSVfWJcgYwD0fMmMQc=; b=qSnqWPTLstZ5S2 BkLFGRQlEk59jw+aEpaEiH1SuV57d6xwcgJhBk3obHKLpRi0NLZ9QPIi65R70LcGU+6vpVSB0DcB4 3x+iL9zyb4MkDJyNUAA0D0RzS2juWKlQjGe8apmxL4qXZg145223qDwwcC8TRBf1uNfBrbZFqmYcA iGbUUs7V4GHQ6o8I/jBhuVTq63bOKOjvyjaYmbWGNPlgkUpPQQyV9pNJa+dSInKqBjSgoDUuHrF7Y NB+zv1+XBtbIHFXRDnvyiqznAvdnXQqOCLWN4yUgyoCR5XFU3/g2AcWxS00jxJiZHB1rnxPbp2uwD TF/UlUqV0adoDHiPuFIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opukB-00693S-6s; Tue, 01 Nov 2022 17:08:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opuk8-00692t-7Z for linux-riscv@lists.infradead.org; Tue, 01 Nov 2022 17:08:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D3AD61689; Tue, 1 Nov 2022 17:08:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54410C433D6; Tue, 1 Nov 2022 17:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667322481; bh=2Y4FXSKTEjF1qcYmzzsY+q+7a2NVRoQEVXrR1FcCVUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tA0ddphq6ZwqaV0xWZCkp4pEcY+OkbDE5oOQ20B1NJIg0FozRlhFhoyURR1kcsuxF UEDIX59usJVYSRW10N+LTLu7FEP2dnpLIdBBv6r/wUpIxp3eThbdqrsCGZk5e0JxTV KDhO5w3b2LhVhBaVCyPfwc+N1LpT6Z8T4Xui5tvJAllXrfXW0YdW9lpVfHZ0xCnh14 u2JKSYVFyoMnXyPGWJxU9VqYUaUkqfBsnedrUtAYXZAr5LwqM5VsS/yOUNw0h7pM5g 5Ce//sdIikux7UK1eMgr1xDJhxg0I0iG5isX4uFKJMFNBX63Gp5erpr+Gc9umYqxo2 pq1za7wo5ObLA== Date: Tue, 1 Nov 2022 17:07:56 +0000 From: Conor Dooley To: binglei wang Cc: aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, linux-kernel@vger.kernel.org, mhiramat@kernel.org, naveen.n.rao@linux.ibm.com, Conor Dooley Subject: Re: [PATCH RESEND v9] riscv: add riscv rethook implementation Message-ID: References: <20221025151831.1097417-1-conor@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221101_100804_374878_C0531B7C X-CRM114-Status: GOOD ( 31.59 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMDEsIDIwMjIgYXQgMDk6NDA6MjNQTSArMDgwMCwgYmluZ2xlaSB3YW5nIHdy b3RlOgo+IEhpIENvbm9yLAo+IAo+IFRoYW5rcyBmb3IgeW91ciByZXNlbmRpbmcuCj4gV2hhdCB0 byBkbyBuZXh0IGlzIGp1c3QgdG8gd2FpdCBwYXRlbnRseSwgcmlnaHQgPwoKWXVwLi4gWW91J2xs IGdldCBhdCBsZWFzdCBvbmUgZW1haWwgd2hlbiBpdCBnZXRzIGFwcGxpZWQuCkl0J3MgaW4gcGF0 Y2h3b3JrIFswXSBzbyBpdCBzaG91bGQgbm90IGdldCBmb3Jnb3R0ZW4gYWJvdXQuCgowIC0gaHR0 cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LXJpc2N2L3BhdGNoLzIwMjIx MDI1MTUxODMxLjEwOTc0MTctMS1jb25vckBrZXJuZWwub3JnLwoKPiAKPiBCaW5nbGVpIFdhbmcK PiBCZXN0IHdpc2hlcy4KPiAKPiAKPiBDb25vciBEb29sZXkgPGNvbm9yQGtlcm5lbC5vcmc+IOS6 jjIwMjLlubQxMOaciDI15pel5ZGo5LqMIDIzOjE55YaZ6YGT77yaCj4gPgo+ID4gRnJvbTogQmlu Z2xlaSBXYW5nIDxsM2IydzFAZ21haWwuY29tPgo+ID4KPiA+IEltcGxlbWVudCB0aGUga3JldHBy b2JlcyBvbiByaXNjdiBhcmNoIGJ5IHVzaW5nIHJldGhvb2sgbWFjaGVuaXNtCj4gPiB3aGljaCBh YnN0cmFjdHMgZ2VuZXJhbCBrcmV0cHJvYmUgaW5mbyBpbnRvIGEgc3RydWN0IHJldGhvb2tfbm9k ZQo+ID4gdG8gYmUgZW1iZWRkZWQgaW4gdGhlIHN0cnVjdCBrcmV0cHJvYmVfaW5zdGFuY2UuCj4g Pgo+ID4gQWNrZWQtYnk6IE1hc2FtaSBIaXJhbWF0c3UgKEdvb2dsZSkgPG1oaXJhbWF0QGtlcm5l bC5vcmc+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBCaW5nbGVpIFdhbmcgPGwzYjJ3MUBnbWFpbC5jb20+ Cj4gPiBTaWduZWQtb2ZmLWJ5OiBDb25vciBEb29sZXkgPGNvbm9yLmRvb2xleUBtaWNyb2NoaXAu Y29tPgo+ID4gLS0tCj4gPiBCaW5nbGVpJ3MgcGF0Y2hlcyBkbyBub3Qgc2VlbSB0byBtYWtlIGl0 IHRvIHRoZSBsaW51eC1yaXNjdiBsaXN0LCBzbwo+ID4gYmxpbmRseSByZXNlbmRpbmcgb24gdGhl aXIgYmVoYWxmLCB3aXRoIE1hc2FtaSdzIGFjayBmcm9tIHY4IGFkZGVkLgo+ID4KPiA+ICBhcmNo L3Jpc2N2L0tjb25maWcgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMSArCj4gPiAgYXJj aC9yaXNjdi9pbmNsdWRlL2FzbS9rcHJvYmVzLmggICAgICAgICAgICAgIHwgIDIgLS0KPiA+ICBh cmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvTWFrZWZpbGUgICAgICAgICAgICAgfCAgMiArLQo+ID4g IGFyY2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9rcHJvYmVzLmMgICAgICAgICAgICB8IDEzIC0tLS0t LS0tLQo+ID4gIGFyY2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9yZXRob29rLmMgICAgICAgICAgICB8 IDI3ICsrKysrKysrKysrKysrKysrKysKPiA+ICBhcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0 aG9vay5oICAgICAgICAgICAgfCAgOCArKysrKysKPiA+ICAuLi5vYmVzX3RyYW1wb2xpbmUuUyA9 PiByZXRob29rX3RyYW1wb2xpbmUuU30gfCAgNiArKy0tLQo+ID4gIDcgZmlsZXMgY2hhbmdlZCwg NDAgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGFyY2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9yZXRob29rLmMKPiA+ICBjcmVhdGUgbW9kZSAxMDA2 NDQgYXJjaC9yaXNjdi9rZXJuZWwvcHJvYmVzL3JldGhvb2suaAo+ID4gIHJlbmFtZSBhcmNoL3Jp c2N2L2tlcm5lbC9wcm9iZXMve2twcm9iZXNfdHJhbXBvbGluZS5TID0+IHJldGhvb2tfdHJhbXBv bGluZS5TfSAoOTQlKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L0tjb25maWcgYi9h cmNoL3Jpc2N2L0tjb25maWcKPiA+IGluZGV4IDZiNDhhM2FlOTg0My4uNDEzYWVjYTcxY2EwIDEw MDY0NAo+ID4gLS0tIGEvYXJjaC9yaXNjdi9LY29uZmlnCj4gPiArKysgYi9hcmNoL3Jpc2N2L0tj b25maWcKPiA+IEBAIC05OSw2ICs5OSw3IEBAIGNvbmZpZyBSSVNDVgo+ID4gICAgICAgICBzZWxl Y3QgSEFWRV9LUFJPQkVTIGlmICFYSVBfS0VSTkVMCj4gPiAgICAgICAgIHNlbGVjdCBIQVZFX0tQ Uk9CRVNfT05fRlRSQUNFIGlmICFYSVBfS0VSTkVMCj4gPiAgICAgICAgIHNlbGVjdCBIQVZFX0tS RVRQUk9CRVMgaWYgIVhJUF9LRVJORUwKPiA+ICsgICAgICAgc2VsZWN0IEhBVkVfUkVUSE9PSyBp ZiAhWElQX0tFUk5FTAo+ID4gICAgICAgICBzZWxlY3QgSEFWRV9NT1ZFX1BNRAo+ID4gICAgICAg ICBzZWxlY3QgSEFWRV9NT1ZFX1BVRAo+ID4gICAgICAgICBzZWxlY3QgSEFWRV9QQ0kKPiA+IGRp ZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2luY2x1ZGUvYXNtL2twcm9iZXMuaCBiL2FyY2gvcmlzY3Yv aW5jbHVkZS9hc20va3Byb2Jlcy5oCj4gPiBpbmRleCAyMTdlZjg5ZjIyYjkuLmU3ODgyY2NiMGZk NCAxMDA2NDQKPiA+IC0tLSBhL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20va3Byb2Jlcy5oCj4gPiAr KysgYi9hcmNoL3Jpc2N2L2luY2x1ZGUvYXNtL2twcm9iZXMuaAo+ID4gQEAgLTQwLDggKzQwLDYg QEAgdm9pZCBhcmNoX3JlbW92ZV9rcHJvYmUoc3RydWN0IGtwcm9iZSAqcCk7Cj4gPiAgaW50IGtw cm9iZV9mYXVsdF9oYW5kbGVyKHN0cnVjdCBwdF9yZWdzICpyZWdzLCB1bnNpZ25lZCBpbnQgdHJh cG5yKTsKPiA+ICBib29sIGtwcm9iZV9icmVha3BvaW50X2hhbmRsZXIoc3RydWN0IHB0X3JlZ3Mg KnJlZ3MpOwo+ID4gIGJvb2wga3Byb2JlX3NpbmdsZV9zdGVwX2hhbmRsZXIoc3RydWN0IHB0X3Jl Z3MgKnJlZ3MpOwo+ID4gLXZvaWQgX19rcmV0cHJvYmVfdHJhbXBvbGluZSh2b2lkKTsKPiA+IC12 b2lkIF9fa3Byb2JlcyAqdHJhbXBvbGluZV9wcm9iZV9oYW5kbGVyKHN0cnVjdCBwdF9yZWdzICpy ZWdzKTsKPiA+Cj4gPiAgI2VuZGlmIC8qIENPTkZJR19LUFJPQkVTICovCj4gPiAgI2VuZGlmIC8q IF9BU01fUklTQ1ZfS1BST0JFU19IICovCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9yaXNjdi9rZXJu ZWwvcHJvYmVzL01ha2VmaWxlIGIvYXJjaC9yaXNjdi9rZXJuZWwvcHJvYmVzL01ha2VmaWxlCj4g PiBpbmRleCA3ZjA4NDBkY2MzMWIuLmM0MDEzOWU5Y2E0NyAxMDA2NDQKPiA+IC0tLSBhL2FyY2gv cmlzY3Yva2VybmVsL3Byb2Jlcy9NYWtlZmlsZQo+ID4gKysrIGIvYXJjaC9yaXNjdi9rZXJuZWwv cHJvYmVzL01ha2VmaWxlCj4gPiBAQCAtMSw2ICsxLDYgQEAKPiA+ICAjIFNQRFgtTGljZW5zZS1J ZGVudGlmaWVyOiBHUEwtMi4wCj4gPiAgb2JqLSQoQ09ORklHX0tQUk9CRVMpICAgICAgICAgICs9 IGtwcm9iZXMubyBkZWNvZGUtaW5zbi5vIHNpbXVsYXRlLWluc24ubwo+ID4gLW9iai0kKENPTkZJ R19LUFJPQkVTKSAgICAgICAgICArPSBrcHJvYmVzX3RyYW1wb2xpbmUubwo+ID4gK29iai0kKENP TkZJR19SRVRIT09LKSAgICAgICAgICArPSByZXRob29rLm8gcmV0aG9va190cmFtcG9saW5lLm8K PiA+ICBvYmotJChDT05GSUdfS1BST0JFU19PTl9GVFJBQ0UpICAgICAgICArPSBmdHJhY2Uubwo+ ID4gIG9iai0kKENPTkZJR19VUFJPQkVTKSAgICAgICAgICArPSB1cHJvYmVzLm8gZGVjb2RlLWlu c24ubyBzaW11bGF0ZS1pbnNuLm8KPiA+ICBDRkxBR1NfUkVNT1ZFX3NpbXVsYXRlLWluc24ubyA9 ICQoQ0NfRkxBR1NfRlRSQUNFKQo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3Yva2VybmVsL3By b2Jlcy9rcHJvYmVzLmMgYi9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMva3Byb2Jlcy5jCj4gPiBp bmRleCBlNmU5NTBiN2NmMzIuLmYyMTU5MmQyMDMwNiAxMDA2NDQKPiA+IC0tLSBhL2FyY2gvcmlz Y3Yva2VybmVsL3Byb2Jlcy9rcHJvYmVzLmMKPiA+ICsrKyBiL2FyY2gvcmlzY3Yva2VybmVsL3By b2Jlcy9rcHJvYmVzLmMKPiA+IEBAIC0zNDUsMTkgKzM0NSw2IEBAIGludCBfX2luaXQgYXJjaF9w b3B1bGF0ZV9rcHJvYmVfYmxhY2tsaXN0KHZvaWQpCj4gPiAgICAgICAgIHJldHVybiByZXQ7Cj4g PiAgfQo+ID4KPiA+IC12b2lkIF9fa3Byb2JlcyBfX3VzZWQgKnRyYW1wb2xpbmVfcHJvYmVfaGFu ZGxlcihzdHJ1Y3QgcHRfcmVncyAqcmVncykKPiA+IC17Cj4gPiAtICAgICAgIHJldHVybiAodm9p ZCAqKWtyZXRwcm9iZV90cmFtcG9saW5lX2hhbmRsZXIocmVncywgTlVMTCk7Cj4gPiAtfQo+ID4g LQo+ID4gLXZvaWQgX19rcHJvYmVzIGFyY2hfcHJlcGFyZV9rcmV0cHJvYmUoc3RydWN0IGtyZXRw cm9iZV9pbnN0YW5jZSAqcmksCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0cnVjdCBwdF9yZWdzICpyZWdzKQo+ID4gLXsKPiA+IC0gICAgICAgcmktPnJldF9hZGRy ID0gKGtwcm9iZV9vcGNvZGVfdCAqKXJlZ3MtPnJhOwo+ID4gLSAgICAgICByaS0+ZnAgPSBOVUxM Owo+ID4gLSAgICAgICByZWdzLT5yYSA9ICh1bnNpZ25lZCBsb25nKSAmX19rcmV0cHJvYmVfdHJh bXBvbGluZTsKPiA+IC19Cj4gPiAtCj4gPiAgaW50IF9fa3Byb2JlcyBhcmNoX3RyYW1wb2xpbmVf a3Byb2JlKHN0cnVjdCBrcHJvYmUgKnApCj4gPiAgewo+ID4gICAgICAgICByZXR1cm4gMDsKPiA+ IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9vay5jIGIvYXJjaC9y aXNjdi9rZXJuZWwvcHJvYmVzL3JldGhvb2suYwo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ IGluZGV4IDAwMDAwMDAwMDAwMC4uNWMyN2MxZjUwOTg5Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiAr KysgYi9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9vay5jCj4gPiBAQCAtMCwwICsxLDI3 IEBACj4gPiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seQo+ID4gKy8q Cj4gPiArICogR2VuZXJpYyByZXR1cm4gaG9vayBmb3IgcmlzY3YuCj4gPiArICovCj4gPiArCj4g PiArI2luY2x1ZGUgPGxpbnV4L2twcm9iZXMuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvcmV0aG9v ay5oPgo+ID4gKyNpbmNsdWRlICJyZXRob29rLmgiCj4gPiArCj4gPiArLyogVGhpcyBpcyBjYWxs ZWQgZnJvbSBhcmNoX3JldGhvb2tfdHJhbXBvbGluZSgpICovCj4gPiArdW5zaWduZWQgbG9uZyBf X3VzZWQgYXJjaF9yZXRob29rX3RyYW1wb2xpbmVfY2FsbGJhY2soc3RydWN0IHB0X3JlZ3MgKnJl Z3MpCj4gPiArewo+ID4gKyAgICAgICByZXR1cm4gcmV0aG9va190cmFtcG9saW5lX2hhbmRsZXIo cmVncywgcmVncy0+czApOwo+ID4gK30KPiA+ICsKPiA+ICtOT0tQUk9CRV9TWU1CT0woYXJjaF9y ZXRob29rX3RyYW1wb2xpbmVfY2FsbGJhY2spOwo+ID4gKwo+ID4gK3ZvaWQgYXJjaF9yZXRob29r X3ByZXBhcmUoc3RydWN0IHJldGhvb2tfbm9kZSAqcmhuLCBzdHJ1Y3QgcHRfcmVncyAqcmVncywg Ym9vbCBtY291bnQpCj4gPiArewo+ID4gKyAgICAgICByaG4tPnJldF9hZGRyID0gcmVncy0+cmE7 Cj4gPiArICAgICAgIHJobi0+ZnJhbWUgPSByZWdzLT5zMDsKPiA+ICsKPiA+ICsgICAgICAgLyog cmVwbGFjZSByZXR1cm4gYWRkciB3aXRoIHRyYW1wb2xpbmUgKi8KPiA+ICsgICAgICAgcmVncy0+ cmEgPSAodW5zaWduZWQgbG9uZylhcmNoX3JldGhvb2tfdHJhbXBvbGluZTsKPiA+ICt9Cj4gPiAr Cj4gPiArTk9LUFJPQkVfU1lNQk9MKGFyY2hfcmV0aG9va19wcmVwYXJlKTsKPiA+IGRpZmYgLS1n aXQgYS9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9vay5oIGIvYXJjaC9yaXNjdi9rZXJu ZWwvcHJvYmVzL3JldGhvb2suaAo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IDAw MDAwMDAwMDAwMC4uNDc1OGY3ZTNjZTg4Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9hcmNo L3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9vay5oCj4gPiBAQCAtMCwwICsxLDggQEAKPiA+ICsv KiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1vbmx5ICovCj4gPiArI2lmbmRlZiBf X1JJU0NWX1JFVEhPT0tfSAo+ID4gKyNkZWZpbmUgX19SSVNDVl9SRVRIT09LX0gKPiA+ICsKPiA+ ICt1bnNpZ25lZCBsb25nIGFyY2hfcmV0aG9va190cmFtcG9saW5lX2NhbGxiYWNrKHN0cnVjdCBw dF9yZWdzICpyZWdzKTsKPiA+ICt2b2lkIGFyY2hfcmV0aG9va19wcmVwYXJlKHN0cnVjdCByZXRo b29rX25vZGUgKnJobiwgc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIGJvb2wgbWNvdW50KTsKPiA+ICsK PiA+ICsjZW5kaWYKPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMva3By b2Jlc190cmFtcG9saW5lLlMgYi9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9va190cmFt cG9saW5lLlMKPiA+IHNpbWlsYXJpdHkgaW5kZXggOTQlCj4gPiByZW5hbWUgZnJvbSBhcmNoL3Jp c2N2L2tlcm5lbC9wcm9iZXMva3Byb2Jlc190cmFtcG9saW5lLlMKPiA+IHJlbmFtZSB0byBhcmNo L3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9va190cmFtcG9saW5lLlMKPiA+IGluZGV4IDdiZGIw OWRlZDM5Yi4uMjFiYWM5MmExNzBhIDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9yaXNjdi9rZXJuZWwv cHJvYmVzL2twcm9iZXNfdHJhbXBvbGluZS5TCj4gPiArKysgYi9hcmNoL3Jpc2N2L2tlcm5lbC9w cm9iZXMvcmV0aG9va190cmFtcG9saW5lLlMKPiA+IEBAIC03NSwxMyArNzUsMTMgQEAKPiA+ICAg ICAgICAgUkVHX0wgeDMxLCBQVF9UNihzcCkKPiA+ICAgICAgICAgLmVuZG0KPiA+Cj4gPiAtRU5U UlkoX19rcmV0cHJvYmVfdHJhbXBvbGluZSkKPiA+ICtFTlRSWShhcmNoX3JldGhvb2tfdHJhbXBv bGluZSkKPiA+ICAgICAgICAgYWRkaSBzcCwgc3AsIC0oUFRfU0laRV9PTl9TVEFDSykKPiA+ICAg ICAgICAgc2F2ZV9hbGxfYmFzZV9yZWdzCj4gPgo+ID4gICAgICAgICBtb3ZlIGEwLCBzcCAvKiBw dF9yZWdzICovCj4gPgo+ID4gLSAgICAgICBjYWxsIHRyYW1wb2xpbmVfcHJvYmVfaGFuZGxlcgo+ ID4gKyAgICAgICBjYWxsIGFyY2hfcmV0aG9va190cmFtcG9saW5lX2NhbGxiYWNrCj4gPgo+ID4g ICAgICAgICAvKiB1c2UgdGhlIHJlc3VsdCBhcyB0aGUgcmV0dXJuLWFkZHJlc3MgKi8KPiA+ICAg ICAgICAgbW92ZSByYSwgYTAKPiA+IEBAIC05MCw0ICs5MCw0IEBAIEVOVFJZKF9fa3JldHByb2Jl X3RyYW1wb2xpbmUpCj4gPiAgICAgICAgIGFkZGkgc3AsIHNwLCBQVF9TSVpFX09OX1NUQUNLCj4g Pgo+ID4gICAgICAgICByZXQKPiA+IC1FTkRQUk9DKF9fa3JldHByb2JlX3RyYW1wb2xpbmUpCj4g PiArRU5EUFJPQyhhcmNoX3JldGhvb2tfdHJhbXBvbGluZSkKPiA+IC0tCj4gPiAyLjM4LjAKPiA+ CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1y aXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D95D0C433FE for ; Tue, 1 Nov 2022 17:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbiKARIL (ORCPT ); Tue, 1 Nov 2022 13:08:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbiKARIH (ORCPT ); Tue, 1 Nov 2022 13:08:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F399D8B for ; Tue, 1 Nov 2022 10:08:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25EC261656 for ; Tue, 1 Nov 2022 17:08:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54410C433D6; Tue, 1 Nov 2022 17:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667322481; bh=2Y4FXSKTEjF1qcYmzzsY+q+7a2NVRoQEVXrR1FcCVUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tA0ddphq6ZwqaV0xWZCkp4pEcY+OkbDE5oOQ20B1NJIg0FozRlhFhoyURR1kcsuxF UEDIX59usJVYSRW10N+LTLu7FEP2dnpLIdBBv6r/wUpIxp3eThbdqrsCGZk5e0JxTV KDhO5w3b2LhVhBaVCyPfwc+N1LpT6Z8T4Xui5tvJAllXrfXW0YdW9lpVfHZ0xCnh14 u2JKSYVFyoMnXyPGWJxU9VqYUaUkqfBsnedrUtAYXZAr5LwqM5VsS/yOUNw0h7pM5g 5Ce//sdIikux7UK1eMgr1xDJhxg0I0iG5isX4uFKJMFNBX63Gp5erpr+Gc9umYqxo2 pq1za7wo5ObLA== Date: Tue, 1 Nov 2022 17:07:56 +0000 From: Conor Dooley To: binglei wang Cc: aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, linux-kernel@vger.kernel.org, mhiramat@kernel.org, naveen.n.rao@linux.ibm.com, Conor Dooley Subject: Re: [PATCH RESEND v9] riscv: add riscv rethook implementation Message-ID: References: <20221025151831.1097417-1-conor@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 09:40:23PM +0800, binglei wang wrote: > Hi Conor, > > Thanks for your resending. > What to do next is just to wait patently, right ? Yup.. You'll get at least one email when it gets applied. It's in patchwork [0] so it should not get forgotten about. 0 - https://patchwork.kernel.org/project/linux-riscv/patch/20221025151831.1097417-1-conor@kernel.org/ > > Binglei Wang > Best wishes. > > > Conor Dooley 于2022年10月25日周二 23:19写道： > > > > From: Binglei Wang > > > > Implement the kretprobes on riscv arch by using rethook machenism > > which abstracts general kretprobe info into a struct rethook_node > > to be embedded in the struct kretprobe_instance. > > > > Acked-by: Masami Hiramatsu (Google) > > Signed-off-by: Binglei Wang > > Signed-off-by: Conor Dooley > > --- > > Binglei's patches do not seem to make it to the linux-riscv list, so > > blindly resending on their behalf, with Masami's ack from v8 added. > > > > arch/riscv/Kconfig | 1 + > > arch/riscv/include/asm/kprobes.h | 2 -- > > arch/riscv/kernel/probes/Makefile | 2 +- > > arch/riscv/kernel/probes/kprobes.c | 13 --------- > > arch/riscv/kernel/probes/rethook.c | 27 +++++++++++++++++++ > > arch/riscv/kernel/probes/rethook.h | 8 ++++++ > > ...obes_trampoline.S => rethook_trampoline.S} | 6 ++--- > > 7 files changed, 40 insertions(+), 19 deletions(-) > > create mode 100644 arch/riscv/kernel/probes/rethook.c > > create mode 100644 arch/riscv/kernel/probes/rethook.h > > rename arch/riscv/kernel/probes/{kprobes_trampoline.S => rethook_trampoline.S} (94%) > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index 6b48a3ae9843..413aeca71ca0 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -99,6 +99,7 @@ config RISCV > > select HAVE_KPROBES if !XIP_KERNEL > > select HAVE_KPROBES_ON_FTRACE if !XIP_KERNEL > > select HAVE_KRETPROBES if !XIP_KERNEL > > + select HAVE_RETHOOK if !XIP_KERNEL > > select HAVE_MOVE_PMD > > select HAVE_MOVE_PUD > > select HAVE_PCI > > diff --git a/arch/riscv/include/asm/kprobes.h b/arch/riscv/include/asm/kprobes.h > > index 217ef89f22b9..e7882ccb0fd4 100644 > > --- a/arch/riscv/include/asm/kprobes.h > > +++ b/arch/riscv/include/asm/kprobes.h > > @@ -40,8 +40,6 @@ void arch_remove_kprobe(struct kprobe *p); > > int kprobe_fault_handler(struct pt_regs *regs, unsigned int trapnr); > > bool kprobe_breakpoint_handler(struct pt_regs *regs); > > bool kprobe_single_step_handler(struct pt_regs *regs); > > -void __kretprobe_trampoline(void); > > -void __kprobes *trampoline_probe_handler(struct pt_regs *regs); > > > > #endif /* CONFIG_KPROBES */ > > #endif /* _ASM_RISCV_KPROBES_H */ > > diff --git a/arch/riscv/kernel/probes/Makefile b/arch/riscv/kernel/probes/Makefile > > index 7f0840dcc31b..c40139e9ca47 100644 > > --- a/arch/riscv/kernel/probes/Makefile > > +++ b/arch/riscv/kernel/probes/Makefile > > @@ -1,6 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_KPROBES) += kprobes.o decode-insn.o simulate-insn.o > > -obj-$(CONFIG_KPROBES) += kprobes_trampoline.o > > +obj-$(CONFIG_RETHOOK) += rethook.o rethook_trampoline.o > > obj-$(CONFIG_KPROBES_ON_FTRACE) += ftrace.o > > obj-$(CONFIG_UPROBES) += uprobes.o decode-insn.o simulate-insn.o > > CFLAGS_REMOVE_simulate-insn.o = $(CC_FLAGS_FTRACE) > > diff --git a/arch/riscv/kernel/probes/kprobes.c b/arch/riscv/kernel/probes/kprobes.c > > index e6e950b7cf32..f21592d20306 100644 > > --- a/arch/riscv/kernel/probes/kprobes.c > > +++ b/arch/riscv/kernel/probes/kprobes.c > > @@ -345,19 +345,6 @@ int __init arch_populate_kprobe_blacklist(void) > > return ret; > > } > > > > -void __kprobes __used *trampoline_probe_handler(struct pt_regs *regs) > > -{ > > - return (void *)kretprobe_trampoline_handler(regs, NULL); > > -} > > - > > -void __kprobes arch_prepare_kretprobe(struct kretprobe_instance *ri, > > - struct pt_regs *regs) > > -{ > > - ri->ret_addr = (kprobe_opcode_t *)regs->ra; > > - ri->fp = NULL; > > - regs->ra = (unsigned long) &__kretprobe_trampoline; > > -} > > - > > int __kprobes arch_trampoline_kprobe(struct kprobe *p) > > { > > return 0; > > diff --git a/arch/riscv/kernel/probes/rethook.c b/arch/riscv/kernel/probes/rethook.c > > new file mode 100644 > > index 000000000000..5c27c1f50989 > > --- /dev/null > > +++ b/arch/riscv/kernel/probes/rethook.c > > @@ -0,0 +1,27 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Generic return hook for riscv. > > + */ > > + > > +#include > > +#include > > +#include "rethook.h" > > + > > +/* This is called from arch_rethook_trampoline() */ > > +unsigned long __used arch_rethook_trampoline_callback(struct pt_regs *regs) > > +{ > > + return rethook_trampoline_handler(regs, regs->s0); > > +} > > + > > +NOKPROBE_SYMBOL(arch_rethook_trampoline_callback); > > + > > +void arch_rethook_prepare(struct rethook_node *rhn, struct pt_regs *regs, bool mcount) > > +{ > > + rhn->ret_addr = regs->ra; > > + rhn->frame = regs->s0; > > + > > + /* replace return addr with trampoline */ > > + regs->ra = (unsigned long)arch_rethook_trampoline; > > +} > > + > > +NOKPROBE_SYMBOL(arch_rethook_prepare); > > diff --git a/arch/riscv/kernel/probes/rethook.h b/arch/riscv/kernel/probes/rethook.h > > new file mode 100644 > > index 000000000000..4758f7e3ce88 > > --- /dev/null > > +++ b/arch/riscv/kernel/probes/rethook.h > > @@ -0,0 +1,8 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +#ifndef __RISCV_RETHOOK_H > > +#define __RISCV_RETHOOK_H > > + > > +unsigned long arch_rethook_trampoline_callback(struct pt_regs *regs); > > +void arch_rethook_prepare(struct rethook_node *rhn, struct pt_regs *regs, bool mcount); > > + > > +#endif > > diff --git a/arch/riscv/kernel/probes/kprobes_trampoline.S b/arch/riscv/kernel/probes/rethook_trampoline.S > > similarity index 94% > > rename from arch/riscv/kernel/probes/kprobes_trampoline.S > > rename to arch/riscv/kernel/probes/rethook_trampoline.S > > index 7bdb09ded39b..21bac92a170a 100644 > > --- a/arch/riscv/kernel/probes/kprobes_trampoline.S > > +++ b/arch/riscv/kernel/probes/rethook_trampoline.S > > @@ -75,13 +75,13 @@ > > REG_L x31, PT_T6(sp) > > .endm > > > > -ENTRY(__kretprobe_trampoline) > > +ENTRY(arch_rethook_trampoline) > > addi sp, sp, -(PT_SIZE_ON_STACK) > > save_all_base_regs > > > > move a0, sp /* pt_regs */ > > > > - call trampoline_probe_handler > > + call arch_rethook_trampoline_callback > > > > /* use the result as the return-address */ > > move ra, a0 > > @@ -90,4 +90,4 @@ ENTRY(__kretprobe_trampoline) > > addi sp, sp, PT_SIZE_ON_STACK > > > > ret > > -ENDPROC(__kretprobe_trampoline) > > +ENDPROC(arch_rethook_trampoline) > > -- > > 2.38.0 > >