From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Nhat Pham <nphamcs@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com
Subject: Re: [PATCH 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks
Date: Wed, 2 Nov 2022 12:28:56 +0900 [thread overview]
Message-ID: <Y2Hj+H4VzlN/fcmR@google.com> (raw)
In-Reply-To: <20221026200613.1031261-3-nphamcs@gmail.com>
On (22/10/26 13:06), Nhat Pham wrote:
> struct size_class {
> - spinlock_t lock;
> struct list_head fullness_list[NR_ZS_FULLNESS];
> /*
> * Size of objects stored in this class. Must be multiple
> @@ -247,8 +245,7 @@ struct zs_pool {
> #ifdef CONFIG_COMPACTION
> struct work_struct free_work;
> #endif
> - /* protect page/zspage migration */
> - rwlock_t migrate_lock;
> + spinlock_t lock;
> };
I'm not in love with this, to be honest. One big pool lock instead
of 255 per-class locks doesn't look attractive, as one big pool lock
is going to be hammered quite a lot when zram is used, e.g. as a regular
block device with a file system and is under heavy parallel writes/reads.
next prev parent reply other threads:[~2022-11-02 3:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 20:06 [PATCH 0/5] Implement writeback for zsmalloc Nhat Pham
2022-10-26 20:06 ` [PATCH 1/5] zswap: fix writeback lock ordering " Nhat Pham
2022-10-26 20:06 ` [PATCH 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-10-28 14:46 ` Johannes Weiner
2022-11-02 3:28 ` Sergey Senozhatsky [this message]
2022-11-02 21:36 ` Minchan Kim
2022-11-03 15:18 ` Johannes Weiner
2022-11-03 15:53 ` Minchan Kim
2022-11-03 18:08 ` Johannes Weiner
2022-11-03 18:10 ` Yosry Ahmed
2022-11-03 20:37 ` Minchan Kim
2022-11-03 20:46 ` Yosry Ahmed
2022-11-03 21:15 ` Yu Zhao
2022-11-03 23:19 ` Yosry Ahmed
2022-11-03 21:43 ` Minchan Kim
2022-11-03 23:31 ` Yosry Ahmed
2022-11-03 20:22 ` Minchan Kim
2022-11-04 3:58 ` Sergey Senozhatsky
2022-11-07 21:31 ` Nhat Pham
2022-11-07 22:35 ` Minchan Kim
2022-10-26 20:06 ` [PATCH 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Nhat Pham
2022-10-28 14:47 ` Johannes Weiner
2022-10-26 20:06 ` [PATCH 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Nhat Pham
2022-10-28 15:18 ` Johannes Weiner
2022-11-02 4:10 ` Sergey Senozhatsky
2022-11-07 21:36 ` Nhat Pham
2022-10-26 20:06 ` [PATCH 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-10-27 13:53 ` kernel test robot
2022-10-27 18:27 ` [PATCH v2 " Nhat Pham
2022-10-28 15:19 ` Johannes Weiner
2022-11-02 3:42 ` Sergey Senozhatsky
2022-11-03 15:26 ` Johannes Weiner
2022-11-02 3:44 ` Sergey Senozhatsky
2022-11-02 4:13 ` Sergey Senozhatsky
2022-11-03 16:45 ` Johannes Weiner
2022-11-04 4:02 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Hj+H4VzlN/fcmR@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.