From: Cyril Hrubis <chrubis@suse.cz>
To: Tarun Sahu <tsahu@linux.ibm.com>
Cc: aneesh.kumar@linux.ibm.com, ltp@lists.linux.it,
geetika@linux.ibm.com, sbhat@linux.ibm.com,
vaibhav@linux.ibm.com
Subject: Re: [LTP] [PATCH v3 1/4] Hugetlb: Add new tst_test options for hugeltb test support
Date: Wed, 2 Nov 2022 14:38:00 +0100 [thread overview]
Message-ID: <Y2JyuL6bh1BlD4lE@yuki> (raw)
In-Reply-To: <20221031192519.x2exs2pfumpxe4zj@tarunpc>
Hi!
> > Is there a good reason for this, why can't we call tst_umount() for
> > hugetlbfs?
> >
>
> My reason behind this is,
> tst_umount doesnt break the test, if umount fails. One of the cause
> of failure can be that test left the mounted fs busy, which is not
> expected.
This does not matter, because the do_cleanup() is called only once at
the end of the test. The test exists once the function does finish
anyways.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-02 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 7:13 [LTP] [PATCH v3 0/4] Hugetlb:Migrating the libhugetlbfs tests Tarun Sahu
2022-10-29 7:13 ` [LTP] [PATCH v3 1/4] Hugetlb: Add new tst_test options for hugeltb test support Tarun Sahu
2022-10-31 3:39 ` Li Wang
2022-10-31 11:08 ` Tarun Sahu
2022-10-31 14:49 ` Cyril Hrubis
2022-10-31 14:56 ` Cyril Hrubis
2022-10-31 18:02 ` Tarun Sahu
2022-11-01 2:05 ` Li Wang
2022-10-31 14:47 ` Cyril Hrubis
2022-10-31 19:25 ` Tarun Sahu
2022-11-02 13:38 ` Cyril Hrubis [this message]
2022-10-29 7:13 ` [LTP] [PATCH v3 2/4] Hugetlb: Migrating libhugetlbfs brk_near_huge Tarun Sahu
2022-10-29 7:13 ` [LTP] [PATCH v3 3/4] Hugetlb: Migrating libhugetlbfs chunk-overcommit Tarun Sahu
2022-10-31 7:34 ` Li Wang
2022-10-31 11:19 ` Tarun Sahu
2022-10-29 7:13 ` [LTP] [PATCH v3 4/4] Hugetlb: Migrating libhugetlbfs corrupt-by-cow-opt Tarun Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2JyuL6bh1BlD4lE@yuki \
--to=chrubis@suse.cz \
--cc=aneesh.kumar@linux.ibm.com \
--cc=geetika@linux.ibm.com \
--cc=ltp@lists.linux.it \
--cc=sbhat@linux.ibm.com \
--cc=tsahu@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.