From: Taylor Blau <me@ttaylorr.com>
To: John Soo <johh.soo@arista.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Johannes Schindelin <dscho@github.com>,
git@vger.kernel.org
Subject: Re: safe.directory and ACLs
Date: Wed, 2 Nov 2022 20:11:33 -0400 [thread overview]
Message-ID: <Y2MHNeSrhxfH1Ayf@nand.local> (raw)
In-Reply-To: <CAJyRyRqMPX93-Oa5XMvZtDTRxh0SisUhOFAWhv-6hXR5sEkQpA@mail.gmail.com>
On Wed, Nov 02, 2022 at 04:41:15PM -0700, John Soo wrote:
> Hi brian!
>
> > No, the permissions of a repository, whether standard Unix permissions
> > or ACLs, are not relevant to ownership. The question here is whether
> > the owner of the .git directory (that is, the value of the `st_uid`
> > field when calling lstat(2) on it) is equal to the effective user ID.
> >
> > When you the path in `ls`, you can see the owner and group of the file
> > specified, and that owner is what matters here.
>
> I see. Is that by design or an implementation detail?
It is by design. See 8959555cee7 (setup_git_directory(): add an owner
check for the top-level directory, 2022-03-02) for details.
Thanks,
Taylor
next prev parent reply other threads:[~2022-11-03 0:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 15:18 safe.directory and ACLs John Soo
2022-11-02 21:27 ` brian m. carlson
2022-11-02 23:41 ` John Soo
2022-11-03 0:11 ` Taylor Blau [this message]
2022-11-03 0:39 ` John Soo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2MHNeSrhxfH1Ayf@nand.local \
--to=me@ttaylorr.com \
--cc=dscho@github.com \
--cc=git@vger.kernel.org \
--cc=johh.soo@arista.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.