From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FA0C4332F for ; Thu, 3 Nov 2022 00:24:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbiKCAYC (ORCPT ); Wed, 2 Nov 2022 20:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbiKCAYC (ORCPT ); Wed, 2 Nov 2022 20:24:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBE0E60D5; Wed, 2 Nov 2022 17:24:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5820661CE1; Thu, 3 Nov 2022 00:24:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 185E0C433D7; Thu, 3 Nov 2022 00:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667435040; bh=UexGygkWb0bGtw2UM0ZjgXrlEJjm3frSfcJCq0INPNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jjKbU6IhfMUx+o1ufnCQAmcEuO5CEdisP9B5Qkx4RXE5Cpyvm0UtFX6rrU+zIMTgD sYg5NLJ72WjViycClrYCyl1jT/tMeTeokobqPMoRU6JVQnZWcAvIkUBRW9/pUwow1Q 4LSOIqHHuf9KsAMtE+ZS/kKA5zZXWUsdn+TTAP/4= Date: Thu, 3 Nov 2022 01:24:56 +0100 From: Greg Kroah-Hartman To: Elliot Berman Cc: mec@shout.net, Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , Srinivas Kandagatla , Amol Maheshwari , Kalle Valo , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 13/21] gunyah: vm_mgr: Introduce basic VM Manager Message-ID: References: <20221026185846.3983888-1-quic_eberman@quicinc.com> <20221026185846.3983888-14-quic_eberman@quicinc.com> <722b05a1-4bf5-0837-baea-b1d0a9cc1e43@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <722b05a1-4bf5-0837-baea-b1d0a9cc1e43@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Nov 02, 2022 at 11:45:12AM -0700, Elliot Berman wrote: > +Michael > > On 11/1/2022 10:14 PM, Greg Kroah-Hartman wrote: > > On Wed, Oct 26, 2022 at 11:58:38AM -0700, Elliot Berman wrote: > > > +#define GH_CREATE_VM _IO(GH_IOCTL_TYPE, 0x40) /* Returns a Gunyah VM fd */ > > > > Why 0x40? Why not just use the same KVM ioctl numbers and names as you > > are doing the same thing as them, right? > > We've designed so that there are a few ioctls that will feel similar to KVM > ioctls since we know this design has been successful, but we don't intend to > support KVM ioctls 1:1. Gunyah has different semantics for many of the > name-identical ioctls. It seems odd to mix some re-used KVM ioctls with > novel Gunyah ioctls? Even if you don't support it 1:1, at least for the ones that are the same thing, pick the same numbers as that's a nicer thing to do, right? > > Normally your first ioctl is "0x01", not "0x40", so this feels really > > odd. > > > > Documentation/userspace-api/ioctl/iocl-number.rst advises to pick an unused > block. We picked ioctl code 'G' and unused sequence numbers under that code. > I'm ok to move the block around. How do you know you picked an unused block? It wasn't obvious where you got these values from at all, and unfortunatly, no one really ever updates that documentation file. Luckily it never really matters. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12650C4332F for ; Thu, 3 Nov 2022 00:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mUAiNGMtJl7PM/ianYngQBkR2HramxXjs/xpt/INk08=; b=Iec6z9Tb5cg6jX QGv8noHl3lCMFwZw5kcMZQCaumVM6kX81SlvxhOkjdUtJs/ivU72fSNmZXD7cHLiMnmIiPk/w6wPW aAI3zzbOSR1trupzE76l1l6qoaqtVagneSNxHv+UHB9vGwzrA7aEqwjLJ5o5eNtmPzurir2/DY5Cj xHQ3g669XlyYWE2WSoy4X6fpYSXwYp1o7kVhSXBpAV6an0tccYNNfOnIhwKs4ni2GsPzFruAllJGl rv+U8jt58JQvtHSdn3uJ7BRUq+B56VdDBPFF8QS+6sPq0B4YYu8gLOxdoTQ9sQZJpClHskffSfOJj nwDMpJg7BeP7Pc3JOMGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqO1d-00FINC-Of; Thu, 03 Nov 2022 00:24:05 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqO1b-00FILz-ER for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 00:24:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48D5661CC1; Thu, 3 Nov 2022 00:24:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 185E0C433D7; Thu, 3 Nov 2022 00:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667435040; bh=UexGygkWb0bGtw2UM0ZjgXrlEJjm3frSfcJCq0INPNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jjKbU6IhfMUx+o1ufnCQAmcEuO5CEdisP9B5Qkx4RXE5Cpyvm0UtFX6rrU+zIMTgD sYg5NLJ72WjViycClrYCyl1jT/tMeTeokobqPMoRU6JVQnZWcAvIkUBRW9/pUwow1Q 4LSOIqHHuf9KsAMtE+ZS/kKA5zZXWUsdn+TTAP/4= Date: Thu, 3 Nov 2022 01:24:56 +0100 From: Greg Kroah-Hartman To: Elliot Berman Cc: mec@shout.net, Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , Srinivas Kandagatla , Amol Maheshwari , Kalle Valo , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 13/21] gunyah: vm_mgr: Introduce basic VM Manager Message-ID: References: <20221026185846.3983888-1-quic_eberman@quicinc.com> <20221026185846.3983888-14-quic_eberman@quicinc.com> <722b05a1-4bf5-0837-baea-b1d0a9cc1e43@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <722b05a1-4bf5-0837-baea-b1d0a9cc1e43@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_172403_539550_44CE3D25 X-CRM114-Status: GOOD ( 20.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 02, 2022 at 11:45:12AM -0700, Elliot Berman wrote: > +Michael > > On 11/1/2022 10:14 PM, Greg Kroah-Hartman wrote: > > On Wed, Oct 26, 2022 at 11:58:38AM -0700, Elliot Berman wrote: > > > +#define GH_CREATE_VM _IO(GH_IOCTL_TYPE, 0x40) /* Returns a Gunyah VM fd */ > > > > Why 0x40? Why not just use the same KVM ioctl numbers and names as you > > are doing the same thing as them, right? > > We've designed so that there are a few ioctls that will feel similar to KVM > ioctls since we know this design has been successful, but we don't intend to > support KVM ioctls 1:1. Gunyah has different semantics for many of the > name-identical ioctls. It seems odd to mix some re-used KVM ioctls with > novel Gunyah ioctls? Even if you don't support it 1:1, at least for the ones that are the same thing, pick the same numbers as that's a nicer thing to do, right? > > Normally your first ioctl is "0x01", not "0x40", so this feels really > > odd. > > > > Documentation/userspace-api/ioctl/iocl-number.rst advises to pick an unused > block. We picked ioctl code 'G' and unused sequence numbers under that code. > I'm ok to move the block around. How do you know you picked an unused block? It wasn't obvious where you got these values from at all, and unfortunatly, no one really ever updates that documentation file. Luckily it never really matters. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel