From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22041C4332F for ; Thu, 3 Nov 2022 09:31:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqWXt-0001GE-2Z; Thu, 03 Nov 2022 05:29:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqWXr-0001G6-23 for qemu-devel@nongnu.org; Thu, 03 Nov 2022 05:29:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqWXp-0003AI-5R for qemu-devel@nongnu.org; Thu, 03 Nov 2022 05:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667467792; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L+NCLdnKylKsu/Ha9xzn3/cBEXlHJYXCpoqtofdxjNs=; b=gDvYQOyqzacnDVS3szLqw0mqxjC7jgrXWp7EpYqgyYe1bCvF1wmgbbEWacTBm1EMb6Kycb xfGAjvfVSUVUMKTmM9GPMpVTTDRPfIfbUEfvxU4PvjRTmb3WdpcnUZZ6rVIs/wDwq/hO9h wwtioquEQUKCZo3Z26vMi1oybauKojU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-Jy_Vs-wJPsa04vRZyutIkA-1; Thu, 03 Nov 2022 05:29:48 -0400 X-MC-Unique: Jy_Vs-wJPsa04vRZyutIkA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 659BB87B2A0; Thu, 3 Nov 2022 09:29:48 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C1F92166B26; Thu, 3 Nov 2022 09:29:47 +0000 (UTC) Date: Thu, 3 Nov 2022 09:29:45 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "manish.mishra" Cc: qemu-devel@nongnu.org, peterx@redhat.com, Prerna Saxena Subject: Re: [PATCH] migration: check magic value for deciding the mapping of channels Message-ID: References: <20221101143029.14246-1-manish.mishra@nutanix.com> <9faf2604-f0b9-f3c3-5ac8-e4deeeebc424@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.048, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Nov 03, 2022 at 02:50:25PM +0530, manish.mishra wrote: > > On 01/11/22 9:15 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote: > > > On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: > > > > On Tue, Nov 01, 2022 at 02:30:29PM +0000, manish.mishra wrote: > > > > > diff --git a/migration/migration.c b/migration/migration.c > > > > > index 739bb683f3..f4b6f278a9 100644 > > > > > --- a/migration/migration.c > > > > > +++ b/migration/migration.c > > > > > @@ -733,31 +733,40 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error **errp) > > > > > { > > > > > MigrationIncomingState *mis = migration_incoming_get_current(); > > > > > Error *local_err = NULL; > > > > > - bool start_migration; > > > > > QEMUFile *f; > > > > > + bool default_channel = true; > > > > > + uint32_t channel_magic = 0; > > > > > + int ret = 0; > > > > > - if (!mis->from_src_file) { > > > > > - /* The first connection (multifd may have multiple) */ > > > > > + if (migrate_use_multifd() && !migration_in_postcopy()) { > > > > > + ret = qio_channel_read_peek_all(ioc, (void *)&channel_magic, > > > > > + sizeof(channel_magic), &local_err); > > > > > + > > > > > + if (ret != 1) { > > > > > + error_propagate(errp, local_err); > > > > > + return; > > > > > + } > > > > ....and thus this will fail for TLS channels AFAICT. > > > Yes, thanks for quick review Daniel. You pointed this earlier too, sorry missed it, will put another check !migrate_use_tls() in V2. > > But we need this problem fixed with TLS too, so just excluding it > > isn't right. IMHO we need to modify the migration code so we can > > read the magic earlier, instead of peeking. > > > > > > With regards, > > Daniel > > Hi Daniel, I was trying tls migrations. What i see is that tls session > creation does handshake. So if we read ahead in ioc_process_incoming > for default channel. Because client sends magic only after multiFD > channels are setup, which too requires tls handshake. By the time we get to migrate_ioc_process_incoming, the TLS handshake has already been performed. migration_channel_process_incoming -> migration_ioc_process_incoming vs migration_channel_process_incoming -> migration_tls_channel_process_incoming -> migration_tls_incoming_handshake -> migration_channel_process_incoming -> migration_ioc_process_incoming With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|