All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Correctly check setitimer params in setitimer01
Date: Thu, 3 Nov 2022 15:05:22 +0100	[thread overview]
Message-ID: <Y2PKoqbsxun3eAVZ@pevik> (raw)
In-Reply-To: <1af8a502-c736-c31a-8794-c847788c8766@suse.com>

Hi all,

> > > @@ -64,14 +66,18 @@ static void verify_setitimer(unsigned int i)
> > >             tst_no_corefile(0);
> > >   -        set_setitimer_value(USEC1, 0);
> > > -        TST_EXP_PASS(sys_setitimer(tc->which, value, NULL));
> > > +        set_setitimer_value(usec, 0);
> > > +        TST_EXP_PASS(sys_setitimer(tc->which, value, 0));

> > Why change the third argument from NULL to 0?

> It's a mistake. I sent patch with 0 because I was tweaking with values
> during tests.

Good. I put it back and merged with updated copyright and adjusted the commit
message and description.

Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-11-03 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 14:59 [LTP] [PATCH v1] Correctly check setitimer params in setitimer01 Andrea Cervesato via ltp
2022-11-02 15:39 ` Martin Doucha
2022-11-03 13:35   ` Andrea Cervesato via ltp
2022-11-03 14:05     ` Petr Vorel [this message]
2022-11-04  6:48 ` Li Wang
2022-11-04  8:18   ` Li Wang
2022-11-04  8:18   ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2PKoqbsxun3eAVZ@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.