All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Stefan Agner <stefan@agner.ch>, Johan Hovold <johan@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 1/2] usb: dwc3: exynos: force PHY control from XHCI HCD
Date: Thu, 3 Nov 2022 23:41:06 +0900	[thread overview]
Message-ID: <Y2PTAj0gAyWcx+HI@kroah.com> (raw)
In-Reply-To: <20221103141233.20179-1-m.szyprowski@samsung.com>

On Thu, Nov 03, 2022 at 03:12:32PM +0100, Marek Szyprowski wrote:
> Force controlling of the generic USB PHYs also from XHCI HCD to let XHCI
> driver call calibrate() method during the HCD reset. DWC3 also controls
> USB PHYs, but it is not able to call the calibrate() method at the right
> moment.
> 
> Fixes: 6000b8d900cd ("usb: dwc3: disable USB core PHY management")
> Reported-by: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> This fixes the issue reported here:
> https://lore.kernel.org/all/808bdba846bb60456adf10a3016911ee@agner.ch/
> 
> Alternative for this change is a complete revert of the 6000b8d900cd
> ("usb: dwc3: disable USB core PHY management") commit.

We can revert that commit if something is broken so it can be fixed
properly instead of this.

thanks,

greg k-h

  parent reply	other threads:[~2022-11-03 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221103141239eucas1p29dac7ffb7202852c18e48c48c068a90f@eucas1p2.samsung.com>
2022-11-03 14:12 ` [PATCH 1/2] usb: dwc3: exynos: force PHY control from XHCI HCD Marek Szyprowski
2022-11-03 14:12   ` [PATCH 2/2] of: export of_device_add() Marek Szyprowski
2022-11-03 14:40     ` Greg Kroah-Hartman
2022-11-03 14:42       ` Johan Hovold
2022-11-03 14:41   ` Greg Kroah-Hartman [this message]
2022-11-03 14:41     ` [PATCH 1/2] usb: dwc3: exynos: force PHY control from XHCI HCD Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2PTAj0gAyWcx+HI@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=johan@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.