From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08DEC4332F for ; Thu, 3 Nov 2022 14:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbiKCOnU (ORCPT ); Thu, 3 Nov 2022 10:43:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230294AbiKCOnT (ORCPT ); Thu, 3 Nov 2022 10:43:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51E281838E; Thu, 3 Nov 2022 07:43:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0F284B828A4; Thu, 3 Nov 2022 14:43:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAF06C433D6; Thu, 3 Nov 2022 14:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667486595; bh=claiLflm+5thNilZ4cUGBCpj6+MocHH7QuSKQ2lHGH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u/lvl7xUbmGFjB8MZFkXzSnAtW5/qDXG8oJRlGuh8vsGThNeqQ8TnY0w3ipUbWLSA zNmZ32Px8IHyx7su4Tlo9cpFIlG9AmvkdVpBX+KTC3aJCPSvFk6N5nuymYTRc4GSKa A4wCJ617WUyT3WzT2nEQ3aKSrPAyVUUqNl6ejhewuHtsYxitzkbmDOBStLrBqOYp86 iQhcnlrvj3Gyzs0S7KSnNptflqyVikRtez0e799P2INdYYl92fuQ3S+KnL4h3ujtk4 EG5K7Y4PGgMwKVZoE2evM+1xb7Hrmpokbk+lcA/eh1BzD/1kq7LKfdnePl4aWgOJTp rPe6+g8BZxtCQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oqbQo-0003c5-JI; Thu, 03 Nov 2022 15:42:58 +0100 Date: Thu, 3 Nov 2022 15:42:58 +0100 From: Johan Hovold To: Greg Kroah-Hartman Cc: Marek Szyprowski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Stefan Agner , Thinh Nguyen , Krzysztof Kozlowski , Rob Herring , Frank Rowand Subject: Re: [PATCH 2/2] of: export of_device_add() Message-ID: References: <20221103141233.20179-1-m.szyprowski@samsung.com> <20221103141233.20179-2-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Nov 03, 2022 at 11:40:12PM +0900, Greg Kroah-Hartman wrote: > On Thu, Nov 03, 2022 at 03:12:33PM +0100, Marek Szyprowski wrote: > > Export of_device_add() function to let DWC3 driver (Exynos variant) to > > instantiate DWC3 core device from the respective child OF-node with a > > custom, addtional properties added. > > > > Signed-off-by: Marek Szyprowski > > --- > > drivers/of/device.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c > > index 8cefe5a7d04e..bc60c9b6863c 100644 > > --- a/drivers/of/device.c > > +++ b/drivers/of/device.c > > @@ -52,6 +52,7 @@ int of_device_add(struct platform_device *ofdev) > > > > return device_add(&ofdev->dev); > > } > > +EXPORT_SYMBOL(of_device_add); > > I do not see any user of this symbol after this patch (no 3/2?) > > So why is it needed? No driver should ever be calling this function > directly. It was used by 1/2 so this would have broken bisectability. Johan