All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org, users@linux.kernel.org
Subject: b4 prep and --manual-reroll
Date: Thu, 3 Nov 2022 22:00:07 -0700	[thread overview]
Message-ID: <Y2ScVwTlqH/zz36J@google.com> (raw)

Hi Konstantin,

Somehow "b4 send -o dir" followed by "git send-email ..." managed to
produce quoted-printable cover letter message (see
https://lore.kernel.org/all/20221103-omapfb-gpiod-v1-0-c3d53ca7988f@gmail.com/)
and that confused "b4 prep --manual-reroll ..." as this produced a tag
that had "=0D" as line ends. I was able to work around it with the
patch below (not sure if this is right thing to do)...

Also, doing "b4 send --resend" with this series did produce double
signature on the cover letter, even though I see in the code it tries to
remove it.

Thanks.

-- 
Dmitry

diff --git a/b4/ez.py b/b4/ez.py
index 4fcc988..8fb39d2 100644
--- a/b4/ez.py
+++ b/b4/ez.py
@@ -1350,7 +1350,7 @@ def get_sent_tagname(branch: str, tagprefix: str, revstr: Union[str, int]) -> Tu
 def reroll(mybranch: str, cover_msg: email.message.Message, tagprefix: str = SENT_TAG_PREFIX):
     # Prepare annotated tag body from the cover letter
     lsubject = b4.LoreSubject(cover_msg.get('subject'))
-    cbody = cover_msg.get_payload()
+    cbody = cover_msg.get_payload(decode=True).decode()
     # Remove signature
     chunks = cbody.rsplit('\n-- \n')
     if len(chunks) > 1:

             reply	other threads:[~2022-11-04  5:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04  5:00 Dmitry Torokhov [this message]
2022-11-04 17:13 ` b4 prep and --manual-reroll Konstantin Ryabitsev
2022-11-04 17:47   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2ScVwTlqH/zz36J@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@linux.kernel.org \
    --cc=users@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.