From: Vinod Koul <vkoul@kernel.org>
To: Xiaochen Shen <xiaochen.shen@intel.com>
Cc: fenghua.yu@intel.com, dave.jiang@intel.com,
dmaengine@vger.kernel.org, ramesh.thomas@intel.com,
tony.luck@intel.com, tony.zhu@intel.com, pei.p.jia@intel.com
Subject: Re: [PATCH RESEND] dmaengine: idxd: Make read buffer sysfs attributes invisible for Intel IAA
Date: Fri, 4 Nov 2022 20:14:42 +0530 [thread overview]
Message-ID: <Y2UlWlqnOAuU50kO@matsya> (raw)
In-Reply-To: <20221022074949.11719-1-xiaochen.shen@intel.com>
On 22-10-22, 15:49, Xiaochen Shen wrote:
> In current code, the following sysfs attributes are exposed to user to
> show or update the values:
> max_read_buffers (max_tokens)
> read_buffer_limit (token_limit)
> group/read_buffers_allowed (group/tokens_allowed)
> group/read_buffers_reserved (group/tokens_reserved)
> group/use_read_buffer_limit (group/use_token_limit)
>
> >From Intel IAA spec [1], Intel IAA does not support Read Buffer
> allocation control. So these sysfs attributes should not be supported on
> IAA device.
>
> Fix this issue by making these sysfs attributes invisible through
> is_visible() filter when the device is IAA.
>
> Add description in the ABI documentation to mention that these
> attributes are not visible when the device does not support Read Buffer
> allocation control.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-11-04 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 21:33 [PATCH] dmaengine: idxd: Make read buffer sysfs attributes invisible for Intel IAA Xiaochen Shen
2022-10-22 7:49 ` [PATCH RESEND] " Xiaochen Shen
2022-11-04 14:44 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2UlWlqnOAuU50kO@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=pei.p.jia@intel.com \
--cc=ramesh.thomas@intel.com \
--cc=tony.luck@intel.com \
--cc=tony.zhu@intel.com \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.