From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B126C433FE for ; Fri, 4 Nov 2022 15:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WOjk5Ghf8Nv/sA0PecptZEhSw+VEP3G/vP6gZ6TCaHs=; b=BRa2LEKDC7yIWZ 4femkl7sDhrPyUv17Hz6hiktNXL8YQN5x86ixFnYTPGy2ieDXciTuRgV1KGrXRIOOX7T1/1T7oXt8 kFrC6R1kyxB1iT0gDFfwmdsR0yW8GFAubMIpYr7RSdD28jnXjW3AdlsOIJSuEb6+SwZF0WjOLnV3N 0tuqDHM11ycWde+k1wqjbdnwh6MeDdumaoDLvQrifvKs4fupLM+nU5pmTdU2wmx0j2sdKQH5KTjrx gcdHGm7y0quOMJHhuIHiMZQ1IPviC5WtM0gOIghJY1JjFa6vdfhqISa59iUzOOZ4dTemPXm100hG6 fblqcb3zuH3D0DHLgYXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqyiG-004Fff-2T; Fri, 04 Nov 2022 15:34:32 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqygI-004EpD-8N for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 15:32:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=mT0boajW4GkaMWXjn2Ik44yi9m1XKFhaBoFguDvv3vg=; b=0aKDagYd+Mxgi/Pvo5mkjonGNN 80IH8gS04w8qq49ppCPCtcvQmc2osfp0F7g8wTOnEs1Psnx0T1GX9I8Ds0sw8bAnL6lSw9f1YMt/g IhWxsymy8N0NipH+eiJrZn9aVbbtTeGrmkGuCrC8mvoIh1AQ2KtQrTL5AiLr5O9mjqYg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oqyfw-001RMg-PA; Fri, 04 Nov 2022 16:32:08 +0100 Date: Fri, 4 Nov 2022 16:32:08 +0100 From: Andrew Lunn To: Sriranjani P Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chandrasekar R , Suresh Siddha Subject: Re: [PATCH 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Message-ID: References: <20221104120517.77980-1-sriranjani.p@samsung.com> <20221104120517.77980-3-sriranjani.p@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221104120517.77980-3-sriranjani.p@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_083230_338840_61D88FE2 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > For FSD SoC, a mux switch is needed between internal and external clocks. > By default after reset internal clock is used but for receiving packets > properly, external clock is needed. Mux switch to external clock happens > only when the external clock is present. > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -3831,6 +3831,9 @@ static int __stmmac_open(struct net_device *dev, > netif_tx_start_all_queues(priv->dev); > stmmac_enable_all_dma_irq(priv); > > + if (priv->plat->rxmux_setup) > + priv->plat->rxmux_setup(priv->plat->bsp_priv, true); > + > return 0; > > irq_error: > @@ -3884,6 +3887,9 @@ static int stmmac_release(struct net_device *dev) > struct stmmac_priv *priv = netdev_priv(dev); > u32 chan; > > + if (priv->plat->rxmux_setup) > + priv->plat->rxmux_setup(priv->plat->bsp_priv, false); > + Is this the code which is deciding if the external clock is present? So when somebody called 'ip link set eth42 up'? Where is the external clock coming from? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E6BC43217 for ; Fri, 4 Nov 2022 15:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232574AbiKDPch (ORCPT ); Fri, 4 Nov 2022 11:32:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232136AbiKDPce (ORCPT ); Fri, 4 Nov 2022 11:32:34 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534D52793F; Fri, 4 Nov 2022 08:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=mT0boajW4GkaMWXjn2Ik44yi9m1XKFhaBoFguDvv3vg=; b=0aKDagYd+Mxgi/Pvo5mkjonGNN 80IH8gS04w8qq49ppCPCtcvQmc2osfp0F7g8wTOnEs1Psnx0T1GX9I8Ds0sw8bAnL6lSw9f1YMt/g IhWxsymy8N0NipH+eiJrZn9aVbbtTeGrmkGuCrC8mvoIh1AQ2KtQrTL5AiLr5O9mjqYg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oqyfw-001RMg-PA; Fri, 04 Nov 2022 16:32:08 +0100 Date: Fri, 4 Nov 2022 16:32:08 +0100 From: Andrew Lunn To: Sriranjani P Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chandrasekar R , Suresh Siddha Subject: Re: [PATCH 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Message-ID: References: <20221104120517.77980-1-sriranjani.p@samsung.com> <20221104120517.77980-3-sriranjani.p@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221104120517.77980-3-sriranjani.p@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > For FSD SoC, a mux switch is needed between internal and external clocks. > By default after reset internal clock is used but for receiving packets > properly, external clock is needed. Mux switch to external clock happens > only when the external clock is present. > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -3831,6 +3831,9 @@ static int __stmmac_open(struct net_device *dev, > netif_tx_start_all_queues(priv->dev); > stmmac_enable_all_dma_irq(priv); > > + if (priv->plat->rxmux_setup) > + priv->plat->rxmux_setup(priv->plat->bsp_priv, true); > + > return 0; > > irq_error: > @@ -3884,6 +3887,9 @@ static int stmmac_release(struct net_device *dev) > struct stmmac_priv *priv = netdev_priv(dev); > u32 chan; > > + if (priv->plat->rxmux_setup) > + priv->plat->rxmux_setup(priv->plat->bsp_priv, false); > + Is this the code which is deciding if the external clock is present? So when somebody called 'ip link set eth42 up'? Where is the external clock coming from? Andrew