All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	a.zummo@towertech.it, linux-rtc@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms
Date: Sun, 6 Nov 2022 18:54:55 +0100	[thread overview]
Message-ID: <Y2f079jOra55IGgr@mail.local> (raw)
In-Reply-To: <20221106170729.1581125-1-sashal@kernel.org>

Hello, this doesn't need to be backported unless you also backport
those:
0782b66ed2fb rtc: cmos: Fix wake alarm breakage
4919d3eb2ec0 rtc: cmos: Fix event handler registration ordering issue
6492fed7d8c9 rtc: rtc-cmos: Do not check ACPI_FADT_LOW_POWER_S0


On 06/11/2022 12:07:29-0500, Sasha Levin wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> [ Upstream commit db4e955ae333567dea02822624106c0b96a2f84f ]
> 
> Now that rtc_wake_setup is called outside of cmos_wake_setup, it also need
> to be defined on non-ACPI platforms.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/r/20221018203512.2532407-1-alexandre.belloni@bootlin.com
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/rtc/rtc-cmos.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 1dbd8419df7d..2c3881bdf9bb 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -1113,6 +1113,9 @@ static void cmos_check_acpi_rtc_status(struct device *dev,
>  {
>  }
>  
> +static void rtc_wake_setup(struct device *dev)
> +{
> +}
>  #endif
>  
>  #ifdef	CONFIG_PNP
> -- 
> 2.35.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2022-11-06 17:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06 17:07 [PATCH AUTOSEL 4.9] rtc: cmos: fix build on non-ACPI platforms Sasha Levin
2022-11-06 17:54 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2f079jOra55IGgr@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.