From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
x86@kernel.org
Subject: Re: [tip: x86/urgent] x86/tdx: Prepare for using "INFO" call for a second purpose
Date: Sun, 6 Nov 2022 20:50:16 +0100 [thread overview]
Message-ID: <Y2gP+AT1XdapImV4@zn.tnic> (raw)
In-Reply-To: <d4614b70-b37b-44b8-6a9c-54d59a6f9fec@intel.com>
On Sun, Nov 06, 2022 at 09:02:27AM -0800, Dave Hansen wrote:
> It's fine for now, except that the naming on this:
>
> - tdx_parse_tdinfo(&cc_mask);
> + cc_mask = tdx_parse_tdinfo();
>
> is a bit funky since tdx_parse_tdinfo() is doing a couple of things
Yeah, that was the next thing that was bothering me.
> and will need to return a second item shortly.
Well, then rename this one back to get_cc_mask() and have a new function
return the second item?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-11-06 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 23:25 [tip: x86/urgent] x86/tdx: Prepare for using "INFO" call for a second purpose tip-bot2 for Dave Hansen
2022-11-06 12:45 ` Borislav Petkov
2022-11-06 17:02 ` Dave Hansen
2022-11-06 19:50 ` Borislav Petkov [this message]
2022-11-07 13:26 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2gP+AT1XdapImV4@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.