From: Lee Jones <lee@kernel.org>
To: Dawei Li <set_pte_at@outlook.com>
Cc: rafael@kernel.org, gregkh@linuxfoundation.org,
u.kleine-koenig@pengutronix.de, dvhart@infradead.org,
andy@infradead.org, lenb@kernel.org, arnd@arndb.de,
peterhuewe@gmx.de, kys@microsoft.com, kronos.it@gmail.com,
dmitry.torokhov@gmail.com, bleung@chromium.org,
sujith.thomas@intel.com, vithampi@vmware.com,
wim@linux-watchdog.org, jgross@suse.com, davem@davemloft.net,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] acpi: make remove callback of acpi driver void
Date: Mon, 7 Nov 2022 08:20:31 +0000 [thread overview]
Message-ID: <Y2i/zy8CVzTb6qdE@google.com> (raw)
In-Reply-To: <TYCP286MB232348AC39E6F4966FA9494BCA3D9@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On Sun, 06 Nov 2022, Dawei Li wrote:
> For bus-based driver, device removal is implemented as:
> 1 device_remove()->
> 2 bus->remove()->
> 3 driver->remove()
>
> Driver core needs _no_ inform from callee(bus driver) about the
> result of remove callback. In that case,
> commit <fc7a6209d571> ("bus: Make remove callback return void")
> forces struct bus_type::remove() be void-returned.
>
> Now we have the situation that both 1 & 2 of calling chain are
> void-returned, so it does _not_ make much sense for 3(driver->remove)
> to return non-void to its caller.
>
> So the basic idea behind this change is making remove() callback of
> any bus-based driver to be void-returned.
>
> This change itself, is for device drivers based on acpi-bus.
>
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>
> ---
> arch/ia64/hp/common/aml_nfw.c | 4 ++--
> arch/x86/platform/olpc/olpc-xo15-sci.c | 3 +--
> drivers/acpi/ac.c | 8 +++-----
> drivers/acpi/acpi_pad.c | 3 +--
> drivers/acpi/acpi_video.c | 8 +++-----
> drivers/acpi/battery.c | 5 ++---
> drivers/acpi/button.c | 5 ++---
> drivers/acpi/ec.c | 5 ++---
> drivers/acpi/hed.c | 3 +--
> drivers/acpi/nfit/core.c | 3 +--
> drivers/acpi/sbs.c | 9 ++++-----
> drivers/acpi/sbshc.c | 7 +++----
> drivers/acpi/thermal.c | 7 +++----
> drivers/acpi/tiny-power-button.c | 10 +++++++---
> drivers/char/sonypi.c | 3 +--
> drivers/char/tpm/tpm_crb.c | 4 +---
> drivers/hv/vmbus_drv.c | 4 +---
> drivers/hwmon/acpi_power_meter.c | 5 ++---
> drivers/hwmon/asus_atk0110.c | 6 ++----
> drivers/input/misc/atlas_btns.c | 4 +---
> drivers/net/fjes/fjes_main.c | 4 +---
> .../platform/chrome/chromeos_privacy_screen.c | 3 +--
> drivers/platform/chrome/wilco_ec/event.c | 4 +---
> drivers/platform/surface/surfacepro3_button.c | 3 +--
> drivers/platform/x86/asus-laptop.c | 3 +--
> drivers/platform/x86/asus-wireless.c | 3 +--
> drivers/platform/x86/classmate-laptop.c | 20 +++++++++----------
> drivers/platform/x86/dell/dell-rbtn.c | 6 ++----
> drivers/platform/x86/eeepc-laptop.c | 3 +--
> drivers/platform/x86/fujitsu-laptop.c | 4 +---
> drivers/platform/x86/fujitsu-tablet.c | 3 +--
> drivers/platform/x86/intel/rst.c | 4 +---
> drivers/platform/x86/lg-laptop.c | 4 +---
> drivers/platform/x86/panasonic-laptop.c | 8 +++-----
> drivers/platform/x86/sony-laptop.c | 9 +++------
> drivers/platform/x86/system76_acpi.c | 4 +---
> drivers/platform/x86/topstar-laptop.c | 3 +--
> drivers/platform/x86/toshiba_acpi.c | 4 +---
> drivers/platform/x86/toshiba_bluetooth.c | 6 +++---
> drivers/platform/x86/toshiba_haps.c | 4 +---
> drivers/platform/x86/wireless-hotkey.c | 3 +--
> drivers/platform/x86/xo15-ebook.c | 3 +--
> drivers/ptp/ptp_vmw.c | 3 +--
> drivers/thermal/intel/intel_menlow.c | 8 +++-----
> drivers/video/backlight/apple_bl.c | 3 +--
Acked-by: Lee Jones <lee@kernel.org>
> drivers/watchdog/ni903x_wdt.c | 4 +---
> drivers/xen/xen-acpi-pad.c | 3 +--
> include/acpi/acpi_bus.h | 2 +-
> 48 files changed, 88 insertions(+), 149 deletions(-)
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-11-07 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 14:57 [RFC PATCH] acpi: make remove callback of acpi driver void Dawei Li
2022-11-06 16:54 ` Uwe Kleine-König
2022-11-07 8:20 ` Lee Jones [this message]
2022-11-07 10:32 ` Hans de Goede
2022-11-07 18:33 ` Dmitry Torokhov
2022-11-09 13:45 ` Greg KH
2022-11-09 14:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2i/zy8CVzTb6qdE@google.com \
--to=lee@kernel.org \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=bleung@chromium.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jgross@suse.com \
--cc=kronos.it@gmail.com \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=set_pte_at@outlook.com \
--cc=sujith.thomas@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vithampi@vmware.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.