From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D431C4332F for ; Mon, 7 Nov 2022 09:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n4ztSeHW9GyAavaOYY3Ndsr7a9qFtoqdegtJYAdJcR8=; b=TycLvi4Jht0oO+ 5GMy8jRiW3pMtz0rZM2r0DkwQjR3yz1qpWwWxO0tt4ZZlCkuGhiPmfis4mOPo5OmAQ8ExE85+brgQ 497slAWTy1eTjth4U7veRS3GSPnc0Pzgt7gYSUBhkbIYM58ZEHFI85HPQN+N+xN4l3j8Iq3a9hKTJ EJv2bJh7XR9kvx3jTV+HEmQyLYEx5T1/K0GcOHfHlAL5hwaQQjZNG+gMHki9a0Qr3BSD41PwZMl+C UpoZio67kItFoixymhdTAlFF3FD4xplyBrKuYmxp93ANHVZ8I25XoVIKSvEhyeRTdAZynyicEENTv r5xpZm3Tl/BDr/CVe7Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ory4n-00D591-HB; Mon, 07 Nov 2022 09:05:53 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ory4C-00D4nP-D1 for linux-arm-kernel@lists.infradead.org; Mon, 07 Nov 2022 09:05:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E3573B80E88; Mon, 7 Nov 2022 09:05:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88B5FC43148; Mon, 7 Nov 2022 09:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667811914; bh=dQUl7/g2deHQHg56f4HOG512Ok3mw3uMyxBnPD5nMGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jspR5KW7AKgSMQTAtag8X2CW6uXYboNG2QGtwY0fLz9dPQ1XMNhJMSQOgM/S8DFRm cre6eWAzcPOIJRFzy5S4mv7mEzUyaC5H5nPeOpJafn522zgwNYwbTaCblwmERvVFvY 6I8D4xuelfUGBH8Gz5OcSaCMlNhMhF2fiLh5+qSQHsR9pw59R3+ejsjr5pvfEODYZw UtorxcVB+qAHX1lATGruS98uqU8Z1tCFlKirAAZaGSlqHTQJ4JYR3ZG4jSB7gRGmCp TQw4lhOvTmgv131tgBYT1UKeEVcDjcWBTr826IqhaN4mhwdZvE3giGqeiCEX8Dd8ub c9aTEjuMYkqvg== Date: Mon, 7 Nov 2022 09:05:09 +0000 From: Lee Jones To: Liu Ying Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_010516_777681_394A6A5F X-CRM114-Status: GOOD ( 41.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwMiBOb3YgMjAyMiwgTGl1IFlpbmcgd3JvdGU6Cgo+IEhpIExlZSwKPiAKPiBPbiBU dWUsIDIwMjItMTEtMDEgYXQgMTM6NTMgKzA4MDAsIExpdSBZaW5nIHdyb3RlOgo+ID4gSGkgTGVl LAo+ID4gCj4gPiBPbiBNb24sIDIwMjItMTAtMzEgYXQgMTU6NDAgKzAwMDAsIExlZSBKb25lcyB3 cm90ZToKPiA+ID4gT24gTW9uLCAxNyBPY3QgMjAyMiwgTGl1IFlpbmcgd3JvdGU6Cj4gPiA+IAo+ ID4gPiA+IEZyZWVzY2FsZSBpLk1YOHF4cCBDb250cm9sIGFuZCBTdGF0dXMgUmVnaXN0ZXJzIChD U1IpIG1vZHVsZSBpcyBhCj4gPiA+ID4gc3lzdGVtCj4gPiA+ID4gY29udHJvbGxlci4gSXQgcmVw cmVzZW50cyBhIHNldCBvZiBtaXNjZWxsYW5lb3VzIHJlZ2lzdGVycyBvZiBhCj4gPiA+ID4gc3Bl Y2lmaWMKPiA+ID4gPiBzdWJzeXN0ZW0uIEl0IG1heSBwcm92aWRlIGNvbnRyb2wgYW5kL29yIHN0 YXR1cyByZXBvcnQgaW50ZXJmYWNlcwo+ID4gPiA+IHRvIGEKPiA+ID4gPiBtaXggb2Ygc3RhbmRh bG9uZSBoYXJkd2FyZSBkZXZpY2VzIHdpdGhpbiB0aGF0IHN1YnN5c3RlbS4KPiA+ID4gPiAKPiA+ ID4gPiBUaGUgQ1NSIG1vZHVsZSBpbiBpLk1YOHFtL3F4cCBTb0NzIGlzIGEgY2hpbGQgbm9kZSBv ZiBhIHNpbXBsZQo+ID4gPiA+IHBvd2VyLW1hbmFnZWQKPiA+ID4gPiBidXMoaS5NWDhxeHAgcGl4 ZWwgbGluayBNU0kgYnVzKS4gVG8gcHJvcGFnYXRlIHBvd2VyIG1hbmFnZW1lbnQKPiA+ID4gPiBv cGVyYXRpb25zCj4gPiA+ID4gb2YgdGhlIENTUiBtb2R1bGUncyBjaGlsZCBkZXZpY2VzIHRvIHRo YXQgc2ltcGxlIHBvd2VyLW1hbmFnZWQKPiA+ID4gPiBidXMsIGFkZCBhCj4gPiA+ID4gZGVkaWNh dGVkIGRyaXZlciBmb3IgdGhlIENTUiBtb2R1bGUuIEFsc28sIHRoZSBkcml2ZXIgd291bGQKPiA+ ID4gPiBwb3B1bGF0ZSB0aGUgQ1NSCj4gPiA+ID4gbW9kdWxlJ3MgY2hpbGQgZGV2aWNlcy4KPiA+ ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMaXUgWWluZyA8dmljdG9yLmxpdUBueHAuY29t Pgo+ID4gPiA+IC0tLQo+ID4gPiA+IFRoZSBGcmVlc2NhbGUgaS5NWDhxeHAgQ1NSIERUIGJpbmRp bmdzIGlzIGF0Cj4gPiA+ID4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9m c2wsaW14OHF4cC1jc3IueWFtbC4KPiA+ID4gPiAKPiA+ID4gPiBSZXNlbmQgdGhlIHBhdGNoIGJh c2VkIG9uIHY2LjEtcmMxLgo+ID4gPiA+IAo+ID4gPiA+ICBkcml2ZXJzL21mZC9LY29uZmlnICAg ICAgICAgICB8IDEwICsrKysrKysKPiA+ID4gPiAgZHJpdmVycy9tZmQvTWFrZWZpbGUgICAgICAg ICAgfCAgMSArCj4gPiA+ID4gIGRyaXZlcnMvbWZkL2ZzbC1pbXg4cXhwLWNzci5jIHwgNTMKPiA+ ID4gPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ICAzIGZpbGVz IGNoYW5nZWQsIDY0IGluc2VydGlvbnMoKykKPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRy aXZlcnMvbWZkL2ZzbC1pbXg4cXhwLWNzci5jCj4gPiAKPiA+IFsuLi5dCj4gPiAKPiA+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvZnNsLWlteDhxeHAtY3NyLmMgYi9kcml2ZXJzL21mZC9m c2wtCj4gPiA+ID4gaW14OHF4cC1jc3IuYwo+ID4gPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4g PiA+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi4zOTE1ZDNkNmNhNjUKPiA+ID4gPiAtLS0gL2Rldi9u dWxsCj4gPiA+ID4gKysrIGIvZHJpdmVycy9tZmQvZnNsLWlteDhxeHAtY3NyLmMKPiA+ID4gPiBA QCAtMCwwICsxLDUzIEBACj4gPiA+ID4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwt Mi4wKwo+ID4gPiA+ICsKPiA+ID4gPiArLyoKPiA+ID4gPiArICogQ29weXJpZ2h0IDIwMjIgTlhQ Cj4gPiA+ID4gKyAqLwo+ID4gPiA+ICsKPiA+ID4gPiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5o Pgo+ID4gPiA+ICsjaW5jbHVkZSA8bGludXgvb2ZfcGxhdGZvcm0uaD4KPiA+ID4gPiArI2luY2x1 ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ID4gPiA+ICsjaW5jbHVkZSA8bGludXgvcG1f cnVudGltZS5oPgo+ID4gPiA+ICsKPiA+ID4gPiArc3RhdGljIGludCBpbXg4cXhwX2Nzcl9wcm9i ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gPiA+ICt7Cj4gPiA+ID4gKwlpbnQg cmV0Owo+ID4gPiA+ICsKPiA+ID4gPiArCXBtX3J1bnRpbWVfZW5hYmxlKCZwZGV2LT5kZXYpOwo+ ID4gPiA+ICsKPiA+ID4gPiArCXJldCA9IGRldm1fb2ZfcGxhdGZvcm1fcG9wdWxhdGUoJnBkZXYt PmRldik7Cj4gPiA+IAo+ID4gPiBUaGUgdXNlIG9mIHRoaXMgQVBJIGRvZXMgbm90IGNvbnN0aXR1 dGUgYSBNRkQuCj4gPiA+IAo+ID4gPiBQbGVhc2UgdXNlICJzaW1wbGUtbWZkIiBpbnN0ZWFkLgo+ ID4gCj4gPiBzaW1wbGUtbWZkIGRldmljZXMgaGF2ZSAiT05MWV9CVVMiIHNldCBpbiBzaW1wbGUt cG0tYnVzLmMsIHNvIHRoZQo+ID4gc2ltcGxlLXBtLWJ1cyBkcml2ZXIgd291bGQgbm90IHBvcHVs YXRlIGNoaWxkIGRldmljZXMgb2Ygc2ltcGxlLW1mZAo+ID4gZGV2aWNlcy4KClJpZ2h0LCBzaW1w bGUtcG0tYnVzIHdpbGwgbm90IHBvcHVsYXRlIGNoaWxkIGRldmljZXMsIGJlY2F1c2U6CgogIC8q ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCiAgICogVGhlc2UgYXJlIHRyYW5zcGFyZW50IGJ1cyBkZXZpY2VzIChub3Qg c2ltcGxlLXBtLWJ1cyBtYXRjaGVzKSB0aGF0ICAKICAgKiBoYXZlIHRoZWlyIGNoaWxkIG5vZGVz IHBvcHVsYXRlZCBhdXRvbWF0aWNhbGx5LiAgU28sIGRvbid0IG5lZWQgdG8gIAogICAqIGRvIGFu eXRoaW5nIG1vcmUuIFdlIG9ubHkgbWF0Y2ggd2l0aCB0aGUgZGV2aWNlIGlmIHRoaXMgZHJpdmVy IGlzICAgCiAgICogdGhlIG1vc3Qgc3BlY2lmaWMgbWF0Y2ggYmVjYXVzZSB3ZSBkb24ndCB3YW50 IHRvIGluY29ycmVjdGx5IGJpbmQgdG8KICAgKiBhIGRldmljZSB0aGF0IGhhcyBhIG1vcmUgc3Bl Y2lmaWMgZHJpdmVyLiAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAqLyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg CgpTbyAic2ltcGxlLW1mZCIgbXVzdCBiZSBwb3B1bGF0ZWQgZWxzZXdoZXJlIGkuZS4gZHJpdmVy cy9vZi9wbGF0Zm9ybS5jLgoKPiA+IEFsc28sIHRoZSBzaW1wbGUtcG0tYnVzIGRyaXZlciB3b3Vs ZCBub3QgZW5hYmxlIHJ1bnRpbWUKPiA+IHBvd2VyIG1hbmFnZW1lbnQgZm9yIHNpbXBsZS1tZmQg ZGV2aWNlcyBkdWUgdG8gIk9OTFlfQlVTIiwgd2hpY2gKPiA+IG1lYW5zIGl0IHdvdWxkIG5vdCBw cm9wYWdhdGUgcG93ZXIgbWFuYWdlbWVudCBvcGVyYXRpb25zIGZyb20gY2hpbGQKPiA+IGRldmlj ZXMgb2Ygc2ltcGxlLW1mZCBkZXZpY2VzIHRvIHBhcmVudCBkZXZpY2VzIG9mIHNpbXBsZS1tZmQK PiA+IGRldmljZXMuICBUaGF0J3Mgd2h5IGEgZGVkaWNhdGVkIGZzbC1pbXg4cXhwLWNzciBkcml2 ZXIgaXMgbmVlZGVkLiAKClRoaXMgaXMgbW9yZSBvZiBhbiBpc3N1ZS4KCldoeSBjYW4ndCB0aGlz IGRldmljZSB1c2UgInNpbXBsZS1wbS1idXMiIHRvIGhhdmUgc3VwcG9ydCBmb3IgYm90aAphdXRv LXJlZ2lzdHJhdGlvbiBBTkQgUnVudGltZSBQTT8KCj4gT25lIG1vcmUgcG9pbnQgd2hpY2ggbWln aHQgYmUgb3Zlcmxvb2tlZCAtIGFzIG1lbnRpb25lZCBpbiBjb21taXQKPiBtZXNzYWdlLCB0aGUg Q1NSIG1vZHVsZSBpcyBhIGNoaWxkIG5vZGUgb2YgYSBzaW1wbGUgcG93ZXItbWFuYWdlZAo+IGJ1 cyhpLk1YOHF4cCBwaXhlbCBsaW5rIE1TSSBidXMpLCB3aGljaCBtZWFucyB0aGUgY2hpbGQgZGV2 aWNlcyBvZiB0aGUKPiBDU1IgbW9kdWxlKGFzIGEgc2ltcGxlLW1mZCBkZXZpY2UpIHdvbid0IGJl IHBvcHVsYXRlZCBieQo+IG9mX3BsYXRmb3JtX2RlZmF1bHRfcG9wdWxhdGUoKSBmcm9tIG9mX3Bs YXRmb3JtX2RlZmF1bHRfcG9wdWxhdGVfaW5pdCgpCj4gYmVjYXVzZSAic2ltcGxlLXBtLWJ1cyIg aXMgbm90IGxpc3RlZCBpbiBvZl9kZWZhdWx0X2J1c19tYXRjaF90YWJsZVtdCj4gYW5kIGhlbmNl IHJlY3Vyc2lvbiBvZiBvZl9wbGF0Zm9ybV9idXNfY3JlYXRlKCkgd2lsbCBzdG9wIGF0IHRoZQo+ IHNpbXBsZS1wbS1idXMuIFRoaXMgaXMgYWxzbyBhIHJlYXNvbiB3aHkgYSBkZWRpY2F0ZWQgZnNs LWlteDhxeHAtY3NyCj4gZHJpdmVyIGlzIG5lZWRlZCB0byBwb3B1bGF0ZWQgdGhvc2UgY2hpbGQg ZGV2aWNlcyBvZiB0aGUgQ1NSIG1vZHVsZS4KCk5vdCBzdXJlIEkga25vdyB0aGUgc2VtYW50aWNz IHdlbGwgZW5vdWdoIChhbnltb3JlKSB0byBnZXQgYQptZWFuaW5nZnVsIHBpY3R1cmUgb2Ygd2hh dCB5b3UncmUgdHJ5aW5nIHRvIGV4cGxhaW4sIGFuZCBJIGRvIG5vdCBoYXZlCmFueSBzdWl0YWJs ZSBIL1cgaGVyZSB0byBtb2NrLXVwIGEgcmVhbC13b3JsZCB0ZXN0LWJlZCAvIGNvbmNlcHQKZGVt b25zdHJhdG9yIHRvIGRlYnVnIHRoaXMgZm9yIHlvdS4KClRoZSBsb25nIGFuZCB0aGUgc2hvcnQg b2YgaXQgaXM7IHdlIGhhdmUgYSBidW5jaCBvZiBhdXRvbWF0aWMKY2hpbGQtZGV2aWNlLXJlZ2lz dGVyaW5nIGhlbHBlcnMgaW4gdGhlIGtlcm5lbC4gIE9uZSBvZiB0aGUgbWVjaGFuaXNtcwppcyBi b3VuZCB0byB3b3JrIGZvciB5b3UgaWYgeW91IHN0cnVjdHVyZSB5b3VyIGNvZGUgYXBwcm9wcmlh dGVseS4KCkludHJvZHVjaW5nIGFuIGVtcHR5LCBtZWFuaW5nbGVzcyBkcml2ZXIsIHNpbXBseSB0 byBjYWxsIGEgc2luZ2xlCmZ1bmN0aW9uIGl0IG5vdCBhY2NlcHRhYmxlLiAgUGxlYXNlIG1ha2Ug dGhlIGluZnJhc3RydWN0dXJlIGFscmVhZHkKb2ZmZXJlZCBzcGVjaWZpY2FsbHkgdG8gc29sdmUg dGhpcyBjYXRlZ29yeSBvZiBpc3N1ZSB3b3JrIGZvciB5b3VyCnVzZS1jYXNlLgoKLS0gCkxlZSBK b25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 239CDC433FE for ; Mon, 7 Nov 2022 09:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbiKGJFT (ORCPT ); Mon, 7 Nov 2022 04:05:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230434AbiKGJFQ (ORCPT ); Mon, 7 Nov 2022 04:05:16 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1451120AD for ; Mon, 7 Nov 2022 01:05:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 343C660F1C for ; Mon, 7 Nov 2022 09:05:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88B5FC43148; Mon, 7 Nov 2022 09:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667811914; bh=dQUl7/g2deHQHg56f4HOG512Ok3mw3uMyxBnPD5nMGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jspR5KW7AKgSMQTAtag8X2CW6uXYboNG2QGtwY0fLz9dPQ1XMNhJMSQOgM/S8DFRm cre6eWAzcPOIJRFzy5S4mv7mEzUyaC5H5nPeOpJafn522zgwNYwbTaCblwmERvVFvY 6I8D4xuelfUGBH8Gz5OcSaCMlNhMhF2fiLh5+qSQHsR9pw59R3+ejsjr5pvfEODYZw UtorxcVB+qAHX1lATGruS98uqU8Z1tCFlKirAAZaGSlqHTQJ4JYR3ZG4jSB7gRGmCp TQw4lhOvTmgv131tgBYT1UKeEVcDjcWBTr826IqhaN4mhwdZvE3giGqeiCEX8Dd8ub c9aTEjuMYkqvg== Date: Mon, 7 Nov 2022 09:05:09 +0000 From: Lee Jones To: Liu Ying Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Nov 2022, Liu Ying wrote: > Hi Lee, > > On Tue, 2022-11-01 at 13:53 +0800, Liu Ying wrote: > > Hi Lee, > > > > On Mon, 2022-10-31 at 15:40 +0000, Lee Jones wrote: > > > On Mon, 17 Oct 2022, Liu Ying wrote: > > > > > > > Freescale i.MX8qxp Control and Status Registers (CSR) module is a > > > > system > > > > controller. It represents a set of miscellaneous registers of a > > > > specific > > > > subsystem. It may provide control and/or status report interfaces > > > > to a > > > > mix of standalone hardware devices within that subsystem. > > > > > > > > The CSR module in i.MX8qm/qxp SoCs is a child node of a simple > > > > power-managed > > > > bus(i.MX8qxp pixel link MSI bus). To propagate power management > > > > operations > > > > of the CSR module's child devices to that simple power-managed > > > > bus, add a > > > > dedicated driver for the CSR module. Also, the driver would > > > > populate the CSR > > > > module's child devices. > > > > > > > > Signed-off-by: Liu Ying > > > > --- > > > > The Freescale i.MX8qxp CSR DT bindings is at > > > > Documentation/devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml. > > > > > > > > Resend the patch based on v6.1-rc1. > > > > > > > > drivers/mfd/Kconfig | 10 +++++++ > > > > drivers/mfd/Makefile | 1 + > > > > drivers/mfd/fsl-imx8qxp-csr.c | 53 > > > > +++++++++++++++++++++++++++++++++++ > > > > 3 files changed, 64 insertions(+) > > > > create mode 100644 drivers/mfd/fsl-imx8qxp-csr.c > > > > [...] > > > > > > diff --git a/drivers/mfd/fsl-imx8qxp-csr.c b/drivers/mfd/fsl- > > > > imx8qxp-csr.c > > > > new file mode 100644 > > > > index 000000000000..3915d3d6ca65 > > > > --- /dev/null > > > > +++ b/drivers/mfd/fsl-imx8qxp-csr.c > > > > @@ -0,0 +1,53 @@ > > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > + > > > > +/* > > > > + * Copyright 2022 NXP > > > > + */ > > > > + > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > + > > > > +static int imx8qxp_csr_probe(struct platform_device *pdev) > > > > +{ > > > > + int ret; > > > > + > > > > + pm_runtime_enable(&pdev->dev); > > > > + > > > > + ret = devm_of_platform_populate(&pdev->dev); > > > > > > The use of this API does not constitute a MFD. > > > > > > Please use "simple-mfd" instead. > > > > simple-mfd devices have "ONLY_BUS" set in simple-pm-bus.c, so the > > simple-pm-bus driver would not populate child devices of simple-mfd > > devices. Right, simple-pm-bus will not populate child devices, because: /* * These are transparent bus devices (not simple-pm-bus matches) that * have their child nodes populated automatically. So, don't need to * do anything more. We only match with the device if this driver is * the most specific match because we don't want to incorrectly bind to * a device that has a more specific driver. */ So "simple-mfd" must be populated elsewhere i.e. drivers/of/platform.c. > > Also, the simple-pm-bus driver would not enable runtime > > power management for simple-mfd devices due to "ONLY_BUS", which > > means it would not propagate power management operations from child > > devices of simple-mfd devices to parent devices of simple-mfd > > devices. That's why a dedicated fsl-imx8qxp-csr driver is needed. This is more of an issue. Why can't this device use "simple-pm-bus" to have support for both auto-registration AND Runtime PM? > One more point which might be overlooked - as mentioned in commit > message, the CSR module is a child node of a simple power-managed > bus(i.MX8qxp pixel link MSI bus), which means the child devices of the > CSR module(as a simple-mfd device) won't be populated by > of_platform_default_populate() from of_platform_default_populate_init() > because "simple-pm-bus" is not listed in of_default_bus_match_table[] > and hence recursion of of_platform_bus_create() will stop at the > simple-pm-bus. This is also a reason why a dedicated fsl-imx8qxp-csr > driver is needed to populated those child devices of the CSR module. Not sure I know the semantics well enough (anymore) to get a meaningful picture of what you're trying to explain, and I do not have any suitable H/W here to mock-up a real-world test-bed / concept demonstrator to debug this for you. The long and the short of it is; we have a bunch of automatic child-device-registering helpers in the kernel. One of the mechanisms is bound to work for you if you structure your code appropriately. Introducing an empty, meaningless driver, simply to call a single function it not acceptable. Please make the infrastructure already offered specifically to solve this category of issue work for your use-case. -- Lee Jones [李琼斯]