From: Brian Masney <bmasney@redhat.com>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shazad Hussain <quic_shazhuss@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: fix UFS reference clocks
Date: Mon, 7 Nov 2022 06:09:12 -0500 [thread overview]
Message-ID: <Y2jnWJ0FI6Fmy8/O@x1> (raw)
In-Reply-To: <20221104092045.17410-2-johan+linaro@kernel.org>
On Fri, Nov 04, 2022 at 10:20:44AM +0100, Johan Hovold wrote:
> There are three UFS reference clocks on SC8280XP which are used as
> follows:
>
> - The GCC_UFS_REF_CLKREF_CLK clock is fed to any UFS device connected
> to either controller.
>
> - The GCC_UFS_1_CARD_CLKREF_CLK and GCC_UFS_CARD_CLKREF_CLK clocks
> provide reference clocks to the two PHYs.
>
> Note that this depends on first updating the clock driver to reflect
> that all three clocks are sourced from CXO. Specifically, the UFS
> controller driver expects the device reference clock to have a valid
> frequency:
>
> ufshcd-qcom 1d84000.ufs: invalid ref_clk setting = 0
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Fixes: 8d6b458ce6e9 ("arm64: dts: qcom: sc8280xp: fix ufs_card_phy ref clock")
> Fixes: f3aa975e230e ("arm64: dts: qcom: sc8280xp: correct ref clock for ufs_mem_phy")
> Link: https://lore.kernel.org/lkml/Y2OEjNAPXg5BfOxH@hovoldconsulting.com/
> Cc: stable@vger.kernel.org # 5.20
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Note that there was no 5.20 kernel; that should be 6.0. Bjorn should be
able to fix this up during merge.
https://en.wikipedia.org/wiki/Linux_kernel_version_history
next prev parent reply other threads:[~2022-11-07 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 9:20 [PATCH 0/2] arm64: dts: qcom: sc8280xp: fix UFS reference clocks and PHY nodes Johan Hovold
2022-11-04 9:20 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp: fix UFS reference clocks Johan Hovold
2022-11-04 9:43 ` Konrad Dybcio
2022-11-07 11:09 ` Brian Masney [this message]
2022-11-07 12:23 ` Johan Hovold
2022-11-04 9:20 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp: update UFS PHY nodes Johan Hovold
2022-11-04 9:41 ` Konrad Dybcio
2022-11-14 17:18 ` Brian Masney
2022-11-14 20:42 ` Brian Masney
2022-12-02 20:58 ` (subset) [PATCH 0/2] arm64: dts: qcom: sc8280xp: fix UFS reference clocks and " Bjorn Andersson
2022-12-06 18:18 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2jnWJ0FI6Fmy8/O@x1 \
--to=bmasney@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.