From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC92BA55; Mon, 7 Nov 2022 13:59:47 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id v1so16307941wrt.11; Mon, 07 Nov 2022 05:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WLRE2IBTL6tXQElQll3pK2nkKzxcUu8aFfReYTDtJOA=; b=FERxbpSxvJWObig+KC/olDuIrKt66020ifjSl9RS1RTy8qNPia6NSLrMFFn9sCtm8w kqcgOm287QqXZ8NhD5QBi09/SagXXxcspAI0N77LpkwD4YthSbEFBLUrS58VF0tBEjst 1AE+o5nuPNdL7zUPAodJSvaLrAjK/cA53eWCc5LGEcrBEh3JIPTEeXMB5CqT4q2dUPB8 Q/bgOTj4Vd4nJjjTAR4rgqN9QmDWwP05zHFXLiCc/A+v1QPMeuxb0hXlmGtbVCg6OcYN Ql+NhKNOmY4Ol61xwpIh9FUrWgop5s3tIQwmTfGJ/2mINF+u00orQQw6xz03AY5NwUKq zmhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WLRE2IBTL6tXQElQll3pK2nkKzxcUu8aFfReYTDtJOA=; b=dZi3ItKPUl1p0ZvgfkoI1h097CkeyKRQqvcn4Xz9UrllSYNJ6uSpnB7yobzpQO7AuH 8It/YgNwLk76Dvqam/qy1qF6bT9G1knHKNVfx83WJJVmX9qBdb+UFvnn3G3/nZzERvIs OhkuKAuD74yOiWNLZs5L6AQrS/cQGrrRSMRls7xec82ui3WverF63gHivzVmU6d72yWc W0cwSloCveMtBEJQpb73OK7WHxC4V7VfN5+/rvqi8KZSWQ9mE1srDeGdlSfsNfQ3eTO9 LRty0s+Vy7SZljvt4A1VfYJX9QtdaL4yhGLTFPjs6kcafJRaTkuZqkWb5JWd92l2d2pW zNag== X-Gm-Message-State: ACrzQf2XNkUJzBLUeEnO0v9M1u8tQOF3mwxSia0PC1jCdxMXFRmrztZl Hy4kKAyaC3NwRca9XskB3bMKmPRq40uPfQ== X-Google-Smtp-Source: AMsMyM5meQNZVUELxa5jjGDahXbbpyEf8m2laiYNEGWKezJ6ex4ZxyyDXhvWeEf+mbYds/VWKUSD0Q== X-Received: by 2002:a5d:49d0:0:b0:236:ba53:ec39 with SMTP id t16-20020a5d49d0000000b00236ba53ec39mr30217611wrs.412.1667829586269; Mon, 07 Nov 2022 05:59:46 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id s25-20020adfa299000000b00236b2804d79sm7809977wra.2.2022.11.07.05.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 05:59:45 -0800 (PST) Date: Mon, 7 Nov 2022 16:59:26 +0300 From: Dan Carpenter To: Alexander Wetzel Cc: oe-kbuild@lists.linux.dev, linux-wireless@vger.kernel.org, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Johannes Berg Subject: Re: [PATCH] wifi: mac80211: convert PS buffering into iTXQ Message-ID: References: <202211060817.mqDPz8T7-lkp@intel.com> <08af0517-fb5f-cfd1-e92b-18306603144f@wetzel-home.de> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08af0517-fb5f-cfd1-e92b-18306603144f@wetzel-home.de> On Mon, Nov 07, 2022 at 02:52:55PM +0100, Alexander Wetzel wrote: > Hi, > > On 07.11.22 09:00, Dan Carpenter wrote: > > Hi Alexander, > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Wetzel/wifi-mac80211-convert-PS-buffering-into-iTXQ/20221101-100832 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main > > patch link: https://lore.kernel.org/r/20221031211815.6666-1-alexander%40wetzel-home.de > > patch subject: [PATCH] wifi: mac80211: convert PS buffering into iTXQ > > config: openrisc-randconfig-m041-20221106 > > compiler: or1k-linux-gcc (GCC) 12.1.0 > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > > > New smatch warnings: > > net/mac80211/tx.c:1145 ieee80211_get_txq() warn: variable dereferenced before check 'vif' (see line 1112) > > vif can't be null here, the existing null check is not needed. > > ieee80211_get_txq() is only used in ieee80211_queue_skb(). Which already > access sdata->vif.type and sets vif to &sdata->vif prior of calling > ieee80211_get_txq(); > > Would dropping the null check in line 1145 be an acceptable solution to get > rid of this warning? > > I'll then would do that in the next revision (v3) of the patch and send that > out after either Johannes has reviewed v2 or serious issues are discovered > by anyone. > You should probably delete the NULL check in a separate patch (I say without looking at any of your patches). This is a Smatch warning and not a GCC warning so it's not like the NULL check hurts anything besides readability. regards, dan carpenter