From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Jan Dąbroś" <jsd@semihalf.com>
Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
gregkh@linuxfoundation.org, arnd@arndb.de, rrangel@chromium.org,
timvp@google.com, apronin@google.com, mw@semihalf.com,
upstream@semihalf.com
Subject: Re: [PATCH v2 3/3] char: tpm: cr50: Move i2c locking to request/relinquish locality ops
Date: Mon, 7 Nov 2022 18:35:54 +0200 [thread overview]
Message-ID: <Y2kz6q9oPrGTRebD@kernel.org> (raw)
In-Reply-To: <CAOtMz3PpurnM8je0o8zSHFEyUCeiyVeZfU1-=vsO6uB2+e0O8w@mail.gmail.com>
On Mon, Nov 07, 2022 at 10:47:44AM +0100, Jan Dąbroś wrote:
> > On Thu, Nov 03, 2022 at 03:54:50PM +0100, Jan Dabros wrote:
> > > Move i2c locking primitives to request_locality and relinquish_locality
> > > callbacks, what effectively blocks TPM bus for the whole duration of
> > > logical TPM operation.
> > >
> > > With this in place, cr50-equipped TPM may be shared with external CPUs -
> > > assuming that underneath i2c controller driver is aware of this setup
> > > (see i2c-designware-amdpsp as an example).
> >
> > Nit: s/CPUs/peripherals/ ? I'm not sure why you want to emphasize external
> > chips having CPU.
>
> My point was that we can have a multi-controller setup and each
> controller may work with the TPM chip, so let me s/CPUs/controllers/.
ack
BR, Jarkko
prev parent reply other threads:[~2022-11-07 16:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 14:54 [PATCH v2 0/3] char: tpm: Adjust cr50_i2c locking mechanism Jan Dabros
2022-11-03 14:54 ` [PATCH v2 1/3] char: tpm: Protect tpm_pm_suspend with locks Jan Dabros
2022-11-06 19:48 ` Jarkko Sakkinen
2022-11-07 8:45 ` Jan Dąbroś
2022-11-07 16:35 ` Jarkko Sakkinen
2022-11-28 17:04 ` Jason A. Donenfeld
2022-11-28 17:07 ` Jason A. Donenfeld
2022-11-28 19:46 ` Vlastimil Babka
2022-11-28 19:55 ` Jason A. Donenfeld
2022-11-28 17:11 ` Vlastimil Babka
2022-11-03 14:54 ` [PATCH v2 2/3] char: tpm: cr50: Use generic request/relinquish locality ops Jan Dabros
2022-11-07 9:20 ` Jarkko Sakkinen
2022-11-07 9:41 ` Jan Dąbroś
2022-11-18 14:09 ` Guenter Roeck
2022-11-03 14:54 ` [PATCH v2 3/3] char: tpm: cr50: Move i2c locking to " Jan Dabros
2022-11-07 9:22 ` Jarkko Sakkinen
2022-11-07 9:47 ` Jan Dąbroś
2022-11-07 16:35 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2kz6q9oPrGTRebD@kernel.org \
--to=jarkko@kernel.org \
--cc=apronin@google.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=jsd@semihalf.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=peterhuewe@gmx.de \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.