Re: [PATCH] submodule: explicitly specify on-demand upon push

[Taylor Blau <me@ttaylorr.com>]

On Mon, Nov 07, 2022 at 04:25:52PM -0800, Jonathan Tan wrote:
> This now means that any push.recurseSubmodules configuration in any
> submodule is no longer respected: only the configuration (or CLI
> argument to override it) of the superproject is used. Update the
> documentation accordingly.

Hmm. Is that a desired outcome or an unfortunate side-effect of the
implementation below?

Not having thought about this a lot, the behavior I might expect is
something along the lines of recursively pushing throughout the
submodule tree, stopping the recursion as soon as we get to a nested
submodule which says "don't push any of my children".

On the other hand, I could sympathize with a compelling argument that
the superproject alone should be in charge of determining what gets
pushed.

Though TBH, it seems like the former is more convincing. If I depend on
an external repository through a submodule, and that repository itself
has submodules, it would be nice to configure (once) that I don't want
to even try and push any of that repository's children.

Thanks,
Taylor