From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: viro@zeniv.linux.org.uk, axboe@kernel.dk,
io-uring@vger.kernel.org, asml.silence@gmail.com,
linux-fsdevel@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 0/4] io_uring: use ITER_UBUF
Date: Mon, 7 Nov 2022 22:54:06 -0800 [thread overview]
Message-ID: <Y2n9DteukhGuvdGe@infradead.org> (raw)
In-Reply-To: <20221107175610.349807-1-kbusch@meta.com>
On Mon, Nov 07, 2022 at 09:56:06AM -0800, Keith Busch wrote:
> 1. io_uring will always prefer using the _iter versions of read/write
> callbacks if file_operations implement both, where as the generic
> syscalls will use .read/.write (if implemented) for non-vectored IO.
There are very few file operations that have both, and for those
the difference matters, e.g. the strange vectors semantics for the
sound code. I would strongly suggest to mirror what the normal
read/write path does here.
> 2. io_uring will use the ITER_UBUF representation for single vector
> readv/writev, but the generic syscalls currently uses ITER_IOVEC for
> these.
Same here. It might be woth to use ITER_UBUF for single vector
readv/writev, but this should be the same for all interfaces. I'd
suggest to drop this for now and do a separate series with careful
review from Al for this.
next prev parent reply other threads:[~2022-11-08 6:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 17:56 [PATCH 0/4] io_uring: use ITER_UBUF Keith Busch
2022-11-07 17:56 ` [PATCH 1/4] iov: add import_ubuf() Keith Busch
2022-11-08 6:55 ` Christoph Hellwig
2022-11-08 16:05 ` Keith Busch
2022-11-07 17:56 ` [PATCH 2/4] io_uring: switch network send/recv to ITER_UBUF Keith Busch
2022-11-07 17:56 ` [PATCH 3/4] io_uring: use ubuf for single range imports for read/write Keith Busch
2022-11-07 17:56 ` [PATCH 4/4] iov_iter: move iter_ubuf check inside restore WARN Keith Busch
2022-11-08 6:54 ` Christoph Hellwig [this message]
2022-11-08 20:25 ` [PATCH 0/4] io_uring: use ITER_UBUF Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2n9DteukhGuvdGe@infradead.org \
--to=hch@infradead.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.