All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Max Kellermann <mk@cm4all.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Max Kellermann <max.kellermann@ionos.com>
Subject: Re: [PATCH] fs/splice: don't block splice_direct_to_actor() after data was read
Date: Mon, 7 Nov 2022 23:37:15 -0800	[thread overview]
Message-ID: <Y2oHK3/MgHQzuepE@infradead.org> (raw)
In-Reply-To: <20221105090421.21237-1-mk@cm4all.com>

On Sat, Nov 05, 2022 at 10:04:21AM +0100, Max Kellermann wrote:
> Since there are no other parameters, I suggest adding the
> SPLICE_F_NOWAIT flag, which is similar to SPLICE_F_NONBLOCK, but
> affects the "non-pipe" file descriptor passed to sendfile() or
> splice().  It translates to IOCB_NOWAIT for regular files.

This looks reasonable to me and matches the read/write side.

>
> For now, I
> have documented the flag to be kernel-internal with a high bit, like
> io_uring does with SPLICE_F_FD_IN_FIXED, but making this part of the
> system call ABI may be a good idea as well.

Yeah, my only comment here is that I see no reason to make this
purely kernel internal.

And while looking at that: does anyone remember why the (public)
SPLICE_F_* aren't in a uapi header?

  reply	other threads:[~2022-11-08  7:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05  9:04 [PATCH] fs/splice: don't block splice_direct_to_actor() after data was read Max Kellermann
2022-11-08  7:37 ` Christoph Hellwig [this message]
2022-11-20 13:19 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2023-09-19  8:12 Max Kellermann
2023-09-19 14:18 ` Christian Brauner
2023-09-20 17:28   ` Jens Axboe
2023-09-20 18:16     ` Max Kellermann
2023-09-25 13:10       ` Christian Brauner
2023-09-26  6:39         ` Max Kellermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2oHK3/MgHQzuepE@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=mk@cm4all.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.