From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Partial abandonment of legacy DRM logging macros
Date: Tue, 8 Nov 2022 14:05:01 +0200 [thread overview]
Message-ID: <Y2pF7TA4BEPG07f7@intel.com> (raw)
In-Reply-To: <20221108114950.2017869-1-tvrtko.ursulin@linux.intel.com>
> @@ -2744,6 +2745,7 @@ add_timeline_fence_array(struct i915_execbuffer *eb,
> const struct drm_i915_gem_execbuffer_ext_timeline_fences *timeline_fences)
> {
> struct drm_i915_gem_exec_fence __user *user_fences;
> + struct drm_device *drm = &eb->i915->drm;
We've said a firm "no" to drm_device pointers in display code at
least. If we want a local device pointer we always make it a 'i915'.
Otherwise you end up with annoying aliases all over the place.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-11-08 12:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 11:49 [Intel-gfx] [PATCH] drm/i915: Partial abandonment of legacy DRM logging macros Tvrtko Ursulin
2022-11-08 11:49 ` Tvrtko Ursulin
2022-11-08 12:01 ` [Intel-gfx] " Jani Nikula
2022-11-08 12:01 ` Jani Nikula
2022-11-08 12:05 ` [Intel-gfx] " Tvrtko Ursulin
2022-11-08 12:05 ` Tvrtko Ursulin
2022-11-08 12:05 ` Ville Syrjälä [this message]
2022-11-08 12:26 ` [Intel-gfx] [PATCH v2] " Tvrtko Ursulin
2022-11-08 12:26 ` Tvrtko Ursulin
2022-11-08 12:32 ` [Intel-gfx] " Jani Nikula
2022-11-08 12:32 ` Jani Nikula
2022-11-08 15:15 ` [Intel-gfx] " Andrzej Hajda
2022-11-08 19:53 ` John Harrison
2022-11-08 19:53 ` John Harrison
2022-11-08 12:42 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Partial abandonment of legacy DRM logging macros (rev2) Patchwork
2022-11-08 13:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-08 17:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-11-09 10:46 ` [Intel-gfx] [PATCH v3] drm/i915: Partial abandonment of legacy DRM logging macros Tvrtko Ursulin
2022-11-09 10:46 ` Tvrtko Ursulin
2022-11-10 11:07 ` [Intel-gfx] " Andrzej Hajda
2022-11-10 11:42 ` Tvrtko Ursulin
2022-11-09 13:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Partial abandonment of legacy DRM logging macros (rev3) Patchwork
2022-11-09 13:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-09 17:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2pF7TA4BEPG07f7@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.