From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Donglin Peng <dolinux.peng@gmail.com>
Cc: peterz@infradead.org, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf tools: exclude the include/perf/ directory
Date: Tue, 8 Nov 2022 18:15:55 -0300 [thread overview]
Message-ID: <Y2rHC5W1qi0PGwc2@kernel.org> (raw)
In-Reply-To: <20221103092704.173391-1-dolinux.peng@gmail.com>
Em Thu, Nov 03, 2022 at 02:27:04AM -0700, Donglin Peng escreveu:
> Commit 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the
> source tree") moved perf_dlfilters.h to the include/perf/ directory
> while include/perf is ignored because it has 'perf' in the name.
> Newly created files in the include/perf/ directory will be ignored.
Thanks, applied.
- Arnaldo
> Can check:
>
> Before:
> $ touch tools/perf/include/perf/junk
> $ git status | grep junk
> $ git check-ignore -v tools/perf/include/perf/junk
> tools/perf/.gitignore:6:perf tools/perf/include/perf/junk
>
> After:
> $ git status | grep junk
> tools/perf/include/perf/junk
> $ git check-ignore -v tools/perf/include/perf/junk
>
> Add !include/perf/ to perf's .gitignore file.
>
> Fixes: 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the source tree")
> Signed-off-by: Donglin Peng <dolinux.peng@gmail.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> Changes in v2:
> - add 'Fixes:' tag in commit message
> - make commit message more clearer
> ---
> tools/perf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> index a653311d9693..fd7a6ff9e7aa 100644
> --- a/tools/perf/.gitignore
> +++ b/tools/perf/.gitignore
> @@ -4,6 +4,7 @@ PERF-GUI-VARS
> PERF-VERSION-FILE
> FEATURE-DUMP
> perf
> +!include/perf/
> perf-read-vdso32
> perf-read-vdsox32
> perf-help
> --
> 2.25.1
--
- Arnaldo
prev parent reply other threads:[~2022-11-08 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 9:27 [PATCH v2] perf tools: exclude the include/perf/ directory Donglin Peng
2022-11-08 21:15 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2rHC5W1qi0PGwc2@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dolinux.peng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.