From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn()
Date: Wed, 9 Nov 2022 14:37:01 +0100 [thread overview]
Message-ID: <Y2us/RKHYLMTrje0@kroah.com> (raw)
In-Reply-To: <Y2uOd+mCwmh4qdm8@smile.fi.intel.com>
On Wed, Nov 09, 2022 at 01:26:47PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 09, 2022 at 12:12:03PM +0100, Rafael J. Wysocki wrote:
> > On Wed, Nov 9, 2022 at 11:51 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > Replace printk(KERN_WARNING) by pr_warn().
> > >
> > > While at it, use %pa for the resource_size_t variables.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > This is Greg's stuff I think.
>
> OK.
>
> ...
>
> > > + resource_size_t end = addr + size - 1;
> >
> > And this change could be mentioned in the changelog too.
>
> And it's (indirectly). This is to have a variable to be consistent in the
> print. But I can add more explicit mention.
Please do.
next prev parent reply other threads:[~2022-11-09 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 10:51 [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn() Andy Shevchenko
2022-11-09 10:51 ` [PATCH v1 2/2] resource: Convert DEFINE_RES_NAMED() to be compound literal Andy Shevchenko
2022-11-09 11:14 ` Rafael J. Wysocki
2022-11-12 4:40 ` kernel test robot
2022-11-09 11:12 ` [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn() Rafael J. Wysocki
2022-11-09 11:26 ` Andy Shevchenko
2022-11-09 13:37 ` Greg Kroah-Hartman [this message]
2022-11-09 15:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2us/RKHYLMTrje0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.