From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14C5BC43219 for ; Wed, 9 Nov 2022 17:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NoYMOPMizJ5t/OmWtsaE8aXHhnkXUkiZC9N3gFYGx9c=; b=J2qRveph1kjXIb ClGhuTF3+0HnpSFWkjuxX/eCw4bCco8F0uReVwWK5jwcS3jMIkANjKLxNU9aRWv634VCYdF8ZxwOs 1cubUsfNGUkOp6CFfsRnLdAuKKqyNvmsb3W91SciGLXg0v6Zzqf0nxK+65OHvaw4eBbtsEiSGPNj2 t3PHA+8Z1CN9V8Ngzi7r3QquRKyBrqIZB9Q0qxRffW0gVeJGqDydKZuNhaLDqZ05do7mdsDPmUlXE GgSjF0MMS+lzmyNFE3G0F2BcHgkRQkd76PIuRwJ/zvkBR9C1L4bo/aiLh6B86y5mdsSpIM3O6SzGh xkN8fXV0AhYiNBT99QVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osoQS-00FIEl-A1; Wed, 09 Nov 2022 16:59:44 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osoQP-00FIBx-4V for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 16:59:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JyqzWiwPZfcvvZni8B+6LuoQxAl6mxqRVFKIRB4evYw=; b=XCZfr5gYSakAuB33bcK/AaWnAP ilf0qpLSv5aDrz4rmJidxHx30jKKdet5IiSHM1oBn9B2vhmedbVo4D1LR3VSmfX42Wd41hx5y2HxF xZfo++vNAJZZ8jKJFZq1xUfq2CsJlO1Umqy1OUPbhKtPExq+s2865l9sGgwwwITP4p1Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1osoPh-001vqB-6F; Wed, 09 Nov 2022 17:58:57 +0100 Date: Wed, 9 Nov 2022 17:58:57 +0100 From: Andrew Lunn To: Noor Azura Ahmad Tarmizi Cc: "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Muhammad Husaini Zulkifli , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Voon Weifeng , Tan Tee Min , Looi Hong Aun , Noor Azura Ahmad Tarmizi Subject: Re: [PATCH net 1/1] net: stmmac: add check for supported link mode before mode change Message-ID: References: <20221109024329.15805-1-noor.azura.ahmad.tarmizi@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221109024329.15805-1-noor.azura.ahmad.tarmizi@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_085941_202761_DED49B4A X-CRM114-Status: UNSURE ( 7.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 10:43:29AM +0800, Noor Azura Ahmad Tarmizi wrote: > From: Noor Azura Ahmad Tarmizi > > Currently, change for unsupported speed and duplex are sent to the phy, > rendering the link to unknown speed (link state down). Something does not seem correct. See: https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/net/phy/phy.c#L816 /* We make sure that we don't pass unsupported values in to the PHY */ linkmode_and(advertising, advertising, phydev->supported); Do you somehow have phydev->supported set wrong? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64756C4332F for ; Wed, 9 Nov 2022 17:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbiKIRCp (ORCPT ); Wed, 9 Nov 2022 12:02:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbiKIRBQ (ORCPT ); Wed, 9 Nov 2022 12:01:16 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC1F248C8; Wed, 9 Nov 2022 08:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JyqzWiwPZfcvvZni8B+6LuoQxAl6mxqRVFKIRB4evYw=; b=XCZfr5gYSakAuB33bcK/AaWnAP ilf0qpLSv5aDrz4rmJidxHx30jKKdet5IiSHM1oBn9B2vhmedbVo4D1LR3VSmfX42Wd41hx5y2HxF xZfo++vNAJZZ8jKJFZq1xUfq2CsJlO1Umqy1OUPbhKtPExq+s2865l9sGgwwwITP4p1Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1osoPh-001vqB-6F; Wed, 09 Nov 2022 17:58:57 +0100 Date: Wed, 9 Nov 2022 17:58:57 +0100 From: Andrew Lunn To: Noor Azura Ahmad Tarmizi Cc: "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Muhammad Husaini Zulkifli , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Voon Weifeng , Tan Tee Min , Looi Hong Aun , Noor Azura Ahmad Tarmizi Subject: Re: [PATCH net 1/1] net: stmmac: add check for supported link mode before mode change Message-ID: References: <20221109024329.15805-1-noor.azura.ahmad.tarmizi@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109024329.15805-1-noor.azura.ahmad.tarmizi@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2022 at 10:43:29AM +0800, Noor Azura Ahmad Tarmizi wrote: > From: Noor Azura Ahmad Tarmizi > > Currently, change for unsupported speed and duplex are sent to the phy, > rendering the link to unknown speed (link state down). Something does not seem correct. See: https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/net/phy/phy.c#L816 /* We make sure that we don't pass unsupported values in to the PHY */ linkmode_and(advertising, advertising, phydev->supported); Do you somehow have phydev->supported set wrong? Andrew