From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D163C433FE for ; Wed, 9 Nov 2022 17:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231482AbiKIRcu (ORCPT ); Wed, 9 Nov 2022 12:32:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230407AbiKIRcs (ORCPT ); Wed, 9 Nov 2022 12:32:48 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4ACA16590 for ; Wed, 9 Nov 2022 09:32:47 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id 130so17345655pfu.8 for ; Wed, 09 Nov 2022 09:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DniZYIrdQUoi19Dm9u4aWgvIz7zq8OgKhX/hNYiha0A=; b=hkP9VUgPvWQqatGgQWkQhRjPcH9wd71PeA8E+GuyDXozXGtxCy7gxSpFLKhRxjAjV3 dCFha/1YCGU7QJwdAnz3SiUrvUi5PK1Ng8SJzGj9OoPdQtovjxy2OcMBUg+eZUydmeaC xCG0NXjsD8zhLnZK7w3QkgK7q4vHRBta6xHaqYT69S31NLLNiTDmTpIYfvvd6IjwHjuq jEHCkZKUTA5le4sLLpNKn6zyHC30cKemYxtap3vnNsBrI9+f5MVP1PHLP4ZZw3gQaU0u et+bTmKPH+TszVA8tKuGcBUP6+s3Jp4g10tdMynZvQL0wjZqAy4URHGESNF/VVxEmGbQ HNNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DniZYIrdQUoi19Dm9u4aWgvIz7zq8OgKhX/hNYiha0A=; b=OvfTd8nMZc98Js9qt2RQPw4z0aJd3SXsH3ny4NGbiTrlIpW9CyFEofqfFx9T/ZzUK2 Xca/uN3QH8dlcTgWdUlbToQP1YRL52B0rK8KVS+NhFXMdxakCZUgXOQ+sQj+1IbbxpSu QkA957P5zdrGh5H3n4HQCOlkJ9Bc4Anckh7S5sCG+jIt5kb9jH/VlhrFQJoMS2G0pOZJ cU6Sas6FHcPf7hEHscZNXJvRt1zxZ5wbs8hK8wcjGIEtzfco8EB5mrCuI8XPsIHRNQyi ndbqzYdtnceKc9ctmSHtCTFArt7xFHccDMGQuDQO2PeQoFVWGNaIzE+LUWwnSxvkpbTo CkQg== X-Gm-Message-State: ACrzQf0ewTSMk9mzR4iEtCBXtv+wT7KvIPKWTHN/6gcT1qzoS45tOv1A xViJZNV7rr57g+njNsRdZbw6yw== X-Google-Smtp-Source: AMsMyM4OiymPkjMx8j345vhKCAFlCTF6IghoE3Ywv5QJvnGEZtrg39P+M9ihrgsG/ZQX+L0MLAbsbw== X-Received: by 2002:a05:6a00:2315:b0:56d:a084:a77d with SMTP id h21-20020a056a00231500b0056da084a77dmr49476799pfh.53.1668015167101; Wed, 09 Nov 2022 09:32:47 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id im23-20020a170902bb1700b0017c37a5a2fdsm9240786plb.216.2022.11.09.09.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 09:32:46 -0800 (PST) Date: Wed, 9 Nov 2022 17:32:43 +0000 From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Levitsky Subject: Re: [PATCH] KVM: svm/avic: Drop "struct kvm_x86_ops" for avic_hardware_setup() Message-ID: References: <20221109115952.92816-1-likexu@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109115952.92816-1-likexu@tencent.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org +Maxim On Wed, Nov 09, 2022, Like Xu wrote: > From: Like Xu > > Even in commit 4bdec12aa8d6 ("KVM: SVM: Detect X2APIC virtualization > (x2AVIC) support"), where avic_hardware_setup() was first introduced, > its only pass-in parameter "struct kvm_x86_ops *ops" is not used at all. I assume the intent was to fill the AVIC ops so that they don't need to be exposed outside of avic.c. I like the idea in theory, but unlike vmx_nested_ops they wouldn't be fully contained, which IMO would make the code as a whole more difficult to follow. Maxim, any objection? > Clean it up a bit to avoid compiler ranting from LLVM toolchain. > > Signed-off-by: Like Xu > --- Reviewed-by: Sean Christopherson