All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Guangbin Huang <huangguangbin2@huawei.com>,
	Hao Chen <chenhao288@hisilicon.com>,
	Sean Anderson <sean.anderson@seco.com>, Tom Rix <trix@redhat.com>,
	Tonghao Zhang <xiangxia.m.yue@gmail.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Marco Bonelli <marco@mebeim.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1] ethtool: ethtool_get_drvinfo: populate drvinfo fields even if callback exits
Date: Wed, 9 Nov 2022 19:52:13 +0200	[thread overview]
Message-ID: <Y2vozcC2ahbhAvhM@unreal> (raw)
In-Reply-To: <20221108035754.2143-1-mailhol.vincent@wanadoo.fr>

On Tue, Nov 08, 2022 at 12:57:54PM +0900, Vincent Mailhol wrote:
> If ethtool_ops::get_drvinfo() callback isn't set,
> ethtool_get_drvinfo() will fill the ethtool_drvinfo::name and
> ethtool_drvinfo::bus_info fields.
> 
> However, if the driver provides the callback function, those two
> fields are not touched. This means that the driver has to fill these
> itself.

Can you please point to such drivers? One can argue that they don't need
to touch these fields in a first place and ethtool_drvinfo should always
overwrite them.

Thanks

  reply	other threads:[~2022-11-09 17:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  3:57 [PATCH net-next v1] ethtool: ethtool_get_drvinfo: populate drvinfo fields even if callback exits Vincent Mailhol
2022-11-09 17:52 ` Leon Romanovsky [this message]
2022-11-09 20:26   ` Jakub Kicinski
2022-11-10  8:34     ` Vincent MAILHOL
2022-11-10  9:11       ` Leon Romanovsky
2022-11-10 11:43         ` Vincent MAILHOL
2022-11-10 12:00           ` Leon Romanovsky
2022-11-10 15:53             ` Vincent MAILHOL
2022-11-10 17:22               ` Leon Romanovsky
2022-11-10 13:41         ` Andrew Lunn
2022-11-10 17:01         ` Jakub Kicinski
2022-11-10 17:20           ` Leon Romanovsky
2022-11-11  6:43           ` Vincent MAILHOL
2022-11-11 16:13             ` Leon Romanovsky
2022-11-10 16:59       ` Jakub Kicinski
2022-11-10 17:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2vozcC2ahbhAvhM@unreal \
    --to=leon@kernel.org \
    --cc=chenhao288@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=huangguangbin2@huawei.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=marco@mebeim.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sean.anderson@seco.com \
    --cc=trix@redhat.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=xiangxia.m.yue@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.