Re: [PATCH] Change git-send-email's sendemail-validate hook to use header information

["brian m. carlson" <sandals@crustytoothpaste.net>]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On 2022-11-09 at 18:23:06, Strawbridge, Michael wrote:
> Since commit-msg and pre-commit git hooks already expose commit
> contents, switch sendemail-validate to use the header information
> of the email that git-send-email intends to send.

I have a couple of thoughts here, and maybe you can explain them a bit
better in the commit message for v2.  First, I'm not sure why this is
valuable.  What do we gain from this that we don't have now?  Why is the
current state inadequate?

Also, how does this handle encoded headers?  I'd like to see some tests
before and after here, especially some including non-ASCII user.name
values so that we can test that we do the right thing here.  If there's
some beneficial improvement here that results in a behaviour change,
then of course we'd want to test that as well.

Finally, since we move the validation code farther down instead of first
thing, is there any place that this would result in a different
behaviour?  For example, --dry-run mode?  Is there any way we could send
data that isn't validated but should be?
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]