All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Bai <jacob.bai.au@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to table.c/h
Date: Thu, 10 Nov 2022 18:53:12 +1100	[thread overview]
Message-ID: <Y2yt6ERX3szKn2W7@jacob-Ubuntu> (raw)
In-Reply-To: <Y2p0dNLBqiWFPzB9@kroah.com>

On Tue, Nov 08, 2022 at 04:23:32PM +0100, Greg KH wrote:
> On Sun, Nov 06, 2022 at 07:31:17PM +1100, Jacob Bai wrote:
> > Same as other rtlwifi drivers, use table.c/h.
> 
> You say what you do here, but not why.
> 
> Why rename the file?  What's wrong with the existing name?  It's not
> causing any problems, right?
> 
> thanks,
> 
> greg k-h
>
No, it's not causing problems. As we are trying to move this driver out
of staging folder, so I checked how current drivers naming
files/variables, turns out they all named those two files as table.c/h.
Maybe we can do the file renaming as the last step.

Jacob

  reply	other threads:[~2022-11-10  7:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06  8:31 [PATCH v4 0/3] staging: rtl8192e: trivial code cleanup patches Jacob Bai
2022-11-06  8:31 ` [PATCH v4 1/3] staging: rtl8192e: rename tables in r8192e_hwimg.c Jacob Bai
2022-11-08 15:23   ` Greg KH
2022-11-06  8:31 ` [PATCH v4 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to table.c/h Jacob Bai
2022-11-08 15:23   ` Greg KH
2022-11-10  7:53     ` Jacob Bai [this message]
2022-11-10  9:28       ` Greg KH
2022-11-06  8:31 ` [PATCH v4 3/3] staging: rtl8192e: replace macro defines with ARRAY_SIZE Jacob Bai
2022-11-08 15:24   ` Greg KH
2022-11-06  8:41 ` [PATCH v4 0/3] staging: rtl8192e: trivial code cleanup patches Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2yt6ERX3szKn2W7@jacob-Ubuntu \
    --to=jacob.bai.au@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.