From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6F9C4332F for ; Thu, 10 Nov 2022 13:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbiKJNYX (ORCPT ); Thu, 10 Nov 2022 08:24:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230368AbiKJNYW (ORCPT ); Thu, 10 Nov 2022 08:24:22 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE3F56A69F for ; Thu, 10 Nov 2022 05:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=/fo/gtxhoEI3kbwoNks9IGR/AaQ3skLg/uKugWTwago=; b=wrb5RAZAKKL5Ibysd/wZgHeSee VVYoA/h8WADkyUn+sexgWJysmoFOD4NQCgBt4Mmd065lPuv7hTkHZnQn3t7Q7wwnf7BGiGJJg80Y/ drXjeCOd0+lHakhucpsxt7LdOXFwoePOFf8ulNGPzeUxvWy3UI6WmWAr5dORnh+7249Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ot7XQ-0022AH-9l; Thu, 10 Nov 2022 14:24:12 +0100 Date: Thu, 10 Nov 2022 14:24:12 +0100 From: Andrew Lunn To: David Thompson Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, cai.huoqing@linux.dev, brgl@bgdev.pl, limings@nvidia.com, chenhao288@hisilicon.com, huangguangbin2@huawei.com, Asmaa Mnebhi Subject: Re: [PATCH net-next v2 1/4] mlxbf_gige: add MDIO support for BlueField-3 Message-ID: References: <20221109224752.17664-1-davthompson@nvidia.com> <20221109224752.17664-2-davthompson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109224752.17664-2-davthompson@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 09, 2022 at 05:47:49PM -0500, David Thompson wrote: > This patch adds initial MDIO support for the BlueField-3 > SoC. Separate header files for the BlueField-2 and the > BlueField-3 SoCs have been created. These header files > hold the SoC-specific MDIO macros since the register > offsets and bit fields have changed. Also, in BlueField-3 > there is a separate register for writing and reading the > MDIO data. Finally, instead of having "if" statements > everywhere to differentiate between SoC-specific logic, > a mlxbf_gige_mdio_gw_t struct was created for this purpose. > > Signed-off-by: David Thompson > Signed-off-by: Asmaa Mnebhi Reviewed-by: Andrew Lunn Andrew