From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: kirill@shutemov.name, dave.hansen@intel.com,
dave.hansen@linux.intel.com, jejb@linux.ibm.com,
linux-kernel@vger.kernel.org, lkp@intel.com,
martin.petersen@oracle.com, oe-kbuild-all@lists.linux.dev,
x86@kernel.org
Subject: Re: [PATCH 2/2] x86/mm: Fix sparse warnings in untagged_ptr()
Date: Thu, 24 Nov 2022 21:36:09 +0200 [thread overview]
Message-ID: <Y3/HqcdjLI2QQMTC@smile.fi.intel.com> (raw)
In-Reply-To: <20221116004353.15052-3-kirill.shutemov@linux.intel.com>
On Wed, Nov 16, 2022 at 03:43:53AM +0300, Kirill A. Shutemov wrote:
> Linear Address Masking patchset triggered a lot of sparse warnings.
>
> The root cause is that casting pointer to '__typeof__(*(ptr)) *' will
> strip all sparse tags. The type has to be defined based on the pointer
> type, not based on what the pointer points to.
>
> Fix cast in untagged_ptr() and avoid __typeof__() usage in
> get/put_user().
Without this patch we have
drivers/auxdisplay/charlcd.c:482:21: warning: incorrect type in assignment (different address spaces)
drivers/auxdisplay/charlcd.c:482:21: expected char const [noderef] __user *__ptr_clean
drivers/auxdisplay/charlcd.c:482:21: got char const *
So,
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Can we have this series applied, please?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-11-24 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 21:41 [tip:x86/mm 5/16] sound/core/hwdep.c:243:24: sparse: sparse: incorrect type in assignment (different address spaces) kernel test robot
2022-11-14 22:55 ` Dave Hansen
2022-11-15 3:40 ` Kirill A. Shutemov
2022-11-15 15:58 ` Kirill A. Shutemov
2022-11-16 0:43 ` [PATCH 0/2] x86/mm: Fix sparse warning due to LAM patchset Kirill A. Shutemov
2022-11-16 0:43 ` [PATCH 1/2] scsi: Fix get_user() in call sg_scsi_ioctl() Kirill A. Shutemov
2022-11-16 0:48 ` Dave Hansen
2022-11-16 0:55 ` kirill
2022-11-16 22:40 ` David Laight
2022-11-17 0:03 ` kirill
2022-11-16 0:43 ` [PATCH 2/2] x86/mm: Fix sparse warnings in untagged_ptr() Kirill A. Shutemov
2022-11-24 19:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3/HqcdjLI2QQMTC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jejb@linux.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.