From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C785C433FE for ; Thu, 24 Nov 2022 15:01:42 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.447969.704658 (Exim 4.92) (envelope-from ) id 1oyDix-0005gE-8m; Thu, 24 Nov 2022 15:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447969.704658; Thu, 24 Nov 2022 15:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyDix-0005g7-68; Thu, 24 Nov 2022 15:01:11 +0000 Received: by outflank-mailman (input) for mailman id 447969; Thu, 24 Nov 2022 15:01:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyDiv-0005g1-6g for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:01:09 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf1900c9-6c08-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 16:01:02 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 89A605C0232; Thu, 24 Nov 2022 10:01:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 24 Nov 2022 10:01:00 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 10:00:58 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf1900c9-6c08-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669302060; x= 1669388460; bh=7oFqqbC1mKV4rv+CQpx7kr5MCr1+PtHfYRd8xId+10c=; b=M KdBJGO4dKzdj9b6tw3P/phwtQGqwUSUh1SGMiTxrs3xCfnqV+9QbwPcg4cxD4QkG pIz28lu4QwWB2IodUN7CoKPf/75JOVp4wOCDl1Fo1rs9sWD+6Lx9qCixWAlZHJZB sXh8c+mZjndWsFjLr5e0r8uEY1KMFOEFe9SLgWOsgwX5FtNOawOxWChixUQQKAR/ P2ezLoy94pIUJPLAbIMZ5d3I8VhvvfC0CZewwOmCQU8+ePFzI5UbYBQ/lAKhDrCJ LdNDbi5YAvNOr6GbDJM+tQ4D4tEv30JpoyYLI9PJaOuFqU5C1daZxNswoDfbITIK 3viFiF0EbqYDJzO9+bemw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669302060; x=1669388460; bh=7oFqqbC1mKV4rv+CQpx7kr5MCr1+ PtHfYRd8xId+10c=; b=qdIdG/dU5awifJfxaHZQdHZT+3MOcuqLOG5PISZgOYgM JGa43fXtJdegHPAcKE0X5KYCg4S9vF758DsMtK6CWurQ5xiaFmqGsRoXllGw0jKD p7wusoGb15PZDUvvWY/UdVTrfZje7dbF2uS6cRtXfFOqURIffVpsoMXpl7n6w8Zh i+cT9GoEtabSaZ9vkEdZOJBH08tx9lPL6wTO8vbq5gMzCEAf2JSKdu2UQyBunBjV VeW9tcgYq3YyxT0U4PPDO1iXz0Ff8J+B4QUN9fKXhGp7Kt8Qu7JsGR69BYwk6wJc 6n3l42hRyzWtxxHIYTJetemoSr8GNiXwT+zwumE0RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhffff iefhgffgvddtledukeelteeiiefggeeftdfgvefgiefgjeeljefgleeigfenucffohhmrg hinheptghithhrihigrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 24 Nov 2022 16:00:55 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc Message-ID: References: <20221123154525.63068-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XdDvxGq+k/7Zofml" Content-Disposition: inline In-Reply-To: --XdDvxGq+k/7Zofml Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 24 Nov 2022 16:00:55 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc On Thu, Nov 24, 2022 at 10:56:33AM +0100, Roger Pau Monn=C3=A9 wrote: > On Thu, Nov 24, 2022 at 09:59:25AM +0100, Roger Pau Monn=C3=A9 wrote: > > On Thu, Nov 24, 2022 at 06:15:15AM +0100, Marek Marczykowski-G=C3=B3rec= ki wrote: > > > But to get dom0 display image from BGRT, it seems something else is > > > needed too. Linux complains "Incorrect checksum in table [BGRT]". The > > > only relevant google result I get is this: https://support.citrix.com= /article/CTX460227/citrix-hypervisor-acpi-warning-incorrect-checksum-in-tab= le-bgrt > > > It blames firmware. But then, it's suspicious that it's also about Xe= n. > > > And also, native Linux on the same hw does not complain about the > > > checksum. So, I think it's rather Xen to blame... > > > The table lives in area marked as EfiACPIReclaimMemory in memory map,= so > > > I think it shouldn't be clobbered by Xen, at least in theory. I'll lo= ok > > > into it later. It's getting off-topic for this thread anyway. > >=20 > > See commit 89238ef7797023f318f82f4f9dddef59c435b8bd. I wonder whether > > the BGRT image region is marked as EFI_MEMORY_RUNTIME, I will have to > > check on my system. >=20 > Just checked on my system, and the BGRT image is placed in a > EfiBootServicesData section with no EFI_MEMORY_RUNTIME attribute. Right, while the BGRT table itself is in EfiACPIReclaimMemory, the image it points to lives in EfiBootServicesData. And no EFI_MEMORY_RUNTIME attribute there either. > To fix this we would need to change efi_arch_process_memory_map() so > it takes the BGRT image address into account and marks the region > where it's placed as reserved. I'm not aware of anyway to get such > address from EFI data, so we would likely need to parse the BGRT in > efi_arch_process_memory_map(). Since Xen has code to do that already, moving it earlier shouldn't be too much issue. Can `acpi_boot_table_init()` be called that early? And then, it sounds very similar to the issue we have with the ESRT table. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --XdDvxGq+k/7Zofml Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN/hygACgkQ24/THMrX 1yw8/wf/UMfVnytzmYbSzL+35d+kawSByy5Icl7RU5ZkNek6HmUUBKOvaFKrRHg3 tHKYP0bDyLTuWuttQ4aSQTBgTCVCLRFH2GFjoGm7JsvdyyL+GsRiT0iGXojpwNxL +VzqawsMyJCPZ8T53BegLGb8OD0BYeswY0Afz3cyPVtWKI1SM8qWPHG5ykfrTX1G hf5b16sZWKmL/DNyv+o6ZwZL02eZnv3WGAmZ/jUVDFN3cD3qcOB+1QBXdNz+WQQz boxs3EKqlFe1j6AzDiQRFfO94XdTEc1GN9jmtq4VlADYm75bqnI74U95x1VnJrs/ HYXaOkYvmYS54WU3V0fPpDDZB+ApWg== =ls6y -----END PGP SIGNATURE----- --XdDvxGq+k/7Zofml--