From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA6EDC433FE for ; Wed, 23 Nov 2022 11:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LDJqmT5vQT2Cnd0banYOukZ9uRrWHE2CrvIlasGgANo=; b=pvBVAbikbxqLUT bydry0qL7bVEgrpP/3I1s5qvDvOu1XErEYnEvAXylcFbORP01TezaVAW0t2cZv1Ysg8dxxYevw4Y5 iqy66pWNvDM/1a4nD5EaSoItkFWSbx3zCd1BE6aitpE5j0UsneN+MZpxByWk9fl0b8rrnpLdVyR6Q Qd3A0jZuP24mPFGPkSWOwGRBljb98l08aZF/51vFE9KtvqtNMf9yxj15xm8t8SbATAv2BWWXp/oNs dV0naX5o7lKPLSxZ7Ct90onH0ePBGgyCQKqS22FP62ukY0wfDnvY7cXRghoJ4pnteqeAT64b7cjIN RaBUBYSs1SYMoln/h8ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxnVc-00GV35-1O; Wed, 23 Nov 2022 11:01:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxnVX-00GV1k-Hq for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2022 11:01:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A274C1FB; Wed, 23 Nov 2022 03:01:38 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.7.154]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A7063F587; Wed, 23 Nov 2022 03:01:30 -0800 (PST) Date: Wed, 23 Nov 2022 11:01:28 +0000 From: Mark Rutland To: Ren Zhijie Cc: catalin.marinas@arm.com, will@kernel.org, yusongping@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: armv8_deprecated: fix unused-function error Message-ID: References: <20221122032010.202956-1-renzhijie2@huawei.com> <28a90ac0-dc8f-f0dd-74d8-d2884e2cbd30@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <28a90ac0-dc8f-f0dd-74d8-d2884e2cbd30@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_030135_652563_80EC77BD X-CRM114-Status: GOOD ( 26.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgMjMsIDIwMjIgYXQgMTA6MDY6MDNBTSArMDgwMCwgUmVuIFpoaWppZSB3cm90 ZToKPiAKPiDlnKggMjAyMi8xMS8yMyAwOjQ4LCBNYXJrIFJ1dGxhbmQg5YaZ6YGTOgo+ID4gT24g VHVlLCBOb3YgMjIsIDIwMjIgYXQgMDM6MjA6MTBBTSArMDAwMCwgUmVuIFpoaWppZSB3cm90ZToK PiA+ID4gSWYgQ09ORklHX1NXUF9FTVVMQVRJT04gaXMgbm90IHNldCBhbmQKPiA+ID4gQ09ORklH X0NQMTVfQkFSUklFUl9FTVVMQVRJT04gaXMgbm90IHNldCwKPiA+ID4gYWFyY2g2NC1saW51eC1n bnUgY29tcGxhaW5lZCBhYm91dCB1bnVzZWQtZnVuY3Rpb24gOgo+ID4gPiAKPiA+ID4gYXJjaC9h cm02NC9rZXJuZWwvYXJtdjhfZGVwcmVjYXRlZC5jOjY3OjIxOiBlcnJvcjog4oCYYWFyY2gzMl9j aGVja19jb25kaXRpb27igJkgZGVmaW5lZCBidXQgbm90IHVzZWQgWy1XZXJyb3I9dW51c2VkLWZ1 bmN0aW9uXQo+ID4gPiAgIHN0YXRpYyB1bnNpZ25lZCBpbnQgYWFyY2gzMl9jaGVja19jb25kaXRp b24odTMyIG9wY29kZSwgdTMyIHBzcikKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIF5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+Cj4gPiA+IGNjMTogYWxsIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQg YXMgZXJyb3JzCj4gPiA+IAo+ID4gPiBUbyBmaXggdGhpcyBlcnJvciwgd2FycCB0aGUgZGVmaW5p dGlvbiBvZgo+ID4gPiBhYXJjaDMyX2NoZWNrX2NvbmRpdGlvbigpIGJ5IGRlZmluZWQoQ09ORklH X1NXUF9FTVVMQVRJT04pIHx8Cj4gPiA+IGRlZmluZWQoQ09ORklHX0NQMTVfQkFSUklFUl9FTVVM QVRJT04pCj4gPiA+IAo+ID4gPiBGaXhlczogMGM1ZjQxNjIxOWRhICgiYXJtNjQ6IGFybXY4X2Rl cHJlY2F0ZWQ6IG1vdmUgYWFyY2gzMiBoZWxwZXIgZWFybGllciIpCj4gPiBUaGlzIGFsc28gZGVw ZW5kcyBvbiBidWlsZGluZyB3aXRoIGFkZGl0aW9uYWwgb3B0aW9ucyB0byB0dXJuIHdhcm5pbmdz IGludG8KPiA+IGVycm9ycywgbm8/Cj4gCj4gTm/vvIxpIGp1c3QgcnVuIHRoZSBub3JtYWwgY29t bWFuZCBhcyBmb2xsb3c6Cj4gCj4gbWFrZSBBUkNIPSJhcm02NCIgQ1JPU1NfQ09NUElMRT0iYWFy Y2g2NC1saW51eC1nbnUtIgoKSSB0aGluayB5b3UgbXVzdCBhbHNvIGhhdmUgQ09ORklHX1dFUlJP UiBlbmFibGVkPwoKSnVzdCBidWlsZGluZyBkZWZjb25maWcgKyBDT05GSUdfQVJNVjhfREVQUkVD QVRFRD15IGdpdmVzIG1lIGEgd2FybmluZywgYnV0IG5vdAphbiBlcnJvciwgYW5kIHRoZSBrZXJu ZWwgYnVpbGRzIGp1c3QgZmluZS4KClNvIHRoaXMgaXMgYSBwcm9ibGVtIHRvIGZpeCwgYW5kIEkg YXBwcmVjaWF0ZSB0aGF0IGluIHRlc3QgY29uZmlncyB0aGlzIG1pZ2h0CmJlIGJyb2tlbiwgYnV0 IGl0J3Mgbm90IGEgZnVsbCBidWlsZC10aW1lIGZhaWx1cmUgZm9yIG1vc3QgdXNlcnMuCgpUaGFu a3MsCk1hcmsuCgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBSZW4gWmhpamllIDxyZW56aGlqaWUyQGh1 YXdlaS5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgIGFyY2gvYXJtNjQva2VybmVsL2FybXY4X2RlcHJl Y2F0ZWQuYyB8IDIgKysKPiA+ID4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4g PiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rZXJuZWwvYXJtdjhfZGVwcmVjYXRl ZC5jIGIvYXJjaC9hcm02NC9rZXJuZWwvYXJtdjhfZGVwcmVjYXRlZC5jCj4gPiA+IGluZGV4IGVk MDc4OGNmNmJiYi4uM2YyOWNlYjY2NTNhIDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2FybTY0L2tl cm5lbC9hcm12OF9kZXByZWNhdGVkLmMKPiA+ID4gKysrIGIvYXJjaC9hcm02NC9rZXJuZWwvYXJt djhfZGVwcmVjYXRlZC5jCj4gPiA+IEBAIC02NCw2ICs2NCw3IEBAIHN0cnVjdCBpbnNuX2VtdWxh dGlvbiB7Cj4gPiA+ICAgI2RlZmluZQlBUk1fT1BDT0RFX0NPTkRJVElPTl9VTkNPTkQJMHhmCj4g PiA+ICsjaWYgZGVmaW5lZChDT05GSUdfU1dQX0VNVUxBVElPTikgfHwgZGVmaW5lZChDT05GSUdf Q1AxNV9CQVJSSUVSX0VNVUxBVElPTikKPiA+ID4gICBzdGF0aWMgdW5zaWduZWQgaW50IGFhcmNo MzJfY2hlY2tfY29uZGl0aW9uKHUzMiBvcGNvZGUsIHUzMiBwc3IpCj4gPiA+ICAgewo+ID4gPiAg IAl1MzIgY2NfYml0cyAgPSBvcGNvZGUgPj4gMjg7Cj4gPiA+IEBAIC03Niw2ICs3Nyw3IEBAIHN0 YXRpYyB1bnNpZ25lZCBpbnQgYWFyY2gzMl9jaGVja19jb25kaXRpb24odTMyIG9wY29kZSwgdTMy IHBzcikKPiA+ID4gICAJfQo+ID4gPiAgIAlyZXR1cm4gQVJNX09QQ09ERV9DT05EVEVTVF9VTkNP TkQ7Cj4gPiA+ICAgfQo+ID4gPiArI2VuZGlmCj4gPiBDb3VsZCB3ZSBtYXJrIHRoaXMgYXMgJ19f bWF5YmVfdW51c2VkJyBvciAnaW5saW5lJyBpbnN0ZWFkPyBJIHRoaW5rIHRoYXQncwo+ID4gcHJl ZmVyYWJsZSB0byB0aGUgaWZkZWZlcnJ5Lgo+IAo+IHN1cmUsIGkgd2lsbCB1c2UgX19tYXliZV91 bnVzZWQgaW4gdjIuCj4gCj4gVGhhbmtzLAo+IAo+IFJlbi4KPiAKPiA+IFRoYW5rcywKPiA+IE1h cmsuCj4gPiAKPiA+ID4gICAjaWZkZWYgQ09ORklHX1NXUF9FTVVMQVRJT04KPiA+ID4gICAvKgo+ ID4gPiAtLSAKPiA+ID4gMi4xNy4xCj4gPiA+IAo+ID4gLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB1A3C433FE for ; Wed, 23 Nov 2022 11:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236742AbiKWLFB (ORCPT ); Wed, 23 Nov 2022 06:05:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237311AbiKWLE1 (ORCPT ); Wed, 23 Nov 2022 06:04:27 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 64E26101E for ; Wed, 23 Nov 2022 03:01:32 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A274C1FB; Wed, 23 Nov 2022 03:01:38 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.7.154]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A7063F587; Wed, 23 Nov 2022 03:01:30 -0800 (PST) Date: Wed, 23 Nov 2022 11:01:28 +0000 From: Mark Rutland To: Ren Zhijie Cc: catalin.marinas@arm.com, will@kernel.org, yusongping@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: armv8_deprecated: fix unused-function error Message-ID: References: <20221122032010.202956-1-renzhijie2@huawei.com> <28a90ac0-dc8f-f0dd-74d8-d2884e2cbd30@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <28a90ac0-dc8f-f0dd-74d8-d2884e2cbd30@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 10:06:03AM +0800, Ren Zhijie wrote: > > 在 2022/11/23 0:48, Mark Rutland 写道: > > On Tue, Nov 22, 2022 at 03:20:10AM +0000, Ren Zhijie wrote: > > > If CONFIG_SWP_EMULATION is not set and > > > CONFIG_CP15_BARRIER_EMULATION is not set, > > > aarch64-linux-gnu complained about unused-function : > > > > > > arch/arm64/kernel/armv8_deprecated.c:67:21: error: ‘aarch32_check_condition’ defined but not used [-Werror=unused-function] > > > static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > > > ^~~~~~~~~~~~~~~~~~~~~~~ > > > cc1: all warnings being treated as errors > > > > > > To fix this error, warp the definition of > > > aarch32_check_condition() by defined(CONFIG_SWP_EMULATION) || > > > defined(CONFIG_CP15_BARRIER_EMULATION) > > > > > > Fixes: 0c5f416219da ("arm64: armv8_deprecated: move aarch32 helper earlier") > > This also depends on building with additional options to turn warnings into > > errors, no? > > No，i just run the normal command as follow: > > make ARCH="arm64" CROSS_COMPILE="aarch64-linux-gnu-" I think you must also have CONFIG_WERROR enabled? Just building defconfig + CONFIG_ARMV8_DEPRECATED=y gives me a warning, but not an error, and the kernel builds just fine. So this is a problem to fix, and I appreciate that in test configs this might be broken, but it's not a full build-time failure for most users. Thanks, Mark. > > > Signed-off-by: Ren Zhijie > > > --- > > > arch/arm64/kernel/armv8_deprecated.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c > > > index ed0788cf6bbb..3f29ceb6653a 100644 > > > --- a/arch/arm64/kernel/armv8_deprecated.c > > > +++ b/arch/arm64/kernel/armv8_deprecated.c > > > @@ -64,6 +64,7 @@ struct insn_emulation { > > > #define ARM_OPCODE_CONDITION_UNCOND 0xf > > > +#if defined(CONFIG_SWP_EMULATION) || defined(CONFIG_CP15_BARRIER_EMULATION) > > > static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > > > { > > > u32 cc_bits = opcode >> 28; > > > @@ -76,6 +77,7 @@ static unsigned int aarch32_check_condition(u32 opcode, u32 psr) > > > } > > > return ARM_OPCODE_CONDTEST_UNCOND; > > > } > > > +#endif > > Could we mark this as '__maybe_unused' or 'inline' instead? I think that's > > preferable to the ifdeferry. > > sure, i will use __maybe_unused in v2. > > Thanks, > > Ren. > > > Thanks, > > Mark. > > > > > #ifdef CONFIG_SWP_EMULATION > > > /* > > > -- > > > 2.17.1 > > > > > .