All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Douglas Anderson <dianders@chromium.org>
Cc: Dan Carpenter <error27@gmail.com>,
	Johnny Chuang <johnny.chuang.emc@gmail.com>,
	linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Input: elants_i2c - delete some dead code
Date: Wed, 23 Nov 2022 09:43:27 +0300	[thread overview]
Message-ID: <Y33BD9xkRC9euIdO@kili> (raw)

We shuffled the error handling around so this condition is dead code
now.  The "error" variable is always zero.

Signed-off-by: Dan Carpenter <error27@gmail.com>
---
No Fixes tag because this does not fix a bug but if we were to assign
a tag it would be:

Fixes: a85fbd649844 ("Input: elants_i2c - properly handle the reset GPIO when power is off")

 drivers/input/touchscreen/elants_i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index e1308e179dd6..af1dc43e988c 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1353,8 +1353,6 @@ static int elants_i2c_power_on(struct elants_data *ts)
 	udelay(ELAN_POWERON_DELAY_USEC);
 
 	gpiod_set_value_cansleep(ts->reset_gpio, 0);
-	if (error)
-		return error;
 
 	msleep(ELAN_RESET_DELAY_MSEC);
 
-- 
2.35.1


             reply	other threads:[~2022-11-23  6:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  6:43 Dan Carpenter [this message]
2022-11-28 13:43 ` [PATCH] Input: elants_i2c - delete some dead code Mattijs Korpershoek
2022-11-28 22:59 ` Doug Anderson
2022-11-29 23:04 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y33BD9xkRC9euIdO@kili \
    --to=error27@gmail.com \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=johnny.chuang.emc@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.