From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ADF5C4321E for ; Wed, 23 Nov 2022 06:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236163AbiKWG7B (ORCPT ); Wed, 23 Nov 2022 01:59:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236165AbiKWG7A (ORCPT ); Wed, 23 Nov 2022 01:59:00 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9F7928B138; Tue, 22 Nov 2022 22:58:56 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6116780F1; Wed, 23 Nov 2022 06:58:55 +0000 (UTC) Date: Wed, 23 Nov 2022 08:58:54 +0200 From: Tony Lindgren To: Rob Herring Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pwm@vger.kernel.org, Thierry Reding , Krzysztof Kozlowski , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221122123225.59106-1-tony@atomide.com> <20221123024153.GB1026269-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221123024153.GB1026269-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Rob Herring [221123 02:31]: > On Tue, Nov 22, 2022 at 02:32:24PM +0200, Tony Lindgren wrote: > > Let's allow node numbering in decimal format too. > > > > Simple human-readable increments/IDs are usually decimal, hex is only for > > addresses as noted by Krzysztof Kozlowski . > > > > Let's use an improved match suggested by Krzysztof Kozlowski > > and improved a bit by Uwe Kleine-König > > . > > > > Cc: linux-pwm@vger.kernel.org > > Cc: Thierry Reding > > Suggested-by: Krzysztof Kozlowski > > Suggested-by: Uwe Kleine-König > > Signed-off-by: Tony Lindgren > > --- > > > > Changes since v2: > > > > - Use pattern suggested by Krzysztof and Uwe > > > > Changes since v1: > > > > - New patch added to deal with pwm-omap-dmtimer binding > > > > --- > > Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > > --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > > @@ -13,7 +13,7 @@ select: false > > > > properties: > > $nodename: > > - pattern: "^pwm(@.*|-[0-9a-f])*$" > > + pattern: "^pwm(@.+|-[0-9a-f]+)?$" > > So now pwm-10 could be either? Yes. > I'm fine with decimal, but can we do that everywhere we do this -N > naming? Do you mean the '[0-9a-f]' users that don't use '[0-9af]+'? These can be found with: $ find Documentation/devicetree/bindings/ -name \*.yaml | \ xargs grep pattern: | grep '\[0-9a-f\]' | grep -v '\[0-9a-f\]+' Not sure if some of these need to intentionally limit the node numbering to 15. If you have some other criteria in mind, let me know :) That sounds like a separate patch though. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 182FBC4332F for ; Wed, 23 Nov 2022 06:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YjK5duypQjYrTWU+oCG+nR1h4QJey/gOJqpAoCfW6P0=; b=s+MTFI90usWNfJ CYxj3vt+6LYfTixz6hQmfBn6CNlEK6MX/6jzGnHmlm85v4rYRufej/Zks8xsp2u1BgCAh167WdEp6 PGUwH50JOVUIDc6nLQun0TLrgi6yCyBRNdLj7FhyTrvTuJYEe7ZgZ53hlebUt5W8EhAoA8KYf27RB yrbneTeULaFqLGMtBhNbgUTrcR7P1rlfuSVk1DRARxSBngByeWhoQIUgfHRWiFuMHkJncuBpsjH7j WSaUJQQDcvZyAg3iX33hjRD6PF3gy5eO/w654Xs/p34Onw/WO0KLhL5pB8JAWdH3HUCI1XeEyycaq tyrSsGnkVQJcbfmrGgjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxjio-00ExgD-KE; Wed, 23 Nov 2022 06:59:02 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxjil-00Exde-8A for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2022 06:59:00 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6116780F1; Wed, 23 Nov 2022 06:58:55 +0000 (UTC) Date: Wed, 23 Nov 2022 08:58:54 +0200 From: Tony Lindgren To: Rob Herring Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pwm@vger.kernel.org, Thierry Reding , Krzysztof Kozlowski , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221122123225.59106-1-tony@atomide.com> <20221123024153.GB1026269-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221123024153.GB1026269-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_225859_347441_BD8FBB1B X-CRM114-Status: GOOD ( 21.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPiBbMjIxMTIzIDAyOjMxXToKPiBPbiBUdWUs IE5vdiAyMiwgMjAyMiBhdCAwMjozMjoyNFBNICswMjAwLCBUb255IExpbmRncmVuIHdyb3RlOgo+ ID4gTGV0J3MgYWxsb3cgbm9kZSBudW1iZXJpbmcgaW4gZGVjaW1hbCBmb3JtYXQgdG9vLgo+ID4g Cj4gPiBTaW1wbGUgaHVtYW4tcmVhZGFibGUgaW5jcmVtZW50cy9JRHMgYXJlIHVzdWFsbHkgZGVj aW1hbCwgaGV4IGlzIG9ubHkgZm9yCj4gPiBhZGRyZXNzZXMgYXMgbm90ZWQgYnkgS3J6eXN6dG9m IEtvemxvd3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPi4KPiA+IAo+ID4gTGV0 J3MgdXNlIGFuIGltcHJvdmVkIG1hdGNoIHN1Z2dlc3RlZCBieSBLcnp5c3p0b2YgS296bG93c2tp Cj4gPiA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPiBhbmQgaW1wcm92ZWQgYSBiaXQg YnkgVXdlIEtsZWluZS1Lw7ZuaWcKPiA+IDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+ Lgo+ID4gCj4gPiBDYzogbGludXgtcHdtQHZnZXIua2VybmVsLm9yZwo+ID4gQ2M6IFRoaWVycnkg UmVkaW5nIDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4gPiBTdWdnZXN0ZWQtYnk6IEtyenlz enRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4KPiA+IFN1Z2dl c3RlZC1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5k ZT4KPiA+IFNpZ25lZC1vZmYtYnk6IFRvbnkgTGluZGdyZW4gPHRvbnlAYXRvbWlkZS5jb20+Cj4g PiAtLS0KPiA+IAo+ID4gQ2hhbmdlcyBzaW5jZSB2MjoKPiA+IAo+ID4gLSBVc2UgcGF0dGVybiBz dWdnZXN0ZWQgYnkgS3J6eXN6dG9mIGFuZCBVd2UKPiA+IAo+ID4gQ2hhbmdlcyBzaW5jZSB2MToK PiA+IAo+ID4gLSBOZXcgcGF0Y2ggYWRkZWQgdG8gZGVhbCB3aXRoIHB3bS1vbWFwLWRtdGltZXIg YmluZGluZwo+ID4gCj4gPiAtLS0KPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvcHdtL3B3bS55YW1sIHwgMiArLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9wd20vcHdtLnlhbWwKPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9wd20vcHdtLnlhbWwKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9wd20vcHdtLnlhbWwKPiA+IEBAIC0xMyw3ICsxMyw3IEBAIHNlbGVjdDogZmFsc2UK PiA+ICAKPiA+ICBwcm9wZXJ0aWVzOgo+ID4gICAgJG5vZGVuYW1lOgo+ID4gLSAgICBwYXR0ZXJu OiAiXnB3bShALip8LVswLTlhLWZdKSokIgo+ID4gKyAgICBwYXR0ZXJuOiAiXnB3bShALit8LVsw LTlhLWZdKyk/JCIKPiAKPiBTbyBub3cgcHdtLTEwIGNvdWxkIGJlIGVpdGhlcj8KClllcy4KCj4g SSdtIGZpbmUgd2l0aCBkZWNpbWFsLCBidXQgY2FuIHdlIGRvIHRoYXQgZXZlcnl3aGVyZSB3ZSBk byB0aGlzIC1OIAo+IG5hbWluZz8KCkRvIHlvdSBtZWFuIHRoZSAnWzAtOWEtZl0nIHVzZXJzIHRo YXQgZG9uJ3QgdXNlICdbMC05YWZdKyc/CgpUaGVzZSBjYW4gYmUgZm91bmQgd2l0aDoKCiQgZmlu ZCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvIC1uYW1lIFwqLnlhbWwgfCBcCgl4 YXJncyBncmVwIHBhdHRlcm46IHwgZ3JlcCAnXFswLTlhLWZcXScgfCBncmVwIC12ICdcWzAtOWEt ZlxdKycKCk5vdCBzdXJlIGlmIHNvbWUgb2YgdGhlc2UgbmVlZCB0byBpbnRlbnRpb25hbGx5IGxp bWl0IHRoZSBub2RlIG51bWJlcmluZwp0byAxNS4KCklmIHlvdSBoYXZlIHNvbWUgb3RoZXIgY3Jp dGVyaWEgaW4gbWluZCwgbGV0IG1lIGtub3cgOikKClRoYXQgc291bmRzIGxpa2UgYSBzZXBhcmF0 ZSBwYXRjaCB0aG91Z2guCgpSZWdhcmRzLAoKVG9ueQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=