From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85974C433FE for ; Wed, 23 Nov 2022 15:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238151AbiKWPMq (ORCPT ); Wed, 23 Nov 2022 10:12:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238305AbiKWPMn (ORCPT ); Wed, 23 Nov 2022 10:12:43 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A5A917E17 for ; Wed, 23 Nov 2022 07:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=YVwegqIeGRMvlOVx9TUybvDtI976bquXSGVDR9S2SDE=; b=rapBTrBJ8BKLpjezJdIIm1lUhD sk6G2Ir98W6mRixraSo2NY+mB8ZcUX1Tovmll/1Qq+TRAxcTzwDSd3SR+/RhCG1WCxVA02oBCvBXF x4zW/hYDLGchamXKAmdXDtaxlzc2GErUB+6iwyNB6pE77YB/2EtCsxzMzTTwgFjMj224=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oxrQ2-003Eah-Ja; Wed, 23 Nov 2022 16:12:10 +0100 Date: Wed, 23 Nov 2022 16:12:10 +0100 From: Andrew Lunn To: Jiri Pirko Cc: Vladimir Oltean , Steve Williams , Jakub Kicinski , netdev@vger.kernel.org, vinicius.gomes@intel.com, xiaoliang.yang_1@nxp.com Subject: Re: [EXT] Re: [PATCH net-next] net/hanic: Add the hanic network interface for high availability links Message-ID: References: <20221118232639.13743-1-steve.williams@getcruise.com> <20221121195810.3f32d4fd@kernel.org> <20221122113412.dg4diiu5ngmulih2@skbuf> <20221123142558.akqff2gtvzrqtite@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > I guess for the same reason other soft netdevice driver are in the > kernel. You can do bridge, bond, etc in a silimilar way you described > here... Performance of tun/tap is also not great. Doing this in the kernel does seem correct. But we need one implementation which can be expanded over time to cover everything in the standard. From what has been said so far, it seems like this implementation focuses on leaf nodes, because that is what the author of the code is interested in. But is the design generic enough it can be expanded to cover everything else? I'm not saying it actually needs to implement it now, we just need to have a vision of how it can be extended to implement the rest. What we don't want is one way for leaf nodes, and a completely different code base for other nodes. Andrew